Commit 22f33765 authored by Josh Bleecher Snyder's avatar Josh Bleecher Snyder

cmd/go, make: remove ccflags

cc is no more.

Change-Id: I8d1bc0d2e471cd9357274204c9bc1fa67cbc272d
Reviewed-on: https://go-review.googlesource.com/3833Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
Reviewed-by: default avatarAndrew Gerrand <adg@golang.org>
parent 3fa90ea9
...@@ -74,8 +74,6 @@ and test commands: ...@@ -74,8 +74,6 @@ and test commands:
-x -x
print the commands. print the commands.
-ccflags 'arg list'
arguments to pass on each 5c, 6c, or 8c compiler invocation.
-compiler name -compiler name
name of compiler to use, as in runtime.Compiler (gccgo or gc). name of compiler to use, as in runtime.Compiler (gccgo or gc).
-gccgoflags 'arg list' -gccgoflags 'arg list'
...@@ -131,7 +129,6 @@ var buildI bool // -i flag ...@@ -131,7 +129,6 @@ var buildI bool // -i flag
var buildO = cmdBuild.Flag.String("o", "", "output file") var buildO = cmdBuild.Flag.String("o", "", "output file")
var buildWork bool // -work flag var buildWork bool // -work flag
var buildGcflags []string // -gcflags flag var buildGcflags []string // -gcflags flag
var buildCcflags []string // -ccflags flag
var buildLdflags []string // -ldflags flag var buildLdflags []string // -ldflags flag
var buildGccgoflags []string // -gccgoflags flag var buildGccgoflags []string // -gccgoflags flag
var buildRace bool // -race flag var buildRace bool // -race flag
...@@ -183,7 +180,6 @@ func addBuildFlags(cmd *Command) { ...@@ -183,7 +180,6 @@ func addBuildFlags(cmd *Command) {
cmd.Flag.BoolVar(&buildX, "x", false, "") cmd.Flag.BoolVar(&buildX, "x", false, "")
cmd.Flag.BoolVar(&buildWork, "work", false, "") cmd.Flag.BoolVar(&buildWork, "work", false, "")
cmd.Flag.Var((*stringsFlag)(&buildGcflags), "gcflags", "") cmd.Flag.Var((*stringsFlag)(&buildGcflags), "gcflags", "")
cmd.Flag.Var((*stringsFlag)(&buildCcflags), "ccflags", "")
cmd.Flag.Var((*stringsFlag)(&buildLdflags), "ldflags", "") cmd.Flag.Var((*stringsFlag)(&buildLdflags), "ldflags", "")
cmd.Flag.Var((*stringsFlag)(&buildGccgoflags), "gccgoflags", "") cmd.Flag.Var((*stringsFlag)(&buildGccgoflags), "gccgoflags", "")
cmd.Flag.Var((*stringsFlag)(&buildContext.BuildTags), "tags", "") cmd.Flag.Var((*stringsFlag)(&buildContext.BuildTags), "tags", "")
...@@ -2648,7 +2644,6 @@ func raceInit() { ...@@ -2648,7 +2644,6 @@ func raceInit() {
} }
buildGcflags = append(buildGcflags, "-race") buildGcflags = append(buildGcflags, "-race")
buildLdflags = append(buildLdflags, "-race") buildLdflags = append(buildLdflags, "-race")
buildCcflags = append(buildCcflags, "-D", "RACE")
if buildContext.InstallSuffix != "" { if buildContext.InstallSuffix != "" {
buildContext.InstallSuffix += "_" buildContext.InstallSuffix += "_"
} }
......
...@@ -93,8 +93,6 @@ and test commands: ...@@ -93,8 +93,6 @@ and test commands:
-x -x
print the commands. print the commands.
-ccflags 'arg list'
arguments to pass on each 5c, 6c, or 8c compiler invocation.
-compiler name -compiler name
name of compiler to use, as in runtime.Compiler (gccgo or gc). name of compiler to use, as in runtime.Compiler (gccgo or gc).
-gccgoflags 'arg list' -gccgoflags 'arg list'
......
...@@ -77,7 +77,6 @@ var testFlagDefn = []*testFlagSpec{ ...@@ -77,7 +77,6 @@ var testFlagDefn = []*testFlagSpec{
{name: "x", boolVar: &buildX}, {name: "x", boolVar: &buildX},
{name: "i", boolVar: &buildI}, {name: "i", boolVar: &buildI},
{name: "work", boolVar: &buildWork}, {name: "work", boolVar: &buildWork},
{name: "ccflags"},
{name: "gcflags"}, {name: "gcflags"},
{name: "exec"}, {name: "exec"},
{name: "ldflags"}, {name: "ldflags"},
...@@ -165,11 +164,6 @@ func testFlags(args []string) (packageNames, passToTest []string) { ...@@ -165,11 +164,6 @@ func testFlags(args []string) (packageNames, passToTest []string) {
if err != nil { if err != nil {
fatalf("invalid flag argument for -%s: %v", f.name, err) fatalf("invalid flag argument for -%s: %v", f.name, err)
} }
case "ccflags":
buildCcflags, err = splitQuotedFields(value)
if err != nil {
fatalf("invalid flag argument for -%s: %v", f.name, err)
}
case "gcflags": case "gcflags":
buildGcflags, err = splitQuotedFields(value) buildGcflags, err = splitQuotedFields(value)
if err != nil { if err != nil {
......
...@@ -25,9 +25,6 @@ ...@@ -25,9 +25,6 @@
# GO_LDFLAGS: Additional 5l/6l/8l arguments to use when # GO_LDFLAGS: Additional 5l/6l/8l arguments to use when
# building the commands. # building the commands.
# #
# GO_CCFLAGS: Additional 5c/6c/8c arguments to use when
# building.
#
# CGO_ENABLED: Controls cgo usage during the build. Set it to 1 # CGO_ENABLED: Controls cgo usage during the build. Set it to 1
# to include all cgo related files, .c and .go file with "cgo" # to include all cgo related files, .c and .go file with "cgo"
# build directive, in the build. Set it to 0 to ignore them. # build directive, in the build. Set it to 0 to ignore them.
...@@ -158,12 +155,12 @@ if [ "$GOHOSTARCH" != "$GOARCH" -o "$GOHOSTOS" != "$GOOS" ]; then ...@@ -158,12 +155,12 @@ if [ "$GOHOSTARCH" != "$GOARCH" -o "$GOHOSTOS" != "$GOOS" ]; then
# CC_FOR_TARGET is recorded as the default compiler for the go tool. When building for the host, however, # CC_FOR_TARGET is recorded as the default compiler for the go tool. When building for the host, however,
# use the host compiler, CC, from `cmd/dist/dist env` instead. # use the host compiler, CC, from `cmd/dist/dist env` instead.
CC=$CC GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH \ CC=$CC GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH \
"$GOTOOLDIR"/go_bootstrap install -ccflags "$GO_CCFLAGS" -gcflags "$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std "$GOTOOLDIR"/go_bootstrap install -gcflags "$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std
echo echo
fi fi
echo "##### Building packages and commands for $GOOS/$GOARCH." echo "##### Building packages and commands for $GOOS/$GOARCH."
CC=$CC_FOR_TARGET "$GOTOOLDIR"/go_bootstrap install $GO_FLAGS -ccflags "$GO_CCFLAGS" -gcflags "$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std CC=$CC_FOR_TARGET "$GOTOOLDIR"/go_bootstrap install $GO_FLAGS -gcflags "$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std
echo echo
rm -f "$GOTOOLDIR"/go_bootstrap rm -f "$GOTOOLDIR"/go_bootstrap
......
...@@ -25,9 +25,6 @@ ...@@ -25,9 +25,6 @@
# GO_LDFLAGS: Additional 5l/6l/8l arguments to use when # GO_LDFLAGS: Additional 5l/6l/8l arguments to use when
# building the commands. # building the commands.
# #
# GO_CCFLAGS: Additional 5c/6c/8c arguments to use when
# building.
#
# CGO_ENABLED: Controls cgo usage during the build. Set it to 1 # CGO_ENABLED: Controls cgo usage during the build. Set it to 1
# to include all cgo related files, .c and .go file with "cgo" # to include all cgo related files, .c and .go file with "cgo"
# build directive, in the build. Set it to 0 to ignore them. # build directive, in the build. Set it to 0 to ignore them.
...@@ -89,12 +86,12 @@ if(~ $sysname vx32) ...@@ -89,12 +86,12 @@ if(~ $sysname vx32)
if(! ~ $GOHOSTARCH $GOARCH || ! ~ $GOHOSTOS $GOOS){ if(! ~ $GOHOSTARCH $GOARCH || ! ~ $GOHOSTOS $GOOS){
echo '# Building packages and commands for host,' $GOHOSTOS/$GOHOSTARCH^. echo '# Building packages and commands for host,' $GOHOSTOS/$GOHOSTARCH^.
GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH \ GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH \
$GOTOOLDIR/go_bootstrap install -ccflags $"GO_CCFLAGS -gcflags $"GO_GCFLAGS -ldflags $"GO_LDFLAGS -v $pflag std $GOTOOLDIR/go_bootstrap install -gcflags $"GO_GCFLAGS -ldflags $"GO_LDFLAGS -v $pflag std
echo echo
} }
echo '# Building packages and commands for' $GOOS/$GOARCH^. echo '# Building packages and commands for' $GOOS/$GOARCH^.
$GOTOOLDIR/go_bootstrap install -ccflags $"GO_CCFLAGS -gcflags $"GO_GCFLAGS -ldflags $"GO_LDFLAGS -v $pflag std $GOTOOLDIR/go_bootstrap install -gcflags $"GO_GCFLAGS -ldflags $"GO_LDFLAGS -v $pflag std
echo echo
rm -f $GOTOOLDIR/go_bootstrap rm -f $GOTOOLDIR/go_bootstrap
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment