Commit a9e50a6b authored by Josh Bleecher Snyder's avatar Josh Bleecher Snyder

cmd/dist: consolidate runtime CPU tests

Instead of running:

go test -short runtime -cpu=1
go test -short runtime -cpu=2
go test -short runtime -cpu=4

Run just:

go test -short runtime -cpu=1,2,4

This is a return to the Go 1.4.2 behavior.

We lose incremental display of progress and
per-cpu timing information, but we don't have
to recompile and relink the runtime test,
which is slow.

This cuts about 10s off all.bash.

Updates #10571.

Change-Id: I6e8c7149780d47439f8bcfa888e6efc84290c60a
Reviewed-on: https://go-review.googlesource.com/9350Reviewed-by: default avatarDave Cheney <dave@cheney.net>
Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
parent 2692f483
...@@ -199,21 +199,18 @@ func (t *tester) registerTests() { ...@@ -199,21 +199,18 @@ func (t *tester) registerTests() {
} }
// Runtime CPU tests. // Runtime CPU tests.
for _, cpu := range []string{"1", "2", "4"} { testName := "runtime:cpu124"
cpu := cpu t.tests = append(t.tests, distTest{
testName := "runtime:cpu" + cpu name: testName,
t.tests = append(t.tests, distTest{ heading: "GOMAXPROCS=2 runtime -cpu=1,2,4",
name: testName, fn: func() error {
heading: "GOMAXPROCS=2 runtime -cpu=1,2,4", cmd := t.dirCmd("src", "go", "test", "-short", t.timeout(300), "runtime", "-cpu=1,2,4")
fn: func() error { // We set GOMAXPROCS=2 in addition to -cpu=1,2,4 in order to test runtime bootstrap code,
cmd := t.dirCmd("src", "go", "test", "-short", t.timeout(300), "runtime", "-cpu="+cpu) // creation of first goroutines and first garbage collections in the parallel setting.
// We set GOMAXPROCS=2 in addition to -cpu=1,2,4 in order to test runtime bootstrap code, cmd.Env = mergeEnvLists([]string{"GOMAXPROCS=2"}, os.Environ())
// creation of first goroutines and first garbage collections in the parallel setting. return cmd.Run()
cmd.Env = mergeEnvLists([]string{"GOMAXPROCS=2"}, os.Environ()) },
return cmd.Run() })
},
})
}
// sync tests // sync tests
t.tests = append(t.tests, distTest{ t.tests = append(t.tests, distTest{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment