Commit c0fca138 authored by Robert Griesemer's avatar Robert Griesemer

spec: comma-ok expressions return untyped boolean 2nd result

Technically a language change, this cleanup is a completely
backward compatible change that brings the boolean results
of comma-ok expressions in line with the boolean results of
comparisons: they are now all untyped booleans.

The implementation effort should be minimal (less than a
handfull lines of code, depending how well factored the
implementation of comma-ok expressions is).

Fixes #8189.

LGTM=iant, r, rsc
R=r, rsc, iant, ken
CC=golang-codereviews
https://golang.org/cl/112320045
parent 2ce052fc
<!--{ <!--{
"Title": "The Go Programming Language Specification", "Title": "The Go Programming Language Specification",
"Subtitle": "Version of July 14, 2014", "Subtitle": "Version of August 5, 2014",
"Path": "/ref/spec" "Path": "/ref/spec"
}--> }-->
...@@ -2626,7 +2626,7 @@ Otherwise <code>a[x]</code> is illegal. ...@@ -2626,7 +2626,7 @@ Otherwise <code>a[x]</code> is illegal.
<p> <p>
An index expression on a map <code>a</code> of type <code>map[K]V</code> An index expression on a map <code>a</code> of type <code>map[K]V</code>
may be used in an assignment or initialization of the special form used in an <a href="#Assignments">assignment</a> or initialization of the special form
</p> </p>
<pre> <pre>
...@@ -2636,11 +2636,9 @@ var v, ok = a[x] ...@@ -2636,11 +2636,9 @@ var v, ok = a[x]
</pre> </pre>
<p> <p>
where the result of the index expression is a pair of values with types yields an additional untyped boolean value. The value of <code>ok</code> is
<code>(V, bool)</code>. In this form, the value of <code>ok</code> is
<code>true</code> if the key <code>x</code> is present in the map, and <code>true</code> if the key <code>x</code> is present in the map, and
<code>false</code> otherwise. The value of <code>v</code> is the value <code>false</code> otherwise.
<code>a[x]</code> as in the single-result form.
</p> </p>
<p> <p>
...@@ -2825,7 +2823,7 @@ r := y.(io.Reader) // r has type io.Reader and y must implement both I and i ...@@ -2825,7 +2823,7 @@ r := y.(io.Reader) // r has type io.Reader and y must implement both I and i
</pre> </pre>
<p> <p>
If a type assertion is used in an <a href="#Assignments">assignment</a> or initialization of the form A type assertion used in an <a href="#Assignments">assignment</a> or initialization of the special form
</p> </p>
<pre> <pre>
...@@ -2835,13 +2833,10 @@ var v, ok = x.(T) ...@@ -2835,13 +2833,10 @@ var v, ok = x.(T)
</pre> </pre>
<p> <p>
the result of the assertion is a pair of values with types <code>(T, bool)</code>. yields an additional untyped boolean value. The value of <code>ok</code> is <code>true</code>
If the assertion holds, the expression returns the pair <code>(x.(T), true)</code>; if the assertion holds. Otherwise it is <code>false</code> and the value of <code>v</code> is
otherwise, the expression returns <code>(Z, false)</code> where <code>Z</code> the <a href="#The_zero_value">zero value</a> for type <code>T</code>.
is the <a href="#The_zero_value">zero value</a> for type <code>T</code>.
No run-time panic occurs in this case. No run-time panic occurs in this case.
The type assertion in this construct thus acts like a function call
returning a value and a boolean indicating success.
</p> </p>
...@@ -3423,7 +3418,7 @@ f(&lt;-ch) ...@@ -3423,7 +3418,7 @@ f(&lt;-ch)
</pre> </pre>
<p> <p>
A receive expression used in an assignment or initialization of the form A receive expression used in an <a href="#Assignments">assignment</a> or initialization of the special form
</p> </p>
<pre> <pre>
...@@ -3433,7 +3428,7 @@ var x, ok = &lt;-ch ...@@ -3433,7 +3428,7 @@ var x, ok = &lt;-ch
</pre> </pre>
<p> <p>
yields an additional result of type <code>bool</code> reporting whether the yields an additional untyped boolean result reporting whether the
communication succeeded. The value of <code>ok</code> is <code>true</code> communication succeeded. The value of <code>ok</code> is <code>true</code>
if the value received was delivered by a successful send operation to the if the value received was delivered by a successful send operation to the
channel, or <code>false</code> if it is a zero value generated because the channel, or <code>false</code> if it is a zero value generated because the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment