Commit f701e1c3 authored by Dave Cheney's avatar Dave Cheney

cmd/6c, cmd/8c: fix stack allocated Biobuf leaking at exit

Fixes #5085.

{6,8}c/swt.c allocates a third Biobuf in automatic memory which is not terminated at the end of the function. This causes the buffer to be 'in use' when the batexit handler fires, confusing valgrind.

Huge thanks to DMorsing for the diagnosis.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/7844044
parent b35019fe
......@@ -320,7 +320,7 @@ outcode(void)
zaddr(&b, &p->from, sf);
zaddr(&b, &p->to, st);
}
Bflush(&b);
Bterm(&b);
close(f);
firstp = P;
lastp = P;
......
......@@ -324,7 +324,7 @@ outcode(void)
zaddr(&b, &p->from, sf);
zaddr(&b, &p->to, st);
}
Bflush(&b);
Bterm(&b);
close(f);
firstp = P;
lastp = P;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment