R=r
CC=golang-dev
https://golang.org/cl/5557053

This matches the other color models. It seems that this was missed
during the review of 5544073.

R=nigeltao, david.crawshaw
CC=golang-dev
https://golang.org/cl/5536057

This will make these tests more meaningful for gccgo, which
runs tests in parallel and has no equivalent to golden.out.

Remove ken/simpprint.go since it duplicates helloworld.go.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5536058

Packages to test are kept in ./testdata together
with the corresponding golden (packagename.out)
file.

To update the golden files, run: go test -update

R=rsc
CC=golang-dev
https://golang.org/cl/5543054

- Use a faster closure-based iterator rather than a channel-based one.
- Otherwise: better code organization, but no other API changes.

R=r, r
CC=golang-dev
https://golang.org/cl/5557051

I'm planning to change these tests, but the gofmt changes are
fairly extensive, so I'm separating the gofmt changes from the
substantive changes.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5557052

R=rsc, r
CC=golang-dev
https://golang.org/cl/5532088

djm recommend that we do this because OpenSSL was only fixed in 2008:
http://anoncvs.mindrot.org/index.cgi/openssh/sshd.c?revision=1.380&view=markup

R=dave, jonathan.mark.pittman
CC=golang-dev
https://golang.org/cl/5555044

    Fixes #2721.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5532090

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5553050

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5532085

gc: fieldnames in structliterals in exported inlines should not be qualified if they're embedded builtin types.

Trust me.
Fixes #2687.

R=rsc
CC=golang-dev
https://golang.org/cl/5545047

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5536053

First was, apart from adding tests, a single line of code (to add the
constructor function). Adding SHA512-based hashing to crypto/hmac
required minor rework of the package because of a previously hardcoded
block-size in it's implementation. Instead of using a hash.Hash
generator function the constructor function now uses a crypto.Hash
type, which was extended to expose information about block size.

The only standard library package impacted by the change is
crypto/tls, for which the fix is included in this patch. It might be
useful to extend gofix to include this API change too.

R=agl, r, rsc, r
CC=golang-dev
https://golang.org/cl/5550043

Fixes #2714.

R=rsc
CC=golang-dev
https://golang.org/cl/5540066

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5556044

bug345.dir/main.go:25:18: error: argument 1 has incompatible type (need explicit conversion; missing method ‘Write’)
bug345.dir/main.go:27:8: error: argument 1 has incompatible type

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5556043

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5536044

Fixes #2643.

R=rsc, d_smithson
CC=golang-dev
https://golang.org/cl/5543068

Fixes #2724.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5555043

We need to avoid allocating an extra word for the interface value
passing the floating-point value as an interface{}. It's easy.

Fixes #2722.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5553044

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5528115

The package documentation did not mention them.
They were described only in godoc for gotest, and that's going away.

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5539079

Follow-on from https://golang.org/cl/5543062.

R=bradfitz, dvyukov
CC=golang-dev
https://golang.org/cl/5539071

Fixes #2720.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5545072

Fixes 2450, probably.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5540074

go test runs the tests itself; it does not run the gotest command,
so these mentions are confusing.

R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5551043

Fixes #1820.

R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/5540073

Fixes #2405

R=rsc
CC=golang-dev
https://golang.org/cl/5539048

On 32-bit machines, %g takes an extra malloc. I don't know why yet,
but this makes the test pass again, and enables it even for -short.

Fixes #2653.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5542055

Fixes #2698

R=rsc
CC=golang-dev
https://golang.org/cl/5539060

R=golang-dev
CC=golang-dev
https://golang.org/cl/5539076

R=golang-dev, duperray.olivier, r
CC=adg, golang-dev
https://golang.org/cl/5542054

        Fixes #2717.

R=r, rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5545069

R=rsc
CC=golang-dev
https://golang.org/cl/5543063

Fixes #1909

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5523047

Fixes #2713.

R=golang-dev, r
CC=golang-dev, mpimenov
https://golang.org/cl/5545065

Mostly copied comments from unix files.

R=rsc
CC=golang-dev
https://golang.org/cl/5533057

Fixes #2652.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5516045

R=golang-dev
CC=golang-dev
https://golang.org/cl/5540062