- 16 Nov, 2016 4 commits
-
-
Bryan C. Mills authored
This ensures that runtime's signal handlers pass through the TSAN and MSAN libc interceptors and subsequent calls to the intercepted sigaction function from C will correctly see them. Fixes #17753. Change-Id: I9798bb50291a4b8fa20caa39c02a4465ec40bb8d Reviewed-on: https://go-review.googlesource.com/33142Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
Change-Id: I897237667ffe9e9b2a5f92251a6f665d29479fd2 Reviewed-on: https://go-review.googlesource.com/33255Reviewed-by:
-
Ian Lance Taylor authored
Add an explicit WriteString method to closeOnce that acquires the writers lock. This overrides the one promoted from the embedded *os.File field. The promoted one naturally does not acquire the lock, and can therefore race with the Close method. Fixes #17647. Change-Id: I3460f2a0d503449481cfb2fd4628b4855ab0ecdf Reviewed-on: https://go-review.googlesource.com/33298 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Both automated updates with a few tweaks. Change-Id: I24579a8dcc32a84a4fff5c2212681ef30dda61d1 Reviewed-on: https://go-review.googlesource.com/33297Reviewed-by:
-
- 15 Nov, 2016 14 commits
-
-
Vladimir Stefanovic authored
Only exe buildmode without cgo supported. Change-Id: Id104a79a99d3285c04db00fd98b8affa94ea3c37 Reviewed-on: https://go-review.googlesource.com/31487 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Ian Lance Taylor authored
Change-Id: Ie7512cc27436cde53b58686b32a0389849a365e4 Reviewed-on: https://go-review.googlesource.com/33249 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David du Colombier authored
These bind flags were removed by mistake in CL 2167. Fixes #17921. Change-Id: I1e8089dade30a212b8db0b216c8299946d924d4b Reviewed-on: https://go-review.googlesource.com/33271Reviewed-by:
-
Ian Lance Taylor authored
Change-Id: I05f31938f3736100bd8b20a150c9fe3a6ffcdeae Reviewed-on: https://go-review.googlesource.com/33245Reviewed-by:
-
Ian Lance Taylor authored
If a C union type (or a C++ class type) can contain a pointer field, then run the cgo checks on pointers to that type. This will test the pointer as though it were an unsafe.Pointer, and will crash if it points to Go memory that contains a pointer. Fixes #15942. Change-Id: Ic2d07ed9648d4b27078ae7683e26196bcbc59fc9 Reviewed-on: https://go-review.googlesource.com/33237 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
Updates #17821 Change-Id: Iebd2e88b2d4f3d757ffad72456f4bfc0607d8110 Reviewed-on: https://go-review.googlesource.com/33162 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
In plugins and every program that opens a plugin, include a hash of every imported package. There are two versions of each hash: one local and one exported. As the program starts and plugins are loaded, the first exported symbol for each package becomes the canonical version. Any subsequent plugin's local package hash symbol has to match the canonical version. Fixes #17832 Change-Id: I4e62c8e1729d322e14b1673bada40fa7a74ea8bc Reviewed-on: https://go-review.googlesource.com/33161Reviewed-by:
-
Ian Lance Taylor authored
Fixes #17900. Change-Id: I42cda6ac9cf48ed739d3a015a90b3cb15edf8ddf Reviewed-on: https://go-review.googlesource.com/33243 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
I guess this was fixed at some point. Remove a skipped test in net/http and add an explicit test in net. Fixes #17695 Change-Id: Idb9f3e236b726bb45098474b830c95c1fce57529 Reviewed-on: https://go-review.googlesource.com/33242 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Apparently when GOMAXPROCS == 1 a simple sched_yield in a tight loop is not necessarily sufficient to permit a signal handler to run. Instead, sleep for 1/1000 of a second. Fixes #16649. Change-Id: I83910144228556e742b7a92a441732ef61aa49d9 Reviewed-on: https://go-review.googlesource.com/33239 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Caleb Spare authored
This change redoes the fix for #16101 (CL 31092) in a different way by making t.Clone return the template associated with the t.Name() while allowing for the case that a template of the same name is define-d. Fixes #17735. Change-Id: I1e69672390a4c81aa611046a209008ae4a3bb723 Reviewed-on: https://go-review.googlesource.com/33210 Run-TryBot: Caleb Spare <cespare@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Mikio Hara authored
Change-Id: I9a42cb55544185ade20b2a4a9de5d39a6cfc6fc6 Reviewed-on: https://go-review.googlesource.com/33172Reviewed-by:
-
Brad Fitzpatrick authored
Updates x/net/http2 to x/net git rev 00ed5e9 for: http2: schedule RSTStream writes onto its stream's queue https://golang.org/cl/33238 Fixes #17243 Change-Id: I79cc5d15bf69ead28d549d4f798c12f4ee2a2201 Reviewed-on: https://go-review.googlesource.com/33241Reviewed-by: -
Rob Pike authored
Instead of scanning the text to count newlines, which is n², keep track as we go and store the line number in the token. benchmark old ns/op new ns/op delta BenchmarkParseLarge-4 1589721293 38783310 -97.56% Fixes #17851 Change-Id: I231225c61e667535e2ce55cd2facea6d279cc59d Reviewed-on: https://go-review.googlesource.com/33234 Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 14 Nov, 2016 6 commits
-
-
Brad Fitzpatrick authored
Updates x/net/http2 to x/net git rev 6dfeb344 for: http2: make Server respect http1 Server's SetKeepAlivesEnabled https://golang.org/cl/33153 And adds a test in std. Fixes #17717 Change-Id: I3ba000abb6f3f682261e105d8a4bb93bde6609fe Reviewed-on: https://go-review.googlesource.com/33231 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Tom Bergan <tombergan@google.com>
-
Brad Fitzpatrick authored
This reverts commit 794fb71d. Reason for revert: submitted without TryBots and it broke all three race builders. Change-Id: I80a1e566616f0ee8fa3529d4eeee04268f8a713b Reviewed-on: https://go-review.googlesource.com/33232Reviewed-by:
-
Marcel Edmund Franke authored
comment on unexported function starts with wrong functionname Change-Id: Ib16c2fe42b5a8d4606ed719f620923c17839d091 Reviewed-on: https://go-review.googlesource.com/33203Reviewed-by:
-
Rob Pike authored
Instead of scanning the text to count newlines, which is n², keep track as we go and store the line number in the token. benchmark old ns/op new ns/op delta BenchmarkParseLarge-4 1589721293 38783310 -97.56% Fixes #17851 Change-Id: Ieaf89a35e371b405ad92e38baa1e3fa98d18cfb4 Reviewed-on: https://go-review.googlesource.com/32923Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Josh Bleecher Snyder authored
These are functionality tests, not formatter tests. I also tested manually that 'go test cmd/go' without -short still passes. Change-Id: Id146e1dc3b65e19ea531869725cd0b97f4801b8b Reviewed-on: https://go-review.googlesource.com/33169 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Jesse Szwedko authored
Previously, `os.Clearenv()` (by way of `syscall.Clearenv`) would simply set all environment variables' values to `""` rather than actually unsetting them causing subsequent `os.LookupEnv` calls to return that they were still set. Fixes #17902 Change-Id: I54081b4b98665e9a39f55ea7582c8d40bb8a2a22 Reviewed-on: https://go-review.googlesource.com/33168 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
- 13 Nov, 2016 7 commits
-
-
David du Colombier authored
Deadlines have been implemented on Plan 9 in CL 31521. Enable the following tests: - TestServerTimeouts - TestOnlyWriteTimeout - TestTLSHandshakeTimeout - TestIssue4191_InfiniteGetTimeout - TestIssue4191_InfiniteGetToPutTimeout Updates #7237. Change-Id: If5e75cfaa9133dcf9ce6aac9fc2badafc1612b64 Reviewed-on: https://go-review.googlesource.com/33197 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David du Colombier authored
Change-Id: I3c664201baef6d7dbed94dab63db0ac974bf6817 Reviewed-on: https://go-review.googlesource.com/33198 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
-
Josh Bleecher Snyder authored
This reverts commit f15915af. CL 32851 fixed cmd/vet's handling of fmt.Formatter. Updates #17057. Change-Id: I3409100d16037645946fe7fe78fbb173e1648494 Reviewed-on: https://go-review.googlesource.com/33166 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Josh Bleecher Snyder authored
Fixes these vet complaints: net/error_test.go:254: unrecognized printf flag for verb 'T': '#' os/os_test.go:1067: arg mt for printf verb %d of wrong type: time.Time runtime/debug/garbage_test.go:83: arg dt for printf verb %d of wrong type: time.Time Change-Id: I0e986712a4b083b75fb111e687e424d06a85a47b Reviewed-on: https://go-review.googlesource.com/33167 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Thordur Bjornsson authored
Mention that it specifically returns x / 2, and do the same for EncodedLen. Change-Id: Ie334f5abecbc487caf4965abbcd14442591bef2a Change-Id: Idfa413faad487e534489428451bf736b009293d6 Reviewed-on: https://go-review.googlesource.com/33191Reviewed-by:
-
David du Colombier authored
Deadlines have been implemented on Plan 9 in CL 31521. Enable the following tests: - TestReadTimeout - TestReadFromTimeout - TestWriteTimeout - TestWriteToTimeout - TestReadTimeoutFluctuation - TestVariousDeadlines - TestVariousDeadlines1Proc - TestVariousDeadlines4Proc - TestReadWriteDeadlineRace Change-Id: I221ed61d55f7f1e4345b37af6748c04e1e91e062 Reviewed-on: https://go-review.googlesource.com/33196 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Dhananjay Nakrani authored
Updates #17057. Change-Id: I54c838d3a44007d4023754e42971e91bfb5e8612 Reviewed-on: https://go-review.googlesource.com/32851 Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 12 Nov, 2016 9 commits
-
-
Martin Möhrmann authored
Simplifies https://golang.org/cl/33145 which fixed #17720. Change-Id: Ib922d493cdc5920832dc95b55094796baca7243e Reviewed-on: https://go-review.googlesource.com/33194Reviewed-by:
-
David du Colombier authored
This issue has been fixed in CL 31390. Change-Id: I0c2425fd33be878037d10d612a50116a7b693431 Reviewed-on: https://go-review.googlesource.com/33195 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
-
Joe Tsai authored
Updates #16360 Change-Id: I66ff23e0501363f58fe891d5e95806422071f93b Reviewed-on: https://go-review.googlesource.com/30162 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Patrick Lee authored
Don't verify tls host when profiling https+insecure://host/port/..., as per discussion in https://go-review.googlesource.com/#/c/20885/. Fixes: #11468 Change-Id: Ibfc236e5442a00339334602a4014e017c62d9e7a Reviewed-on: https://go-review.googlesource.com/33157Reviewed-by:
-
David du Colombier authored
Deadlines have been implemented on Plan 9 in CL 31521. Fixes #17477. Change-Id: Icb742ac30933b6d2f9350fc4e6acbcd433c66c21 Reviewed-on: https://go-review.googlesource.com/33190Reviewed-by:
-
Brad Fitzpatrick authored
Add a variant of sync/atomic's TestUnaligned64 to runtime/internal/atomic. Skips the test on arm for now where it's currently failing. Updates #17786 Change-Id: If63f9c1243e9db7b243a95205b2d27f7d1dc1e6e Reviewed-on: https://go-review.googlesource.com/33159 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #17826 Updates #17302 Change-Id: I7c1ebd965e679e7169a97e62d27ae3ede2473aa1 Reviewed-on: https://go-review.googlesource.com/33152Reviewed-by:
-
David du Colombier authored
This change is an experimental implementation of asynchronous cancelable I/O operations on Plan 9, which are required to implement deadlines. There are no asynchronous syscalls on Plan 9. I/O operations are performed with blocking pread and pwrite syscalls. Implementing deadlines in Go requires a way to interrupt I/O operations. It is possible to interrupt reads and writes on a TCP connection by forcing the closure of the TCP connection. This approach has been used successfully in CL 31390. However, we can't implement deadlines with this method, since we require to be able to reuse the connection after the timeout. On Plan 9, I/O operations are interrupted when the process receives a note. We can rely on this behavior to implement a more generic approach. When doing an I/O operation (read or write), we start the I/O in its own process, then wait for the result asynchronously. The process is able to handle the "hangup" note. When receiving the "hangup" note, the currently running I/O operation is canceled and the process returns. This way, deadlines can be implemented by sending an "hangup" note to the process running the blocking I/O operation, after the expiration of a timer. Fixes #11932. Fixes #17498. Change-Id: I414f72c7a9a4f9b8f9c09ed3b6c269f899d9b430 Reviewed-on: https://go-review.googlesource.com/31521Reviewed-by:
-
Ian Lance Taylor authored
1e-9 has a 1 in the last place, causing some Duration calculations to have unnecessary rounding errors. 1e9 does not, so use that instead. Change-Id: I96334a2c47e7a014b532eb4b8a3ef9550e7ed057 Reviewed-on: https://go-review.googlesource.com/33116 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
