An error occurred fetching the project authors.
- 07 Mar, 2011 1 commit
-
-
Rob Pike authored
Still to do: **T. R=rsc CC=golang-dev https://golang.org/cl/4247061
-
- 06 Mar, 2011 1 commit
-
-
Rob Pike authored
A change a while back stop sending data for unexported fields but due to an oversight the type info was being sent also. It's inconsequential but wrong to do that. R=rsc, rh CC=golang-dev https://golang.org/cl/4252058
-
- 04 Mar, 2011 2 commits
-
-
Rob Pike authored
These allow data items to control their own representation. For now, the implementation requires that the value passed to Encode and Decode must be exactly the type of the methods' receiver; it cannot be, for instance, T if the receiver is of type *T. This will be fixed in a later CL. R=rsc CC=golang-dev https://golang.org/cl/4235051
-
Rob Pike authored
This allows a data item that can marshal itself to be transmitted by its own encoding, enabling some types to be handled that cannot be normally, plus providing a way to use gobs on data with unexported fields. In this CL, the necessary methods are protected by leading _, so only package gob can use the facilities (in its tests, of course); this code is not ready for real use yet. I could be talked into enabling it for experimentation, though. The main drawback is that the methods must be implemented by the actual type passed through, not by an indirection from it. For instance, if *T implements GobEncoder, you must send a *T, not a T. This will be addressed in due course. Also there is improved commentary and a couple of unrelated minor bug fixes. R=rsc CC=golang-dev https://golang.org/cl/4243056
-
- 03 Mar, 2011 1 commit
-
-
Russ Cox authored
This change makes it possible to take the address of a struct field or slice element in order to call a method that requires a pointer receiver. Existing code that uses the Value.Addr method will have to change (as gob does in this CL) to call UnsafeAddr instead. R=r, rog CC=golang-dev https://golang.org/cl/4239052
-
- 25 Feb, 2011 1 commit
-
-
Rob Pike authored
Before this fix, types such as type T map[string]T caused infinite recursion in the gob implementation. Now they just work. Fixes #1518. R=rsc CC=golang-dev https://golang.org/cl/4230045
-
- 23 Feb, 2011 1 commit
-
-
Rob Pike authored
There are further changes required for things like recursive map types. Recursive struct types work but the mechanism needs generalization. The case handled in this CL is pathological since it cannot be represented at all by gob, so it should be handled separately. (Prior to this CL, encode would recur forever.) R=rsc CC=golang-dev https://golang.org/cl/4206041
-
- 22 Feb, 2011 1 commit
-
-
Rob Pike authored
Other than maybe cleaning the code up a bit, this has little practical effect for now, but lays the foundation for remembering the method set of a type, which can be expensive. R=rsc CC=golang-dev https://golang.org/cl/4193041
-
- 14 Feb, 2011 1 commit
-
-
Rob Pike authored
Yesterday's change was too simple-minded and failed if an interface value was being discarded. We need to parse the data stream and remember any type information that arrives. Also fix a minor bug when ignoring an interface: toss only what we know about, not everything. R=rsc CC=golang-dev https://golang.org/cl/4179045
-
- 28 Jan, 2011 1 commit
-
-
Rob Pike authored
Also clean up the code, make it more regular. Fixes #1416. R=rsc CC=golang-dev https://golang.org/cl/3985047
-
- 21 Jan, 2011 1 commit
-
-
Rob Pike authored
Re-implement the debugging helper to be independent of the existing implementation. This is preparatory to a rewrite to clean up issue 1416. Include a definition of the grammar of the data stream. R=rsc CC=golang-dev https://golang.org/cl/3970045
-
- 20 Jan, 2011 1 commit
-
-
Russ Cox authored
also: cmplx -> complex float64(1.0) -> 1.0 float64(1) -> 1.0 R=gri, r, gri1, r2 CC=golang-dev https://golang.org/cl/3991043
-
- 12 Jan, 2011 1 commit
-
-
Rob Pike authored
No functional (ha!) change. R=rsc CC=golang-dev https://golang.org/cl/3959041
-
- 11 Jan, 2011 1 commit
-
-
Rob Pike authored
Such fields are simply ignored. R=rsc, r2 CC=golang-dev https://golang.org/cl/3889043
-
- 05 Jan, 2011 1 commit
-
-
Rob Pike authored
(with maybe more to come) by printing a human-readable representation of a remote type. R=rsc CC=golang-dev https://golang.org/cl/3802045
-
- 31 Oct, 2010 1 commit
-
-
Rob Pike authored
1) Be sure to use the eval-time encoder/decoder rather than the compile-time decoder. In a few cases the receiver for the compiling encoder was being pickled incorrectly into a closure. (This is the fix for issue 1238). 2) Get the innermost name right when given a pointer to an unnamed type. 3) Use a count to delineate interface values, making it possible to ignore values without having a concrete type to encode into. This is a protocol change but only for the new feature, so it shouldn't affect anyone. The old test worked because, amazingly, it depended on bug #1. Fixes #1238. R=rsc, albert.strasheim CC=golang-dev https://golang.org/cl/2806041
-
- 22 Oct, 2010 3 commits
-
-
Rob Pike authored
Simplify error handling during the compilation phase. R=rsc CC=golang-dev https://golang.org/cl/2652042
-
Rob Pike authored
Remove err from the encoderState and decoderState types, so we're not always copying to and from various copies of the error, and then use panic/recover to eliminate lots of error checking. another pass might take a crack at the same thing for the compilation phase. R=rsc CC=golang-dev https://golang.org/cl/2660042
-
Rob Pike authored
The implemetation describes each value as a string identifying the concrete type of the value, followed by the usual encoding of that value. All types to be exchanged as contents of interface values must be registered ahead of time with the new Register function. Although this would not seem strictly necessary, the linker garbage collects unused types so without some mechanism to guarantee the type exists in the binary, there could be unpleasant surprises. Moreover, the receiver needs a reflect.Type of the value to be written in order to be able to save the data. A Register function seems necessary. The implementation may require defining types in the middle of of sending a value. The old code never did this. Therefore there has been some refactoring to make the encoder and decoder work recursively. This change changes the internal type IDs. Existing gob archives will break with this change. Apologies for that. If this is a deal breaker it should be possible to create a conversion tool. Error handling is too complicated in this code. A subsequent change should clean it up. R=rsc CC=golang-dev https://golang.org/cl/2618042
-
- 19 Sep, 2010 1 commit
-
-
Rob Pike authored
The decoder was crashing when handling an rpc that expected a struct but was delivered something else. This diagnoses the problem. The other direction (expecting non-struct but getting one) was already handled. R=rsc CC=golang-dev https://golang.org/cl/2246041
-
- 12 Sep, 2010 1 commit
-
-
Russ Cox authored
Fixes #1099. R=ken2, r CC=golang-dev https://golang.org/cl/2147047
-
- 11 Sep, 2010 1 commit
-
-
Rob Pike authored
1) hack regalloc to leave R9 (m) and R10 (g) alone. the real fix is tricker, but this gets us running 2) fix up the few places in the package sources that the shortage of registers affects, by simplifying some expressions. all of this should be reverted when the right fix is in. Fixes #1084. R=rsc CC=golang-dev https://golang.org/cl/2132046
-
- 29 Jun, 2010 1 commit
-
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/1698045
-
- 28 Jun, 2010 1 commit
-
-
Rob Pike authored
also fix a bug handling nil maps: before, would needlessly send empty map R=rsc CC=golang-dev https://golang.org/cl/1739043
-
- 24 Jun, 2010 1 commit
-
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/1708048
-
- 21 Jun, 2010 1 commit
-
-
Russ Cox authored
gob: substitute slice for map R=r CC=golang-dev https://golang.org/cl/1699045
-
- 20 Jun, 2010 1 commit
-
-
Russ Cox authored
update other code to match. R=r CC=golang-dev https://golang.org/cl/1680044
-
- 06 May, 2010 1 commit
-
-
Rob Pike authored
fix a bug in the handling of indirect maps. R=rsc CC=golang-dev https://golang.org/cl/1132042
-
- 05 May, 2010 1 commit
-
-
Rob Pike authored
Because maps are mostly a hidden type, they must be implemented using reflection values and will not be as efficient as arrays and slices. R=rsc CC=golang-dev https://golang.org/cl/1127041
-
- 30 Mar, 2010 1 commit
-
-
Russ Cox authored
note that sortmain.go has been run through hg gofmt; only the formatting of the day initializers changed. i'm happy to revert that formatting if you'd prefer. stop on error in doc/progs/run R=r CC=golang-dev https://golang.org/cl/850041
-
- 02 Mar, 2010 1 commit
-
-
Robert Griesemer authored
- gofmt -w src misc - looking for feedback R=rsc, r CC=golang-dev https://golang.org/cl/223076
-
- 29 Dec, 2009 2 commits
-
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/181089
-
Rob Pike authored
Fixes #470. R=rsc CC=golang-dev https://golang.org/cl/183074
-
- 15 Dec, 2009 1 commit
-
-
Robert Griesemer authored
parsing and printing to new syntax. Use -oldparser to parse the old syntax, use -oldprinter to print the old syntax. 2) Change default gofmt formatting settings to use tabs for indentation only and to use spaces for alignment. This will make the code alignment insensitive to an editor's tabwidth. Use -spaces=false to use tabs for alignment. 3) Manually changed src/exp/parser/parser_test.go so that it doesn't try to parse the parser's source files using the old syntax (they have new syntax now). 4) gofmt -w src misc test/bench 3rd set of files. R=rsc CC=golang-dev https://golang.org/cl/180048
-
- 07 Dec, 2009 1 commit
-
-
Russ Cox authored
to provide functionality previously hacked in to reflect and gob. R=r https://golang.org/cl/165076
-
- 04 Dec, 2009 1 commit
-
-
Rob Pike authored
so make it a local method (_String()). R=rsc CC=golang-dev https://golang.org/cl/165049
-
- 01 Dec, 2009 1 commit
-
-
Rob Pike authored
1) need to send slice and array types (was only sending element types) 2) compatibleType needs to use decoder's type map R=rsc CC=golang-dev https://golang.org/cl/164062
-
- 17 Nov, 2009 1 commit
-
-
Rob Pike authored
Fix is to move all decoder state into the decoder object. Fixes #215. R=rsc CC=golang-dev https://golang.org/cl/155077
-
- 10 Nov, 2009 1 commit
-
-
Robert Griesemer authored
rsc's algorithm - applied gofmt -w misc src - partial CL (remaining files in other CLs) R=rsc, r http://go/go-review/1026036
-
- 09 Nov, 2009 1 commit
-
-
Robert Griesemer authored
R=rsc, r http://go/go-review/1025029
-