Commits · 31452a36189e48ad178a85299e2b189701d8f358 · Kirill Smelkov / go

03 Nov, 2011 19 commits

runtime: fix set and not used · 31452a36
Russ Cox authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5305087
```
31452a36

gofix: make fix order implicit by date. · d26144be

David Symonds authored Nov 04, 2011

This partially undoes 8fd7e6d070c8, but preserves its semantics.
More importantly, it results in the data about each fix being
decentralised, which makes it easier for new fixes to be added,
and other gofix users to slot new fixes in.

It also adds some useful metadata that could be used in the future.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5306092

d26144be

os,text,unicode: renamings · 37d82c85

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #4.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into os, text, and unicode.

exec -> os/exec
scanner -> text/scanner
tabwriter -> text/tabwriter
template -> text/template
template/parse -> text/template/parse
utf16 -> unicode/utf16
utf8 -> unicode/utf8

This should be the last of the source-rearranging CLs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5331066

37d82c85

all: rename os.EOF to io.EOF in various non-code contexts · eb1717e0
Vincent Vanackere authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5334050
```
eb1717e0

net: renamings · de03d502

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #3.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into net.

http -> net/http
http/cgi -> net/http/cgi
http/fcgi -> net/http/fcgi
http/pprof -> net/http/pprof
http/httptest -> net/http/httptest
mail -> net/mail
rpc -> net/rpc
rpc/jsonrpc -> net/rpc/jsonrpc
smtp -> net/smtp
url -> net/url

Also remove rand (now math/rand) from NOTEST - it has a test.

The only edits are in Makefiles and deps.bash.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5335048

de03d502

html,log,math: renamings · 5cb4a153

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #2.
This one merely moves the source; the import strings will be
changed after the next weekly release.

exp/template/html -> html/template
big -> math/big
cmath -> math/cmplx
rand -> math/rand
syslog -> log/syslog

The only edits are in Makefiles and deps.bash.

Note that this CL moves exp/template/html out of exp. I decided
to do that so all the renamings can be done together, even though
the API (and that of template, for that matter) is still fluid.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5332053

5cb4a153

http: don't use ClientConn in Transport · 53493a22

Brad Fitzpatrick authored Nov 03, 2011

ClientConn's main feature (pipelining support)
wasn't being used anyway.  Ends up simpler to
just not use it.

This is prep for the http diet, moving ClientConn,
ServerConn, etc into http/httputil.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5305088

53493a22

container/heap: document what Push and Pop do · 41dc7d3a

Russ Cox authored Nov 03, 2011

Now that vector is gone, there is no precedent to refer to.
This is a confusing point for people looking to use the
package.

R=golang-dev, r, cw
CC=golang-dev
https://golang.org/cl/5322069

41dc7d3a

deps.bash: attempt to fix the windows build · d615a525
Rob Pike authored Nov 03, 2011
```
Use simpler shell constructs.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5297080
```
d615a525

encoding: move asn1, csv, gob, json, xml into encoding · f4cd8022

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #1.
This one merely moves the source; the import strings will be
changed after the next weekly release.

The only edits are in Makefiles.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5331060

f4cd8022

gc: Don't pollute the xmethod list with non-methods. · 11075ed8

Luuk van Dijk authored Nov 03, 2011

Fixes #2355.

I have a test, but not sure if it's worth adding.  Instead i've made
the patching-over in reflect.c methods more fatal and more descriptive.

R=rsc
CC=golang-dev
https://golang.org/cl/5302082

11075ed8

gc, ld: sync pathtoprefix + add comments · 80bce97e
Russ Cox authored Nov 03, 2011
```
R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5332051
```
80bce97e
gopack: do not look for Go metadata in non-Go objects · d6ff3c11
Russ Cox authored Nov 03, 2011
```
Fixes #2333.

R=r
CC=golang-dev
https://golang.org/cl/5316075
```
d6ff3c11
8a: fix IMULL grammar · 1738dc0e
Russ Cox authored Nov 03, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5298091
```
1738dc0e

html: parse <link> elements in <head> · 77aabbf2

Andrew Balholm authored Nov 03, 2011

Pass tests1.dat, test 83:
<title><meta></title><link><title><meta></title>

| <html>
|   <head>
|     <title>
|       "<meta>"
|     <link>
|     <title>
|       "<meta>"
|   <body>

Also pass test 84:
<style><!--</style><meta><script>--><link></script>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5331061

77aabbf2

builtin: remove errant spaces · 1c530d5d
Andrew Gerrand authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5337041
```
1c530d5d
http: update mime sniffing doc reference. · e4b46424
David Symonds authored Nov 03, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5303095
```
e4b46424

websocket: return an error HTTP response for bad websocket request. · de3d6472

Fumitoshi Ukai authored Nov 03, 2011

websocket spec had changed server-side requiements to return
an HTTP response with an appropriate error code (such as 400 Bad
Request) when it finds client did not send a handshake that matches
websocket protocol, rather than just closing connection.
It needs to flush out response before closing connection.
Fixes issues 2396.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5318072

de3d6472

test: clear execute bit from source file · bc440f1b
Mikio Hara authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330068
```
bc440f1b

02 Nov, 2011 21 commits

html: properly close <marquee> elements. · cf6a7121

Andrew Balholm authored Nov 03, 2011

Pass tests1.dat, test 80:
<a href=a>aa<marquee>aa<a href=b>bb</marquee>aa

| <html>
|   <head>
|   <body>
|     <a>
|       href="a"
|       "aa"
|       <marquee>
|         "aa"
|         <a>
|           href="b"
|           "bb"
|       "aa"

Also pass tests through test 82:
<!DOCTYPE html><spacer>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5319071

cf6a7121

gc: package paths in symbol names: don't escape periods before last slash, always escape >=0x7f. · 33f1d47b
Luuk van Dijk authored Nov 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5323071
```
33f1d47b
all: sort imports · 965845a8
Russ Cox authored Nov 02, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5319072
```
965845a8

gofmt, gofix: sort imports · 4a9ebb18

Russ Cox authored Nov 02, 2011

Add ast.SortImports(fset, file) to go/ast, for use by both programs.

Fixes #346.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330069

4a9ebb18

builtin: document the basic types · 7db617b4

Rob Pike authored Nov 02, 2011

The recursive definitions are illegal Go, but godoc doesn't mind.

R=bradfitz, r, n13m3y3r, rsc
CC=golang-dev
https://golang.org/cl/5322067

7db617b4

exp/sql: finish transactions, flesh out types, docs · 8089e578
Brad Fitzpatrick authored Nov 02, 2011
```
Fixes #2328 (float, bool)

R=rsc, r
CC=golang-dev
https://golang.org/cl/5294067
```
8089e578
math: improved accuracy for Tan · cefee3c9
Charles L. Dorian authored Nov 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5298087
```
cefee3c9
gc: helpful message instead of internal error on method call on pointer to pointer. · 7df9ff55
Luuk van Dijk authored Nov 02, 2011
```
Fixes #2343.

R=rsc
CC=golang-dev
https://golang.org/cl/5332048
```
7df9ff55
bufio: return nil line from ReadLine on error, as documented · bd43eac3
Brad Fitzpatrick authored Nov 02, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5316069
```
bd43eac3

gc: small fixes for printing. · 29a5ae65

Luuk van Dijk authored Nov 02, 2011

mark OADDR inserted by typecheck as implicit
OCOPY takes ->left and ->right, not ->list
OMAKE*'s can all have arguments
precedence for OIND was initalized twice

fixes #2414

R=rsc, dave
CC=golang-dev
https://golang.org/cl/5319065

29a5ae65

runtime: unify mutex code across OSes · ee24bfc0

Dmitriy Vyukov authored Nov 02, 2011

The change introduces 2 generic mutex implementations
(futex- and semaphore-based). Each OS chooses a suitable mutex
implementation and implements few callbacks (e.g. futex wait/wake).
The CL reduces code duplication, extends some optimizations available
only on Linux/Windows to other OSes and provides ground
for futher optimizations. Chan finalizers are finally eliminated.

(Linux/amd64, 8 HT cores)
benchmark                      old      new
BenchmarkChanContended         83.6     77.8 ns/op
BenchmarkChanContended-2       341      328 ns/op
BenchmarkChanContended-4       382      383 ns/op
BenchmarkChanContended-8       390      374 ns/op
BenchmarkChanContended-16      313      291 ns/op

(Darwin/amd64, 2 cores)
benchmark                      old      new
BenchmarkChanContended         159      172 ns/op
BenchmarkChanContended-2       6735     263 ns/op
BenchmarkChanContended-4       10384    255 ns/op
BenchmarkChanCreation          1174     407 ns/op
BenchmarkChanCreation-2        4007     254 ns/op
BenchmarkChanCreation-4        4029     246 ns/op

R=rsc, jsing, hectorchu
CC=golang-dev
https://golang.org/cl/5140043

ee24bfc0

json: fix typo in scanner_test.go. · 5e4e8f49
Nigel Tao authored Nov 02, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/5303092
```
5e4e8f49
net: implement LookupTXT for windows · b43cf81c
Alex Brainman authored Nov 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5318056
```
b43cf81c
builtin: document built-in error type · 4d3c9990
Andrew Gerrand authored Nov 02, 2011
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5307080
```
4d3c9990
gc: fix spelling of "GOEXPERIMENT" in a comment. · c4845c1c
David Symonds authored Nov 02, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5323070
```
c4845c1c

spec: delete spurious article · e223eedc

Rob Pike authored Nov 01, 2011

A profound change to christen the new tag.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5327062

e223eedc

undo CL 5330066 / 6a5647d82728 · 4c3ea000

Russ Cox authored Nov 01, 2011

I promised it wouldn't last very long.
People who really need this can sync to 6a5647d82728.

««« original CL description
gc: add GOEXPERIMENT=os.Error

This won't last long, I promise.

R=ken2
CC=golang-dev
https://golang.org/cl/5330066
»»»

R=ken2
CC=golang-dev
https://golang.org/cl/5333053

4c3ea000

gc: add GOEXPERIMENT=os.Error · 47f4bf76

Russ Cox authored Nov 01, 2011

This won't last long, I promise.

R=ken2
CC=golang-dev
https://golang.org/cl/5330066

47f4bf76

tag weekly.2011-11-02 · a2149f26
Andrew Gerrand authored Nov 02, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5311083
```
a2149f26

weekly.2011-11-02 · ede44c68

Andrew Gerrand authored Nov 02, 2011

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5308077

ede44c68

all: rename os.Error to error in various non-code contexts · 492098eb
Russ Cox authored Nov 01, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/5328062
```
492098eb