- 29 Aug, 2014 8 commits
-
-
Dmitriy Vyukov authored
Also fix a bunch of bugs: 1. Accesses to last_gc must be atomic (it's int64). 2. last_gc still can be 0 during first checks in sysmon, check for 0. 3. forcegc.g can be unitialized when sysmon accesses it: forcegc.g is initialized by main goroutine (forcegc.g = newproc1(...)), and main goroutine is unsynchronized with both sysmon and forcegc goroutine. Initialize forcegc.g in the forcegc goroutine itself instead. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/136770043
-
Keith Randall authored
LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/139890043
-
Keith Randall authored
LGTM=bradfitz, rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/135150043
-
Mikio Hara authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/126450043
-
Russ Cox authored
LGTM=iant R=golang-codereviews, iant CC=dvyukov, golang-codereviews, khr, r https://golang.org/cl/135930043
-
Ian Lance Taylor authored
Update #8612 LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://golang.org/cl/135170043
-
Matthew Dempsky authored
Clang 3.2 and older (as shipped with OS X Mountain Lion and older) outputs ambiguous DWARF debug info that makes it impossible for us to reconstruct accurate type information as required for this test. Fixes #8611. LGTM=rsc R=r, rsc, minux CC=golang-codereviews https://golang.org/cl/135990043
-
Matthew Dempsky authored
Shrinks the text segment size by about 1.5% for the "go", "gofmt", and "camlistored" commands on linux/amd64. Before: $ size go gofmt camlistored text data bss dec hex filename 6506842 136996 105784 6749622 66fdb6 go 2376046 85232 90984 2552262 26f1c6 gofmt 17051050 190256 130320 17371626 10911ea camlistored After: $ size go gofmt camlistored text data bss dec hex filename 6403034 136996 105784 6645814 656836 go 2331118 85232 90984 2507334 264246 gofmt 16842586 190256 130320 17163162 105e39a camlistored Fixes #8604. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/137790043
-
- 28 Aug, 2014 32 commits
-
-
Anthony Martin authored
LGTM=0intro, rsc R=rsc, 0intro CC=golang-codereviews https://golang.org/cl/132320043
-
Anthony Martin authored
This is a reapplication of CL 93520045 (changeset 5012df7fac58) since that was lost during the move to an internal package. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/134020043
-
ChaiShushan authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/129650043
-
ChaiShushan authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/137750043
-
ChaiShushan authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/132230043
-
ChaiShushan authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/134940043
-
Matthew Dempsky authored
In revision 05c3fee13eb3, openbsd/386's tfork implementation was accidentally changed in one instruction from using the "params" parameter to using the "psize" parameter. While here, OpenBSD's __tfork system call returns a pid_t which is an int32 on all OpenBSD architectures, so change runtime.tfork's return type from int64 to int32 and update the assembly implementations accordingly. LGTM=iant R=rsc, iant CC=golang-codereviews, jsing https://golang.org/cl/133190043
-
Keith Randall authored
LGTM=dvyukov R=golang-codereviews, dvyukov, khr CC=golang-codereviews https://golang.org/cl/124630043
-
Robert Griesemer authored
Package addition. PositionFor permits access to both, positions adjusted by //line comments (like the Position accessors), and unadjusted "raw" positions unaffected by //line comments. Raw positions are required for correct formatting of source code via go/printer which until now had to manually fix adjusted positions. Fixes #7702. LGTM=adonovan R=adonovan CC=golang-codereviews https://golang.org/cl/135110044
-
Brad Fitzpatrick authored
Only grab the lock once, don't allocate, add more tests. LGTM=ruiu R=ruiu, josharian CC=golang-codereviews https://golang.org/cl/139780043
-
Brad Fitzpatrick authored
Follow-up to https://golang.org/cl/107020044/ Also add a little comment. LGTM=ruiu, josharian R=josharian, ruiu CC=golang-codereviews https://golang.org/cl/139760043
-
David Crawshaw authored
LGTM=bradfitz R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/139770043
-
Robert Griesemer authored
Preparation for fixing issue 5769 (method selectors do not auto-dereference): The actual fix may require some cleanups in all these sections, and syntactically, method expressions and method values are selector expressions. Moving them next to each other so that it's easy to see the actual changes (next CL). No content changes besides the section moves. LGTM=iant, rsc R=r, rsc, iant, ken CC=golang-codereviews https://golang.org/cl/132300043
-
Russ Cox authored
This is getting a little annoying, but once the runtime structs are being defined in Go, these will go away. So it's only a temporary cost. TBR=bradfitz CC=golang-codereviews https://golang.org/cl/135940043
-
Alberto García Hierro authored
Significantly reduces the number of allocations, while also simplifying the code and increasing performance by a 1-2%. benchmark old ns/op new ns/op delta BenchmarkConcurrentDBExec 13290567 13026236 -1.99% BenchmarkConcurrentStmtQuery 13249399 13008879 -1.82% BenchmarkConcurrentStmtExec 8806237 8680182 -1.43% BenchmarkConcurrentTxQuery 13628379 12756293 -6.40% BenchmarkConcurrentTxExec 4794800 4722440 -1.51% BenchmarkConcurrentTxStmtQuery 5040804 5200721 +3.17% BenchmarkConcurrentTxStmtExec 1366574 1336626 -2.19% BenchmarkConcurrentRandom 11119120 10926113 -1.74% benchmark old allocs new allocs delta BenchmarkConcurrentDBExec 14191 13684 -3.57% BenchmarkConcurrentStmtQuery 16020 15514 -3.16% BenchmarkConcurrentStmtExec 4179 3672 -12.13% BenchmarkConcurrentTxQuery 16025 15518 -3.16% BenchmarkConcurrentTxExec 12717 12709 -0.06% BenchmarkConcurrentTxStmtQuery 15532 15525 -0.05% BenchmarkConcurrentTxStmtExec 2175 2168 -0.32% BenchmarkConcurrentRandom 12320 11997 -2.62% benchmark old bytes new bytes delta BenchmarkConcurrentDBExec 2164827 2139760 -1.16% BenchmarkConcurrentStmtQuery 2418070 2394030 -0.99% BenchmarkConcurrentStmtExec 1728782 1704371 -1.41% BenchmarkConcurrentTxQuery 2477144 2452620 -0.99% BenchmarkConcurrentTxExec 588920 588343 -0.10% BenchmarkConcurrentTxStmtQuery 790866 796578 +0.72% BenchmarkConcurrentTxStmtExec 98502 98143 -0.36% BenchmarkConcurrentRandom 1725906 1710220 -0.91% LGTM=ruiu, dave, bradfitz R=golang-codereviews, ruiu, gobot, bradfitz, dave, minux CC=bradfitz, golang-codereviews https://golang.org/cl/107020044
-
David Crawshaw authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/134030043
-
Russ Cox authored
'range hash' makes a copy of the hash array in the stack, creating a very large stack frame. It's just the right amount that it uses most but not all of the total stack size. If you have a lot of environment variables, like the builders, then this is too much and the g0 stack runs out of space. TBR=bradfitz CC=golang-codereviews https://golang.org/cl/132350043
-
Jeff R. Allen authored
Fixes #8350. LGTM=bradfitz R=golang-codereviews, bradfitz, dave CC=golang-codereviews https://golang.org/cl/127380043
-
Russ Cox authored
LGTM=dvyukov R=golang-codereviews, bradfitz, dvyukov CC=golang-codereviews, iant, khr https://golang.org/cl/135070043
-
Russ Cox authored
LGTM=bradfitz, dvyukov R=golang-codereviews, bradfitz, dvyukov CC=golang-codereviews, iant, khr https://golang.org/cl/131510043
-
Jeff R. Allen authored
In order to support different compression levels, make the encoder type public, and add an Encoder method to it. Fixes #8499. LGTM=nigeltao R=nigeltao, ruiu CC=golang-codereviews https://golang.org/cl/129190043
-
Russ Cox authored
I changed all the NACL_SYSJMP to NACL_SYSCALL in an earlier CL, but I missed the fact that NACL_SYSCALL will push another return PC on the stack, so that the arguments will no longer be in the right place. Since we have to make our own call, we also have to copy the arguments. Do that. Fixes nacl/386 build. TBR=minux CC=golang-codereviews https://golang.org/cl/135050044
-
Russ Cox authored
This will allow structs containing Efaces in C to be manipulated as structs containing real interfaces in Go. The eface struct is still defined for use by Go code. LGTM=iant R=golang-codereviews, iant CC=dvyukov, golang-codereviews, khr, r https://golang.org/cl/133980044
-
Russ Cox authored
TBR=iant CC=golang-codereviews https://golang.org/cl/133150043
-
Russ Cox authored
Mutex is consistent with package sync, and when in the unexported Go form it avoids having a conflcit between the type (now mutex) and the function (lock). LGTM=iant R=golang-codereviews, iant CC=dvyukov, golang-codereviews, r https://golang.org/cl/133140043
-
Michael Hudson-Doyle authored
This adds the minimal support for AArch64/arm64 relocations needed to get cgo to work (when an isomorphic patch is applied to gccgo) and a test. This change uses the "AAarch64" name for the architecture rather than the more widely accepted "arm64" because that's the name that the relevant docs from ARM such as http://infocenter.arm.com/help/topic/com.arm.doc.ihi0056b/IHI0056B_aaelf64.pdf all use. Fixes #8533. LGTM=iant R=golang-codereviews, aram, gobot, iant, minux CC=golang-codereviews https://golang.org/cl/132000043
-
Russ Cox authored
NaCl requires the addition of a 32-byte "halt sled" at the end of the text segment. This means that segtext.len is actually 32 bytes shorter than reality. The computation of the file offset of the end of the data segment did not take this 32 bytes into account, so if len and len+32 rounded up (by 64k) to different values, the symbol table overwrote the last page of the data segment. The last page of the data segment is usually the C .string symbols, which contain the strings used in error prints by the runtime. So when this happens, your program probably crashes, and then when it does, you get binary garbage instead of all the usual prints. The chance of hitting this with a randomly sized text segment is 32 in 65536, or 1 in 2048. If you add or remove ANY code while trying to debug this problem, you're overwhelmingly likely to bump the text segment one way or the other and make the bug disappear. Correct all the computations to use segdata.fileoff+segdata.filelen instead of trying to rederive segdata.fileoff. This fixes the failure during the nacl/amd64p32 build. TBR=iant CC=golang-codereviews https://golang.org/cl/135050043
-
Russ Cox authored
The NaCl "system calls" were assumed to have a compatible return convention with the C compiler, and we were using tail jumps to those functions. Don't do that anymore. Correct mistake introduced in newstackcall duringconversion from (SP) to (FP) notation. (Actually this fix, in asm_amd64p32.s, slipped into the C compiler change, but update the name to match what go vet wants.) Correct computation of caller stack pointer in morestack: on amd64p32, the saved PC is the size of a uintreg, not uintptr. This may not matter, since it's been like this for a while, but uintreg is the correct one. (And on non-NaCl they are the same.) This will allow the NaCl build to get much farther. It will probably still not work completely. There's a bug in 6l that needs fixing too. TBR=minux CC=golang-codereviews https://golang.org/cl/134990043
-
Dave Cheney authored
runtime._sfloat2 now returns the lr value on the stack, not R0. Credit to Russ Cox for the fix. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/133120045
-
Russ Cox authored
TBR=minux CC=golang-codereviews https://golang.org/cl/137810043
-
Russ Cox authored
uintptr or uint64 in the runtime C were turning into uint in the Go, bool was turning into uint8, and so on. Fix that. Also delete Go wrappers for C functions. The C functions can be called directly now (but still eventually need to be converted to Go). LGTM=bradfitz, minux, iant R=golang-codereviews, bradfitz, iant, minux CC=golang-codereviews, khr, r https://golang.org/cl/138740043
-
Matthew Dempsky authored
Broken by 8b5fc7c59d05. Update #8092 LGTM=iant, alex.brainman R=rsc, iant, alex.brainman CC=golang-codereviews https://golang.org/cl/138770043
-