1. 10 Nov, 2016 11 commits
    • Francesc Campoy's avatar
      cmd/vet: detect defer resp.Body.Close() before error check · 47bdae94
      Francesc Campoy authored
      This check detects the code
      
      	resp, err := http.Get("http://foo.com")
      	defer resp.Body.Close()
      	if err != nil {
      		...
      	}
      
      For every call to a function on the net/http package or any method
      on http.Client that returns (*http.Response, error), it checks
      whether the next line is a defer statement that calls on the response.
      
      Fixes #17780.
      
      Change-Id: I9d70edcbfa2bad205bf7f45281597d074c795977
      Reviewed-on: https://go-review.googlesource.com/32911Reviewed-by: default avatarRob Pike <r@golang.org>
      47bdae94
    • Brad Fitzpatrick's avatar
      A+C: update for Go 1.8 · 91135f27
      Brad Fitzpatrick authored
      Add Albert Nigmatzianov (individual CLA)
      Add Alex Browne (individual CLA)
      Add Alex Carol (individual CLA)
      Add Alexander Döring (individual CLA)
      Add Allan Simon (individual CLA)
      Add Alok Menghrajani (individual CLA)
      Add Andreas Auernhammer (individual CLA)
      Add Andreas Litt (individual CLA)
      Add Andrew Pogrebnoy (individual CLA)
      Add Antonio Murdaca (corporate CLA for Red Hat, Inc.)
      Add Atin Malaviya (individual CLA)
      Add Billy Lynch (corporate CLA for Google Inc.)
      Add Blixt (individual CLA)
      Add Boris Nagaev (corporate CLA for Google Inc.)
      Add Braden Bassingthwaite (corporate CLA for Vendasta)
      Add Brian Kennedy (individual CLA)
      Add Bryan Alexander (individual CLA)
      Add Carl Johnson (individual CLA)
      Add Cixtor (individual CLA)
      Add Cyrill Schumacher (individual CLA)
      Add Daniel Martí (individual CLA)
      Add Daria Kolistratova (corporate CLA for Intel Corporation)
      Add David Hubbard (corporate CLA for Google Inc.)
      Add David Stainton (individual CLA)
      Add Deepak Jois (individual CLA)
      Add Denis Nagorny (corporate CLA for Intel Corporation)
      Add Dhaivat Pandit (individual CLA)
      Add Dhananjay Nakrani (corporate CLA for Google Inc.)
      Add Dmitri Popov (individual CLA)
      Add Erik Staab (corporate CLA for Google Inc.)
      Add Ethan Miller (corporate CLA for IBM)
      Add Faiyaz Ahmed (individual CLA)
      Add Fedor Indutny (individual CLA)
      Add Gabriel Russell (individual CLA)
      Add Gareth Paul Jones (individual CLA)
      Add Geoffroy Lorieux (individual CLA)
      Add Gleb Stepanov (individual CLA)
      Add Henrik Hodne (individual CLA)
      Add Ivan Babrou (individual CLA)
      Add Jack Lindamood (corporate CLA for Amazon.com, Inc)
      Add James Clarke (individual CLA)
      Add Jamie Beverly (individual CLA)
      Add Jason Smale (individual CLA)
      Add Jean-Nicolas Moal (individual CLA)
      Add Jeroen Bobbeldijk (individual CLA)
      Add Jim Kingdon (corporate CLA for Bolt)
      Add Jirka Daněk (individual CLA)
      Add Jon Chen (corporate CLA for Amazon.com, Inc)
      Add Joonas Kuorilehto (individual CLA)
      Add Josh Chorlton (individual CLA)
      Add Joshua Boelter (corporate CLA for Intel Corporation)
      Add Justyn Temme (individual CLA)
      Add Kale Blankenship (individual CLA)
      Add LE Manh Cuong (individual CLA)
      Add Luigi Riefolo (individual CLA)
      Add Manfred Touron (individual CLA)
      Add Martin Bertschler (individual CLA)
      Add Martin Hamrle (individual CLA)
      Add Matthew Denton (individual CLA)
      Add Matthieu Hauglustaine (individual CLA)
      Add Michael Darakananda (corporate CLA for Google Inc.)
      Add Mike Appleby (individual CLA)
      Add Mike Houston (individual CLA)
      Add Mike Strosaker (corporate CLA for IBM)
      Add Miroslav Genov (individual CLA)
      Add Momchil Velikov (individual CLA)
      Add Nick Harper (corporate CLA for Google Inc.)
      Add Oleg Vakheta (individual CLA)
      Add Parker Moore (individual CLA)
      Add Prasanna Swaminathan (corporate CLA for MediaMath, Inc)
      Add Radu Berinde (individual CLA)
      Add Ramesh Dharan (corporate CLA for Google Inc.)
      Add Richard Gibson (individual CLA)
      Add Samuel Tan (corporate CLA for Google Inc.)
      Add Samuele Pedroni (individual CLA)
      Add Sarah Adams (corporate CLA for Google Inc.)
      Add Sean Rees (individual CLA)
      Add Simon Rawet (individual CLA)
      Add Sina Siadat (individual CLA)
      Add Song Gao (individual CLA)
      Add Suyash (individual CLA)
      Add Sven Blumenstein (corporate CLA for Google Inc.)
      Add Syohei YOSHIDA (individual CLA)
      Add Terrel Shumway (individual CLA)
      Add Than McIntosh (corporate CLA for Google Inc.)
      Add Thomas de Zeeuw (individual CLA)
      Add Tim Henderson (individual CLA)
      Add Tom Wilkie (corporate CLA for Weaveworks)
      Add Trey Lawrence (individual CLA)
      Add Tristan Ooohry (individual CLA)
      Add Tuo Shan (corporate CLA for Google Inc.)
      Add Victor Chudnovsky (corporate CLA for Google Inc.)
      Add Vitor De Mario (individual CLA)
      Add Vladimir Mihailenco (individual CLA)
      Add Vladimir Stefanovic (individual CLA)
      Add Walter Poupore (corporate CLA for Google Inc.)
      Add Xuyang Kang (individual CLA)
      Add Zev Goldstein (individual CLA)
      
      Updates #12042
      
      Change-Id: I28d63babe225683b88f3f1501e529aed636c9ead
      Reviewed-on: https://go-review.googlesource.com/33028Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      91135f27
    • Brad Fitzpatrick's avatar
      lib/time: update tzdata to 2016i · d54463f4
      Brad Fitzpatrick authored
      Fixes #17678
      
      Change-Id: I01d12a827e6106efed1ec024f736c640b86906b4
      Reviewed-on: https://go-review.googlesource.com/33029
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      d54463f4
    • Ian Lance Taylor's avatar
      cmd/go: -ldflags=-linkmode=external requires runtime/cgo · b77bff97
      Ian Lance Taylor authored
      We add runtime/cgo to the list of import paths for various cases that
      imply external linking mode, but before this change we did not add for
      an explicit request of external linking mode. This fixes the case where
      you are using a non-default buildmode that implies a different
      compilation option (for example, -buildmode=pie implies -shared) and the
      runtime/cgo package for that option is stale.
      
      No test, as I'm not sure how to write one. It would require forcing a
      stale runtime/cgo.
      
      Change-Id: Id0409c7274ce67fe15d910baf587d3220cb53d83
      Reviewed-on: https://go-review.googlesource.com/33070Reviewed-by: default avatarMichael Hudson-Doyle <michael.hudson@canonical.com>
      b77bff97
    • Robert Griesemer's avatar
      go/printer: don't drop required semi/linebreak after /*-comment · a0d2e969
      Robert Griesemer authored
      For details, see the issues.
      
      Fixes #11274.
      Fixes #15137.
      
      Change-Id: Ia11e71a054b3195e3007f490418a9c53a7e9cdf1
      Reviewed-on: https://go-review.googlesource.com/33016Reviewed-by: default avatarAlan Donovan <adonovan@google.com>
      a0d2e969
    • Brad Fitzpatrick's avatar
      net/http: fix Server.Close double Lock · 8cd55615
      Brad Fitzpatrick authored
      Fixes #17878
      
      Change-Id: I062ac514239068c58175c9ee7964b3590f956a82
      Reviewed-on: https://go-review.googlesource.com/33026
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      8cd55615
    • David Crawshaw's avatar
      reflect: unexported fields are tied to a package · 8d0c1054
      David Crawshaw authored
      An unexported field of a struct is not visible outside of the package
      that defines it, so the package path is implicitly part of the
      definition of any struct with an unexported field.
      
      Change-Id: I17c6aac822bd0c24188ab8ba1cc406d6b5d82771
      Reviewed-on: https://go-review.googlesource.com/32820
      Run-TryBot: David Crawshaw <crawshaw@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      8d0c1054
    • Kevin Burke's avatar
      sync: add example for Pool · 9e2c3f4c
      Kevin Burke authored
      It was a little tricky to figure out how to go from the documentation
      to figuring out the best way to implement a Pool, so I thought I'd
      try to provide a simple example. The implementation is mostly taken
      from the fmt package.
      
      I'm not happy with the verbosity of the calls to WriteString() etc,
      but I wanted to provide a non-trivial example.
      
      Change-Id: Id33a8b6cbf8eb278f71e1f78e20205b436578606
      Reviewed-on: https://go-review.googlesource.com/24371Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      9e2c3f4c
    • Robert Griesemer's avatar
      cmd/gofmt: don't leave tmp file if -w failed · 73497c76
      Robert Griesemer authored
      Follow-up on https://golang.org/cl/33018.
      
      For #8984.
      
      Change-Id: I6655a5537a60d4ea3ee13029a56a75b150f8c8f8
      Reviewed-on: https://go-review.googlesource.com/33020Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      73497c76
    • Robert Griesemer's avatar
      cmd/gofmt: don't eat source if -w fails · b188b4cc
      Robert Griesemer authored
      Write output to a temp file first and only upon success
      rename that file to source file name.
      
      Fixes #8984.
      
      Change-Id: Ie40e49d2a4eb3c9462fe769ccbf055b4366eceb0
      Reviewed-on: https://go-review.googlesource.com/33018Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      b188b4cc
    • Robert Griesemer's avatar
      go/types: remove unused alias-related testdata files · add8028e
      Robert Griesemer authored
      They interfere with gofmt -w across this directory.
      
      Follow-up on https://go-review.googlesource.com/32819.
      
      For #16339 (comment).
      
      Change-Id: I4298b6117d89517d4fe6addce3942d950d821817
      Reviewed-on: https://go-review.googlesource.com/33019Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
      add8028e
  2. 09 Nov, 2016 8 commits
  3. 08 Nov, 2016 17 commits
  4. 07 Nov, 2016 4 commits