1. 23 Jun, 2017 3 commits
  2. 22 Jun, 2017 13 commits
  3. 21 Jun, 2017 6 commits
  4. 20 Jun, 2017 9 commits
    • John R. Lenton's avatar
      runtime, syscall: workaround for bug in Linux's execve · 91139b87
      John R. Lenton authored
      Linux's execve has (at the time of writing, and since v2.6.30) a bug when it ran
      concurrently with clone, in that it would fail to set up some datastructures if
      the thread count before and after some steps differed. This is described better
      and in more detail by Colin King in Launchpad¹ and kernel² bugs. When a program
      written in Go runtime.Exec's a setuid binary, this issue may cause the resulting
      process to not have the expected uid. This patch works around the issue by using
      a mutex to serialize exec and clone.
      
      1. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1672819
      2. https://bugzilla.kernel.org/show_bug.cgi?id=195453
      
      Fixes #19546
      
      Change-Id: I126e87d1d9ce3be5ea4ec9c7ffe13f92e087903d
      Reviewed-on: https://go-review.googlesource.com/43713Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      91139b87
    • Brad Fitzpatrick's avatar
      crypto/x509: update MaxPathLen & MaxPathLenZero docs · 3ca8ee14
      Brad Fitzpatrick authored
      Fixes #19285
      
      Change-Id: I11e864eff9980dec8247c47e4c600f76602e7ada
      Reviewed-on: https://go-review.googlesource.com/46092Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      3ca8ee14
    • Brad Fitzpatrick's avatar
      A+C: updated update · 855d823d
      Brad Fitzpatrick authored
      I updated my tool to deal with Github-only contributors without Gerrit
      accounts. The "dep" repo is the main source of these, although there
      are a few others.
      
      Add Alexander Kauer (individual CLA)
      Add Anders Pearson (individual CLA)
      Add Brad Whitaker (corporate CLA for Fastly, Inc.)
      Add Daisuke Fujita (individual CLA)
      Add Daniel Upton (individual CLA)
      Add David Volquartz Lebech (individual CLA)
      Add Emilien Kenler (individual CLA)
      Add Fazal Majid (corporate CLA for Apsalar)
      Add Gustav Westling (individual CLA)
      Add Henry Chang (individual CLA)
      Add Jianqiao Li (corporate CLA for Google Inc.)
      Add Jin-wook Jeong (individual CLA)
      Add Kaleb Elwert (individual CLA)
      Add Kashav Madan (individual CLA)
      Add Koki Ide (individual CLA)
      Add Konstantin (individual CLA)
      Add Kyle Jones (individual CLA)
      Add Leon Klingele (individual CLA)
      Add Martin Olsen (individual CLA)
      Add Máximo Cuadros Ortiz (individual CLA)
      Add Miguel Molina (individual CLA)
      Add Nathaniel Cook (individual CLA)
      Add Neil Lyons (individual CLA)
      Add Nick Robinson (individual CLA)
      Add Niranjan Godbole (individual CLA)
      Add Oleg Bulatov (individual CLA)
      Add Oliver Tonnhofer (individual CLA)
      Add Paul Querna (individual CLA)
      Add Peter Bourgon (individual CLA)
      Add Quentin Renard (individual CLA)
      Add Ray Tung (individual CLA)
      Add Rob Phoenix (individual CLA)
      Add Ryan Boehning (individual CLA)
      Add Sakeven Jiang (individual CLA)
      Add Stephen Searles (individual CLA)
      Add Steven Wilkin (individual CLA)
      Add Sunny (individual CLA)
      Add Ted Kornish (individual CLA)
      Add Victor Vrantchan (individual CLA)
      Add Wander Lairson Costa (individual CLA)
      Add Zakatell Kanda (individual CLA)
      
      Updates #12042
      
      Change-Id: I2e4828cce880965c77b374c1e115d0e437d108c7
      Reviewed-on: https://go-review.googlesource.com/46090Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      855d823d
    • Austin Clements's avatar
      syscall: mark forkAndExecInChild1 noinline · 87adaf4c
      Austin Clements authored
      This certainly won't get inlined right now, but in the spirit of
      making this more robust, we have to disable inlining because inlining
      would defeat the purpose of separating forkAndExecInChild1 into a
      separate function.
      
      Updates #20732.
      
      Change-Id: I736c3f909cc42c5f5783740c2e19ba4827c7c2ec
      Reviewed-on: https://go-review.googlesource.com/46174
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      87adaf4c
    • Austin Clements's avatar
      syscall: use CLONE_VFORK safely · 67e53754
      Austin Clements authored
      Currently, CLONE_VFORK is used without much regard to the stack. This
      is dangerous, because anything the child does to the stack is visible
      to the parent. For example, if the compiler were to reuse named stack
      slots (which it currently doesn't do), it would be easy for the child
      running in the same stack frame as the parent to corrupt local
      variables that the parent then depended on. We're not sure of anything
      specific going wrong in this code right now, but it is at best a
      ticking time bomb.
      
      CLONE_VFORK can only safely be used if we ensure the child does not
      execute in any of the active stack frames of the parent. This commit
      implements this by arranging for the parent to return immediately from
      the frame the child will operate in, and for the child to never return
      to the frame the parent will operate in.
      
      Fixes #20732.
      
      Change-Id: Iad5b4ddc2b994c082bd278bfd52ef53bd38c037f
      Reviewed-on: https://go-review.googlesource.com/46173
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      67e53754
    • Alberto Donizetti's avatar
      Revert "cmd/vendor/github.com/google/pprof: refresh from upstream" · 5a5ac341
      Alberto Donizetti authored
      This reverts commit 3d13b5e0.
      
      Reason for revert: the new TestHttpsInsecure test breaks two darwin builders, the android builders, and one plan9 builder.
      
      Change-Id: I09158e7d1bd2b3ffda57e7f2350f34eb9b62e784
      Reviewed-on: https://go-review.googlesource.com/46158Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      5a5ac341
    • Alberto Donizetti's avatar
      cmd/vendor/github.com/google/pprof: refresh from upstream · 3d13b5e0
      Alberto Donizetti authored
      Updating to commit fffc5831a499a958516664a34cb7ba2b9e228793
      from github.com/google/pprof
      
      Fixes #19380
      
      Change-Id: I7a0c64101f42b494c4a469c41628374272eccf95
      Reviewed-on: https://go-review.googlesource.com/46155
      Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      3d13b5e0
    • sam boyer's avatar
      doc: add qualified mention of dep to FAQ · dc8b4e65
      sam boyer authored
      This adds a qualified mention of golang/dep to the FAQ.
      
      Fixes #19049
      
      Change-Id: I42a114a008a6ca1250d849872dd98fd6523fa659
      Reviewed-on: https://go-review.googlesource.com/46005Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      dc8b4e65
    • Russ Cox's avatar
      testing: harmonize handling of prefix-matched benchmarks · a2a3ace5
      Russ Cox authored
      If you have BenchmarkX1 with sub-benchmark Y
      and you have BenchmarkX2 with no sub-benchmarks,
      then
      
      	go test -bench=X/Y
      
      runs BenchmarkX1 once with b.N=1 (to find out about Y)
      and then not again, because it has sub-benchmarks,
      but arguably also because we're interested in Y.
      
      In contrast, it runs BenchmarkX2 in full, even though clearly
      that is not relevant to the match X/Y. We do have to run X2
      once with b.N=1 to probe for having X2/Y, but we should not
      run it with larger b.N.
      
      Fixes #20589.
      
      Change-Id: Ib86907e844f34dcaac6cd05757f57db1019201d0
      Reviewed-on: https://go-review.googlesource.com/46031
      Run-TryBot: Russ Cox <rsc@golang.org>
      Reviewed-by: default avatarMarcel van Lohuizen <mpvl@golang.org>
      a2a3ace5
  5. 19 Jun, 2017 4 commits
  6. 18 Jun, 2017 1 commit
  7. 17 Jun, 2017 2 commits
  8. 16 Jun, 2017 2 commits