- 04 Nov, 2016 11 commits
-
-
Vladimir Stefanovic authored
Change-Id: Ie7b40cc67e9901e252a4a48225bbd745a66d2673 Reviewed-on: https://go-review.googlesource.com/31511Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
I used the slowtests.go tool as described in https://golang.org/cl/32684 on packages that stood out. go test -short std drops from ~56 to ~52 seconds. This isn't a huge win, but it was mostly an exercise. Updates #17751 Change-Id: I9f3402e36a038d71e662d06ce2c1d52f6c4b674d Reviewed-on: https://go-review.googlesource.com/32751 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
External linking on mips/mipsle is not supported yet (issue #17792). Change-Id: Ic25f4f8fe9e0ec35c72ca9f85c053b398df4952c Reviewed-on: https://go-review.googlesource.com/31512Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Change-Id: I5fecdf52e9e3035ea8feb5768985ed5200dbd6af Reviewed-on: https://go-review.googlesource.com/32752 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Martin Möhrmann <martisch@uos.de>
-
Emmanuel Odeke authored
Follow up of CL https://go-review.googlesource.com/32595. Change-Id: I2b3ff7e6b2c764bb6bc5e9aa692d0aed79eb5626 Reviewed-on: https://go-review.googlesource.com/32750Reviewed-by:
-
Brad Fitzpatrick authored
Before: 8.9 seconds for go test -short After: 2.8 seconds There are still 250 tests without t.Parallel, but I got the important onces using a script: $ go test -short -v 2>&1 | go run ~/slowtests.go Where slowtests.go is https://play.golang.org/p/9mh5Wg1nLN The remaining 250 (the output lines from slowtests.go) all have a reported duration of 0ms, except one 50ms test which has to be serial. Where tests can't be parallel, I left a comment at the top saying why, so people don't add t.Parallel later and get surprised at failures. Updates #17751 Change-Id: Icbe32cbe2b996e23c89f1af6339287fa22af5115 Reviewed-on: https://go-review.googlesource.com/32684 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Josh Bleecher Snyder <josharian@gmail.com>
-
Josh Bleecher Snyder authored
Change-Id: I6bb594576e174cb0df8d25d11b84f5a4752ebfd6 Reviewed-on: https://go-review.googlesource.com/32683Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: Ia03f993287d2929f35b4c92d00fe25c7243bd8b3 Reviewed-on: https://go-review.googlesource.com/32685Reviewed-by:
-
Brad Fitzpatrick authored
This CL tweaks the new (unreleased) 307/308 support added in https://golang.org/cl/29852 for #10767. Change 1: if a 307/308 response doesn't have a Location header in its response (as observed in the wild in #17773), just do what we used to do in Go 1.7 and earlier, and don't try to follow that redirect. Change 2: don't follow a 307/308 if we sent a body on the first request and the caller's Request.GetBody func is nil so we can't "rewind" the body to send it again. Updates #17773 (will be fixed more elsewhere) Change-Id: I183570f7346917828a4b6f7f1773094122a30406 Reviewed-on: https://go-review.googlesource.com/32595Reviewed-by:
-
Josh Bleecher Snyder authored
Rebuild cmd/objdump once instead of twice. Speeds up standalone 'go test cmd/objdump' on my machine from ~1.4s to ~1s. Updates #17751 Change-Id: I15fd79cf18c310f892bc28a9e9ca47ee010c989a Reviewed-on: https://go-review.googlesource.com/32673 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Use a separate symbol for reflect metadata for types with Noalg set. Fixes #17752. Change-Id: Icb6cade7e3004fc4108f67df61105dc4085cd7e2 Reviewed-on: https://go-review.googlesource.com/32679Reviewed-by:
David Crawshaw <crawshaw@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 03 Nov, 2016 29 commits
-
-
Vladimir Stefanovic authored
Change-Id: I6288f1fca1ae4c64b3907af700811ee842053020 Reviewed-on: https://go-review.googlesource.com/31472Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I8c6b8839c68818430510702719dca15b8d748fb8 Reviewed-on: https://go-review.googlesource.com/31473Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I76c62a7b79ea526f59f281e933e4fd431539d2da Reviewed-on: https://go-review.googlesource.com/31486Reviewed-by:
-
Vladimir Stefanovic authored
mheap_.heap_live is an atomically accessed uint64. It is currently not 8-byte aligned on 32-bit platforms, which has been okay because it's only accessed via Xadd64, which doesn't require alignment on 386 or ARM32. However, Xadd64 on MIPS32 does require 8-byte alignment. Add a padding field to force 8-byte alignment of heap_live and prevent an alignment check crash on MIPS32. Change-Id: I7eddf7883aec7a0a7e0525af5d58ed4338a401d0 Reviewed-on: https://go-review.googlesource.com/31635 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I39a46b2a9412981db1780b688a86fec791f68b6f Reviewed-on: https://go-review.googlesource.com/31488 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I7a51d5d96a7cb87c40ade5be276136c465010bb9 Reviewed-on: https://go-review.googlesource.com/32596Reviewed-by:
Vladimir Stefanovic <vladimir.stefanovic@imgtec.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I8b0c4bfe1e4c401d5c36a51b937671e6362c73a4 Reviewed-on: https://go-review.googlesource.com/31485Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I47c6867fc653c8388ad32e210a8027baa592eda3 Reviewed-on: https://go-review.googlesource.com/31483 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I54e100cced5b49674937fb87d1e0f585f962aeb7 Reviewed-on: https://go-review.googlesource.com/31484Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I10f36710dd95b9bd31b3b82a3c32edcadb90ffa9 Reviewed-on: https://go-review.googlesource.com/31510 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: I99a48f719fd1a8178fc59787084a074e91c89ac6 Reviewed-on: https://go-review.googlesource.com/31489 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Vladimir Stefanovic authored
Change-Id: Ia6f8ae7e56a49ad66b60a24c4afb606f3cfe5efd Reviewed-on: https://go-review.googlesource.com/31482 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
From the doc comment: Context returns the context for the current test or benchmark. The context is cancelled when the test or benchmark finishes. A goroutine started during a test or benchmark can wait for the context's Done channel to become readable as a signal that the test or benchmark is over, so that the goroutine can exit. Fixes #16221. Fixes #17552. Change-Id: I657df946be2c90048cc74615436c77c7d9d1226c Reviewed-on: https://go-review.googlesource.com/31724Reviewed-by:
Rob Pike <r@golang.org>
-
Russ Cox authored
So that testing can use context in its public API. For #16221. Change-Id: I6263fa7266c336c9490f20164ce79336df44a57e Reviewed-on: https://go-review.googlesource.com/32648 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Emmanuel Odeke authored
Updates #16360. Change-Id: I5bf13d3367e68c5d8435f6ef2161d5a74cc747a7 Reviewed-on: https://go-review.googlesource.com/29611Reviewed-by:
Andrew Gerrand <adg@golang.org> Run-TryBot: Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
Before: $ go test -race -v -run TestRace === RUN TestRace ================== WARNING: DATA RACE Write at 0x00c420076420 by goroutine 7: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace.func1() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:10 +0x3b Previous write at 0x00c420076420 by goroutine 6: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:13 +0xcc testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 Goroutine 7 (running) created at: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:12 +0xbb testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 Goroutine 6 (running) created at: testing.(*T).Run() /Users/rsc/go/src/testing/testing.go:693 +0x536 testing.runTests.func1() /Users/rsc/go/src/testing/testing.go:877 +0xaa testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 testing.runTests() /Users/rsc/go/src/testing/testing.go:883 +0x4ac testing.(*M).Run() /Users/rsc/go/src/testing/testing.go:818 +0x1c3 main.main() _/Users/rsc/go/src/cmd/go/testdata/src/testrace/_test/_testmain.go:42 +0x20f ================== --- PASS: TestRace (0.00s) PASS Found 1 data race(s) FAIL _/Users/rsc/go/src/cmd/go/testdata/src/testrace 1.026s $ After: $ go test -race -v -run TestRace === RUN TestRace ================== WARNING: DATA RACE Write at 0x00c420076420 by goroutine 7: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace.func1() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:10 +0x3b Previous write at 0x00c420076420 by goroutine 6: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:13 +0xcc testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 Goroutine 7 (running) created at: _/Users/rsc/go/src/cmd/go/testdata/src/testrace.TestRace() /Users/rsc/go/src/cmd/go/testdata/src/testrace/race_test.go:12 +0xbb testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 Goroutine 6 (running) created at: testing.(*T).Run() /Users/rsc/go/src/testing/testing.go:693 +0x536 testing.runTests.func1() /Users/rsc/go/src/testing/testing.go:877 +0xaa testing.tRunner() /Users/rsc/go/src/testing/testing.go:656 +0x104 testing.runTests() /Users/rsc/go/src/testing/testing.go:883 +0x4ac testing.(*M).Run() /Users/rsc/go/src/testing/testing.go:818 +0x1c3 main.main() _/Users/rsc/go/src/cmd/go/testdata/src/testrace/_test/_testmain.go:42 +0x20f ================== --- FAIL: TestRace (0.00s) testing.go:609: race detected during execution of test FAIL FAIL _/Users/rsc/go/src/cmd/go/testdata/src/testrace 0.022s $ Fixes #15972. Change-Id: Idb15b8ab81d65637bb535c7e275595ca4a6e450e Reviewed-on: https://go-review.googlesource.com/32615 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Dan Harrington authored
- Added support for If-Match and If-Unmodified-Since. - Precondition checks now more strictly follow RFC 7232 section 6, which affects precedence when multiple condition headers are present. - When serving a 304, Last-Modified header is now removed when no ETag is present (as suggested by RFC 7232 section 4.1). - If-None-Match supports multiple ETags. - ETag comparison now correctly handles weak ETags. Fixes #17572 Change-Id: I35039dea6811480ccf2889f8ed9c6a39ce34bfff Reviewed-on: https://go-review.googlesource.com/32014Reviewed-by:
-
Robert Griesemer authored
See https://go-review.googlesource.com/32581. This makes x/tools/go/gcimporter15/bimport.go a close copy again and the importer more robust. Change-Id: If96ad6acd611878b7dfa6a13d005d847ece82ab6 Reviewed-on: https://go-review.googlesource.com/32647 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Mohit Agarwal authored
Fixes #17772 Change-Id: I0f2094400c454828aa57a8d172dadeac4ddb6d35 Reviewed-on: https://go-review.googlesource.com/32691Reviewed-by:
Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Chase authored
Newer versions of gcc notice a type mismatch and complain. Fix code to match documented signature in MSDN. Trybots say this still compiles with the older (5.1) version of gcc. Fixes #17771. Change-Id: Ib3fe6f71b40751e1146249e31232da5ac69b9e00 Reviewed-on: https://go-review.googlesource.com/32646 Run-TryBot: David Chase <drchase@google.com> Reviewed-by:
-
Russ Cox authored
This matches exposing CertificateInvalidError.Cert. and (exposing but not the spelling of) HostnameError.Certificate. Fixes #13519. Change-Id: Ifae9a09e063d642c09de3cdee8a728ff06d3a5df Reviewed-on: https://go-review.googlesource.com/32644 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
A bit contrived to come up with an example, but it happened in #15836, somehow. $ cat /tmp/x.go package main /* #include <stddef.h> int foo(void); int foo(void) { return 2; } #define int asdf */ import "C" func main() { println(C.foo()) } $ go run /tmp/x.go # command-line-arguments cgo-builtin-prolog:9:31: error: unknown type name 'asdf' <<<<< _GoString_ GoStringN(char *p, int l); ^ /tmp/x.go:12:13: note: expanded from macro 'int' #define int asdf ^ cgo-builtin-prolog:10:28: error: unknown type name 'asdf' <<<<< _GoBytes_ GoBytes(void *p, int n); ^ /tmp/x.go:12:13: note: expanded from macro 'int' #define int asdf ^ 2 errors generated. The two marked lines used to refer incorrectly to /tmp/x.go. Fixes #15836. Change-Id: I08ef60a53cfd148112fceb651eaf7b75d94a7a8d Reviewed-on: https://go-review.googlesource.com/32613 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Russ Cox authored
Consider a switch like switch x { case foo: f() g() } Before, the coverage annotation for the block calling f and g included in its position span the text for 'case foo:'. This looks nice in the coverage report, but it breaks the invariant that coverage blocks are disjoint if you have a more complex expression like: switch x { case func() int { return foo }(): f() g() } Then the coverage analysis wants to annotate the func literal body, which overlaps with the case body, because the case body is considered to begin at the case token. Change the annotation for a case body to start just after the colon of the case clause, avoiding any potential conflict with complex case expressions. Could have started at the colon instead, but it seemed less weird to start just after it. Fixes #16540. Change-Id: I1fec4bc2a53c7092e649dc0d4be1680a697cb79b Reviewed-on: https://go-review.googlesource.com/32612 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: -
Russ Cox authored
Clear it before any tests begin. Clear it again after TestIsSecureGitAllowProtocol sets it. Fixes #17700. Change-Id: I6ea50d37f8222d8c7c9fee0b1eac3bbdfb5d133e Reviewed-on: https://go-review.googlesource.com/32640Reviewed-by:
Quentin Smith <quentin@golang.org> Run-TryBot: Russ Cox <rsc@golang.org>
-
Russ Cox authored
The goal of the test is to provoke a custom import path check error, which will contain the current repo path, to see that it says ssh:// in it. But the fix to #16471 made the test no longer provoke that error. Provoke the error by checking out from rsc.io instead of github.com/rsc. Fixes #17701. Change-Id: I750ffda2ff59c2be8e111d26160997214a73fd9a Reviewed-on: https://go-review.googlesource.com/32641 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
This matches the removal of .so files and makes the processing of '-L/path/to -lfoo' and plain '/path/to/foo.a' match. Fixes #16463. Change-Id: I1464c5390d7eb6a3a33b4b2c951f87ef392ec94a Reviewed-on: https://go-review.googlesource.com/32642 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
Fixes #16712. Change-Id: Ib216059c6c0c952162c19e080dcf3799f0652a8d Reviewed-on: https://go-review.googlesource.com/32171 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Russ Cox authored
Fixes #17689. Change-Id: I45a14e6bf4b2647431105f3e0b63b7076b6655d2 Reviewed-on: https://go-review.googlesource.com/32635 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
Not "J", not "JAN", not "jan", etc. Fixes #17523. Change-Id: I16b5da97e73d88c6680c36401d30f8a195061527 Reviewed-on: https://go-review.googlesource.com/32636 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
