An error occurred fetching the project authors.
  1. 02 Nov, 2018 1 commit
  2. 01 Jun, 2018 1 commit
  3. 30 Apr, 2018 1 commit
  4. 14 Jul, 2017 1 commit
  5. 26 Apr, 2017 1 commit
    • Ian Lance Taylor's avatar
      os, net, internal/poll: return consistent error for closed socket · fb4b4342
      Ian Lance Taylor authored
      In the past we returned "use of closed network connection" when using
      a closed network descriptor in some way. In CL 36799 that was changed
      to return "use of closed file or network connection". Because programs
      have no access to a value of this error type (see issue #4373) they
      resort to doing direct string comparisons (see issue #19252). This CL
      restores the old error string so that we don't break programs
      unnecessarily with the 1.9 release.
      
      This adds a test to the net package for the expected string.
      
      For symmetry check that the os package returns the expected error,
      which for os already exists as os.ErrClosed.
      
      Updates #4373.
      Fixed #19252.
      
      Change-Id: I5b83fd12cfa03501a077cad9336499b819f4a38b
      Reviewed-on: https://go-review.googlesource.com/39997
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      fb4b4342
  6. 07 Mar, 2017 1 commit
  7. 15 Feb, 2017 1 commit
    • Ian Lance Taylor's avatar
      os: use poller for file I/O · c05b06a1
      Ian Lance Taylor authored
      This changes the os package to use the runtime poller for file I/O
      where possible. When a system call blocks on a pollable descriptor,
      the goroutine will be blocked on the poller but the thread will be
      released to run other goroutines. When using a non-pollable
      descriptor, the os package will continue to use thread-blocking system
      calls as before.
      
      For example, on GNU/Linux, the runtime poller uses epoll. epoll does
      not support ordinary disk files, so they will continue to use blocking
      I/O as before. The poller will be used for pipes.
      
      Since this means that the poller is used for many more programs, this
      modifies the runtime to only block waiting for the poller if there is
      some goroutine that is waiting on the poller. Otherwise, there is no
      point, as the poller will never make any goroutine ready. This
      preserves the runtime's current simple deadlock detection.
      
      This seems to crash FreeBSD systems, so it is disabled on FreeBSD.
      This is issue 19093.
      
      Using the poller on Windows requires opening the file with
      FILE_FLAG_OVERLAPPED. We should only do that if we can remove that
      flag if the program calls the Fd method. This is issue 19098.
      
      Update #6817.
      Update #7903.
      Update #15021.
      Update #18507.
      Update #19093.
      Update #19098.
      
      Change-Id: Ia5197dcefa7c6fbcca97d19a6f8621b2abcbb1fe
      Reviewed-on: https://go-review.googlesource.com/36800
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      c05b06a1
  8. 13 Feb, 2017 1 commit
  9. 24 Aug, 2016 1 commit
    • Ian Lance Taylor's avatar
      net: use runtime.Keepalive for *netFD values · 873dca4c
      Ian Lance Taylor authored
      The net package sets a finalizer on *netFD. I looked through all the
      uses of *netFD in the package, looking for each case where a *netFD
      was passed as an argument and the final reference to the argument was
      not a function or method call. I added a call to runtime.KeepAlive after
      each such final reference (there were only three).
      
      The code is safe today without the KeepAlive calls because the compiler
      keeps arguments alive for the duration of the function. However, that is
      not a language requirement, so adding the KeepAlive calls ensures that
      this code remains safe even if the compiler changes in the future.
      
      Change-Id: I4e2bd7c5a946035dc509ccefb4828f72335a9ee3
      Reviewed-on: https://go-review.googlesource.com/27650
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      873dca4c
  10. 17 Mar, 2016 1 commit
  11. 01 Mar, 2016 1 commit
  12. 04 Feb, 2015 1 commit
  13. 08 Sep, 2014 1 commit
  14. 25 Feb, 2014 1 commit
    • Dave Cheney's avatar
      all: merge NaCl branch (part 1) · 7c8280c9
      Dave Cheney authored
      See golang.org/s/go13nacl for design overview.
      
      This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
      
      CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
      
      The exact change lists included are
      
      15050047: syscall: support for Native Client
      15360044: syscall: unzip implementation for Native Client
      15370044: syscall: Native Client SRPC implementation
      15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
      15410048: runtime: support for Native Client
      15410049: syscall: file descriptor table for Native Client
      15410050: syscall: in-memory file system for Native Client
      15440048: all: update +build lines for Native Client port
      15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
      15570045: os: support for Native Client
      15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
      15690044: net: support for Native Client
      15690048: runtime: support for fake time like on Go Playground
      15690051: build: disable various tests on Native Client
      
      LGTM=rsc
      R=rsc
      CC=golang-codereviews
      https://golang.org/cl/68150047
      7c8280c9