An error occurred fetching the project authors.
  1. 04 May, 2018 11 commits
    • Brad Fitzpatrick's avatar
      cmd/dist: fix computation of test timeout · 8aa316c1
      Brad Fitzpatrick authored
      When dist test was updated to run "go test" with multiple package
      arguments at once, merging the logical test units into one execution,
      the hack to give cmd/go twice as much time wasn't updated.
      
      What was happening (even in the all.bash case) was that we were
      merging together, say, "cmd/go" and "bytes", and because bar was
      lexically earlier, the timeout calculation was based on package "byte",
      even though we were actually running, say: "go test bytes cmd/go".
      
      This explains why x/build/cmd/release was often flaky with its
      all.bash, since cmd/go can't really finish in 3 minutes reliably
      unless it's running by itself. If it has any competition, it runs
      over.
      
      Change-Id: I875c8c9e65940ce0ceff48215740dfadfaa89d3f
      Reviewed-on: https://go-review.googlesource.com/111395
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAndrew Bonventre <andybons@golang.org>
      8aa316c1
    • Elias Naur's avatar
      cmd/link/internal/ld: skip DWARF combining for iOS binaries · bcdbd58c
      Elias Naur authored
      The macOS and iOS external linker strips DWARF information from
      binaries because it assumes the information will go into separate
      DWARF information .dSYM files. To preserve the embedded debugging
      information, the Go linker re-combines the separate DWARF
      information into the unmapped __DWARF segment of the final
      executable.
      
      However, the iOS dyld linker does not allow unmapped segments, so
      use the presence of the LC_VERSION_MIN_IPHONEOS linker command to
      skip DWARF combining. Note that we can't use GOARCH for detection
      since the iOS emulator runs on  GOARCH=386 and GOARCH=amd64 and we
      will run into https://golang.org/issues/25148.
      
      Updates #25148.
      
      Change-Id: I29a1bc468fdee74ab3b27c46931501a0a8120c66
      Reviewed-on: https://go-review.googlesource.com/111275
      Run-TryBot: Elias Naur <elias.naur@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      bcdbd58c
    • Lynn Boger's avatar
      cmd/go, cmd/link: provide meaningful error msg with ext linking on ppc64 · 506d6a32
      Lynn Boger authored
      linux/ppc64 uses the ppc64 v1 ABI which was never fully supported
      by Go. (linux/ppc64le uses the ppc64 v2 ABI and that is fully
      supported).
      
      As a result if the external linker is used to build a program
      on ppc64, there is a either a warning or error message that doesn't
      clearly describe the problem. In the case of a warning,
      a program is created that will most likely not execute since it is not
      built as expected for the ppc64 dynamic linker (ld64.so.1).
      
      To avoid confusion in these cases, error messages are now issued
      if external linker is explicitly used to build the program. Note that most
      buildmodes that require external linking were already flagging linux/ppc64
      as unsupported except for c-archive, which has been added here.
      
      This problem does not occur with gccgo since the ppc64 v1 ABI is
      supported there.
      
      Fixes #25079
      
      Change-Id: I44d77a1eb9df750d499cd432b0ca4a97f0be88b2
      Reviewed-on: https://go-review.googlesource.com/109915Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      506d6a32
    • Zhou Peng's avatar
      src/*.bash: remove some trailing whitespace · 166c37a7
      Zhou Peng authored
      Change-Id: I11793daafdb69156b1dafaa80fe501fcaeeff202
      Reviewed-on: https://go-review.googlesource.com/111435Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      166c37a7
    • Elias Naur's avatar
      compress/gzip: skip builder-only test on iOS · 51bda1ff
      Elias Naur authored
      The new iOS test harness forwards environment variables to the
      test program, which means that it runs builder-only tests that were
      previously skipped because GO_BUILDER_NAME was missing.
      
      Skip one such unblocked test, TestGZIPFilesHaveZeroMTimes, which
      assumes a valid GOROOT.
      
      Change-Id: I5daf0f4c1897afbeb8b1a380669a1d2aa47e764a
      Reviewed-on: https://go-review.googlesource.com/111475
      Run-TryBot: Elias Naur <elias.naur@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      51bda1ff
    • Elias Naur's avatar
      net: skip unsupported tests on iOS · 42219419
      Elias Naur authored
      The new iOS test harness forwards environment variables, such that
      tests that skipped on non-builders now run because GO_BUILDER_NAME
      is set.
      
      Skip the net tests that rely on resolv.conf being present.
      
      Change-Id: I7875dc4252b2ab696c9aae13a9106ddf296ee8ec
      Reviewed-on: https://go-review.googlesource.com/111476
      Run-TryBot: Elias Naur <elias.naur@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      42219419
    • Elias Naur's avatar
      misc/ios: improve detection of missing developer image · 164718ae
      Elias Naur authored
      It turns out that a non-empty result from ideviceimagemounter does
      not mean an image is mounted. Use ideviceimagemounter's xml output
      mode to improve the check.
      
      Also, iOS versions are reported as major.minor or major.minor.patch.
      Developer images are only specific to major.minor version, so cut
      off the patch number in the search, if present.
      
      Change-Id: Ia182e6f4655b7e6aa6feb8005cd3b533535b73cd
      Reviewed-on: https://go-review.googlesource.com/111235
      Run-TryBot: Elias Naur <elias.naur@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarHyang-Ah Hana Kim <hyangah@gmail.com>
      164718ae
    • Martin Möhrmann's avatar
      strings: fix encoding of \u0080 in map · 8c62fc0c
      Martin Möhrmann authored
      Fix encoding of PAD (U+0080) which has the same value as utf8.RuneSelf
      being incorrectly encoded as \x80 in strings.Map due to using <= instead
      of a < comparison operator to check one byte encodings for utf8.
      
      Fixes #25242
      
      Change-Id: Ib6c7d1f425a7ba81e431b6d64009e713d94ea3bc
      Reviewed-on: https://go-review.googlesource.com/111286
      Run-TryBot: Martin Möhrmann <moehrmann@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      8c62fc0c
    • Daniel Martí's avatar
      cmd/vet: better align print warnings with fmt · 98409a44
      Daniel Martí authored
      fmt's %d, %x, and %X all accept pointer arguments. However, in cmd/vet's
      printVerbs table, they were defined as if they did not accept pointer
      arguments.
      
      This inconsistency with fmt did not manifest to users since the vet
      codebase worked around it. In particular, pointer arguments were usually
      allowed for verbs that accepted integers, as the *types.Pointer argument
      type case read the following:
      
      	t&(argInt|argPointer) != 0
      
      As a result, using the %q verb with a pointer resulted in a bug in
      cmd/vet:
      
      	$ go run f.go
      	%!q(*int=0xc000014140)
      	$ go vet f.go
      	[no warning]
      
      As documented, fmt's %q verb only accepts runes (integers), strings, and
      byte slices. It should not accept pointers, and it does not. But since
      vet mixed integers and pointers, it wasn't properly warning about the
      misuse of fmt.
      
      This patch surfaced another bug with fmt.Printf("%p", nil):
      
      	$ go run f.go
      	%!p(<nil>)
      	$ go vet f.go
      	[no warning]
      
      As documented, fmt's %p verb only accepts pointers, and untyped nil is
      not a valid pointer. But vet did not warn about it, which is another
      inconsistency with fmt's documented rules. Fix that too, with a test,
      also getting rid of the TODO associated with the code.
      
      As a result of those changes, fix a wrong use of the fmt format verbs in
      the standard library, now correctly spotted by vet.
      
      Fixes #25233.
      
      Change-Id: Id0ad31fbc25adfe1c46c6b6879b8d02b23633b3a
      Reviewed-on: https://go-review.googlesource.com/111284
      Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAlan Donovan <adonovan@google.com>
      98409a44
    • Brad Fitzpatrick's avatar
      cmd/go, cmd/compile: use Windows response files to avoid arg length limits · 17fbb836
      Brad Fitzpatrick authored
      Fixes #18468
      
      Change-Id: Ic88a8daf67db949e5b59f9aa466b37e7f7890713
      Reviewed-on: https://go-review.googlesource.com/110395Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      17fbb836
    • Ian Lance Taylor's avatar
      cmd/go, go/build: add support for gccgo tooldir · 498c803c
      Ian Lance Taylor authored
      The gccgo toolchain does not put tools (cgo, vet, etc.) in
      $GOROOT/pkg/tool, but instead in a directory available at
      runtime.GCCGOTOOLDIR.
      
      Update the go/build package and the cmd/go tool to use this tool
      directory when using gccgo.
      
      Change-Id: Ib827336ff53601208300aceb77f76c2e1b069859
      Reviewed-on: https://go-review.googlesource.com/111097
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      498c803c
  2. 03 May, 2018 18 commits
  3. 02 May, 2018 11 commits