An error occurred fetching the project authors.
- 15 Oct, 2012 1 commit
-
-
Nigel Tao authored
To be clear, this supports decoding the bytes on the wire into an in-memory image. There is no API change: jpeg.Decode will still not return until the entire image is decoded. The code is obviously more complicated, and costs around 10% in performance on baseline JPEGs. The processSOS code could be cleaned up a bit, and maybe some of that loss can be reclaimed, but I'll leave that for follow-up CLs, to keep the diff for this one as small as possible. Before: BenchmarkDecode 1000 2855637 ns/op 21.64 MB/s After: BenchmarkDecodeBaseline 500 3178960 ns/op 19.44 MB/s BenchmarkDecodeProgressive 500 4082640 ns/op 15.14 MB/s Fixes #3976. The test data was generated by: # Create intermediate files; cjpeg on Ubuntu 10.04 can't read PNG. convert video-001.png video-001.bmp convert video-005.gray.png video-005.gray.pgm # Create new test files. cjpeg -quality 100 -sample 1x1,1x1,1x1 -progressive video-001.bmp > video-001.progressive.jpeg cjpeg -quality 50 -sample 2x2,1x1,1x1 video-001.bmp > video-001.q50.420.jpeg cjpeg -quality 50 -sample 2x1,1x1,1x1 video-001.bmp > video-001.q50.422.jpeg cjpeg -quality 50 -sample 1x1,1x1,1x1 video-001.bmp > video-001.q50.444.jpeg cjpeg -quality 50 -sample 2x2,1x1,1x1 -progressive video-001.bmp > video-001.q50.420.progressive.jpeg cjpeg -quality 50 -sample 2x1,1x1,1x1 -progressive video-001.bmp > video-001.q50.422.progressive.jpeg cjpeg -quality 50 -sample 1x1,1x1,1x1 -progressive video-001.bmp > video-001.q50.444.progressive.jpeg cjpeg -quality 50 video-005.gray.pgm > video-005.gray.q50.jpeg cjpeg -quality 50 -progressive video-005.gray.pgm > video-005.gray.q50.progressive.jpeg # Delete intermediate files. rm video-001.bmp video-005.gray.pgm R=r CC=golang-dev https://golang.org/cl/6684046
-
- 07 Oct, 2012 1 commit
-
-
Nigel Tao authored
refer to opacity. Those references were copy/pasted from the image/png encoding benchmarks, which cares whether or not the source image is opaque, but the JPEG encoder does not care. R=r CC=golang-dev https://golang.org/cl/6623052
-
- 06 Oct, 2012 1 commit
-
-
Nigel Tao authored
elimination) in idct.go. benchmark old ns/op new ns/op delta BenchmarkIDCT 5649 5610 -0.69% BenchmarkDecodeRGBOpaque 2948607 2941051 -0.26% The "type block" declaration moved so that idct.go is compilable as a stand-alone file: "go tool 6g -S idct.go" works. R=r CC=golang-dev https://golang.org/cl/6619056
-
- 06 Sep, 2012 1 commit
-
-
Nigel Tao authored
order. JPEG images generated prior to this CL are still valid JPEGs, as the quantization tables used are encoded in the wire format. Such JPEGs just don't use the recommended quantization tables. R=r, dsymonds, raph, adg CC=golang-dev, tuom.larsen https://golang.org/cl/6497083
-
- 06 Feb, 2012 1 commit
-
-
Rob Pike authored
The practice encourages people to think this is the way to create a bytes.Buffer when new(bytes.Buffer) or just var buf bytes.Buffer work fine. (html/token.go was missing the point altogether.) R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5637043
-
- 20 Dec, 2011 1 commit
-
-
Rob Pike authored
Lots of panics go away. Also fix a name error in html/template. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5498045
-
- 08 Nov, 2011 1 commit
-
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/5358041
-
- 02 Nov, 2011 2 commits
-
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5319072
-
Russ Cox authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/5322051
-
- 04 Oct, 2011 1 commit
-
-
Nigel Tao authored
The spin-off renames some types. The new names are simply better: image.Color -> color.Color image.ColorModel -> color.Model image.ColorModelFunc -> color.ModelFunc image.PalettedColorModel -> color.Palette image.RGBAColor -> color.RGBA image.RGBAColorModel -> color.RGBAModel image.RGBA64Color -> color.RGBA64 image.RGBA64ColorModel -> color.RGBA64Model (similarly for NRGBAColor, GrayColorModel, etc) The image.ColorImage type stays in the image package, but is renamed: image.ColorImage -> image.Uniform The image.Image implementations (image.RGBA, image.RGBA64, image.NRGBA, image.Alpha, etc) do not change their name, and gain a nice symmetry: an image.RGBA is an image of color.RGBA, etc. The image.Black, image.Opaque uniform images remain unchanged (although their type is renamed from image.ColorImage to image.Uniform). The corresponding color types (color.Black, color.Opaque, etc) are new. Nothing in the image/ycbcr is renamed yet. The ycbcr.YCbCrColor and ycbcr.YCbCrImage types will eventually migrate to color.YCbCr and image.YCbCr, but that will be a separate CL. R=r, bsiegert CC=golang-dev https://golang.org/cl/5132048
-
- 14 Sep, 2011 1 commit
-
-
Mikio Hara authored
R=golang-dev CC=golang-dev https://golang.org/cl/5020045
-
- 29 Apr, 2011 1 commit
-
-
Brad Fitzpatrick authored
No code changes in this CL. R=r CC=golang-dev https://golang.org/cl/4445074
-
- 19 Apr, 2011 1 commit
-
-
Nigel Tao authored
It is based on changeset 4186064 by Raph Levien <raph@google.com>. R=r, nigeltao_gnome CC=golang-dev https://golang.org/cl/4435051
-