An error occurred fetching the project authors.
- 01 Nov, 2019 1 commit
-
-
Domas Tamašauskas authored
User's program was mutating time.Local variable and crashing itself as a consequence. Instead of documenting that time.Local variable should not be mutated, recommended way of setting the system's time zone has been documented. Fixes #34814 Change-Id: I7781189855c3bf2ea979dfa07f86c283eed27091 Reviewed-on: https://go-review.googlesource.com/c/go/+/200457Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 15 Oct, 2019 1 commit
-
-
Ian Lance Taylor authored
In the tzdata database CEST is not recognized as a timezone name. It is used as the abbreviated name for daylight saving time in Central Europe. Avoid using CEST in documentation as it suggests that programs can parse dates that use CEST, which will typically fail on Unix systems. Updates #34913 Change-Id: I4b22f7d06607eb5b066812a48af58edd95498286 Reviewed-on: https://go-review.googlesource.com/c/go/+/201197 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Bryan C. Mills <bcmills@google.com>
-
- 02 Dec, 2018 1 commit
-
-
Tobias Klauser authored
Follow-up for CL 147037 and after Brad noticed the "returns whether" pattern during the review of CL 150621. Go documentation style for boolean funcs is to say: // Foo reports whether ... func Foo() bool (rather than "returns whether") Created with: $ perl -i -npe 's/returns whether/reports whether/' $(git grep -l "returns whether" | grep -v vendor) Change-Id: I15fe9ff99180ad97750cd05a10eceafdb12dc0b4 Reviewed-on: https://go-review.googlesource.com/c/150918 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 03 Oct, 2018 1 commit
-
-
Florian Uekermann authored
Unsuccessful calls to LoadLocation previously returned the first error encountered while traversing the default list of sources, but ignored errors from sources specified by ZONEINFO. Whether errors indicating missing zones or sources were ignored in this process differed between kinds of sources. With this change, unsuccessful calls to LoadLocation always return the first error, not counting errors indicating missing zones or sources. Change-Id: Ief2c088f1df53d974b837e6565e784c2b9928ef4 Reviewed-on: https://go-review.googlesource.com/c/81595 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 24 Mar, 2018 1 commit
-
-
Daniel Martí authored
As found by unparam. Picked the low-hanging fruit, consisting only of errors that were always nil and results that were never used. Left out those that were useful for consistency with other func signatures. Change-Id: I06b52bbd3541f8a5d66659c909bd93cb3e172018 Reviewed-on: https://go-review.googlesource.com/102418 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 13 Feb, 2018 1 commit
-
-
Kevin Burke authored
iana.org, www.iana.org and data.iana.org all present a valid TLS certificate, so let's use it when fetching data or linking to resources to avoid errors in transit. Change-Id: Ib3ce7c19789c4e9d982a776b61d8380ddc63194d Reviewed-on: https://go-review.googlesource.com/89416Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 21 Nov, 2017 1 commit
-
-
Florian Uekermann authored
The return values of the LoadLocation are inherently dependent on the runtime environment. Add LoadLocationFromTZData, whose results depend only on the timezone data provided as arguments. Fixes #20629 Change-Id: I43b181f4c05c219be3ec57327540263b7cb3b2aa Reviewed-on: https://go-review.googlesource.com/68890Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 16 Nov, 2017 1 commit
-
-
Russ Cox authored
This reverts commit 630d176e. Reason for revert: the CL moves a parser for what appears to be an Android-specific file format into the main code and makes it available on all platforms. Android-specific file formats should be limited to Android. Change-Id: I3f19fe03673d65ed1446a0dcf95e5986053e10c0 Reviewed-on: https://go-review.googlesource.com/77950Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 03 Oct, 2017 1 commit
-
-
Florian Uekermann authored
Loading location data from tzdata files was only supported from default paths on android. This change enables support on all OS via the ZONEINFO environment variable and reduces the amount of android specific code significantly. Furthermore, unsuccessful calls to LoadLocation now return the first error encountered, including errors from attempting to load a location from the source specified by ZONEINFO. Errors indicating that the source or location was not found are ignored until all possible sources have been traversed. Change-Id: I45bc23b92253c9447f12f95f3ca29a7e613ed995 Reviewed-on: https://go-review.googlesource.com/67170Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 27 Sep, 2017 1 commit
-
-
Florian Uekermann authored
Loading and testing timezones is currently implemented using several, partly redundant, OS specific data structures and functions. This change merges most of that code into OS independent implementations. Change-Id: Iae2877c5f48d1e4a9de9ce55d0530d52e24cf96e Reviewed-on: https://go-review.googlesource.com/64391 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 14 Aug, 2017 1 commit
-
-
Kevin Burke authored
lookupName is only called in one location, and one of the return values is unused, so let's remove it. Change-Id: I35e22c7ec611e8eb349deb4f0561e212f7d9de0b Reviewed-on: https://go-review.googlesource.com/55232Reviewed-by:
Daniel Martí <mvdan@mvdan.cc> Reviewed-by:
Rob Pike <r@golang.org> Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
-
- 15 Jul, 2017 1 commit
-
-
Pat Moroney authored
Change-Id: I5c32a968303848304cbd6fe1e83bed0af11f6440 Reviewed-on: https://go-review.googlesource.com/48960Reviewed-by:
Caleb Spare <cespare@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 08 Feb, 2017 1 commit
-
-
Brad Fitzpatrick authored
Fixes #18985 Change-Id: I956117f47d1d2b453b4786c7b78c1c944defeca0 Reviewed-on: https://go-review.googlesource.com/36551Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 01 Feb, 2017 1 commit
-
-
Jeff Johnson authored
A user application can now use os.Setenv("ZONEINFO", ..) becase the value is no longer read on init of the time package. Fixes #18619 Change-Id: Id8e303d67e6fb9c5d6ea9f969d8c94f6fff1bee3 Reviewed-on: https://go-review.googlesource.com/35639Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 28 Aug, 2016 1 commit
-
-
Alex Brainman authored
genzabbrs.go uses whatever zoneinfo database available on the system. This makes genzabbrs.go output change from system to system. Adjust go:generate line to always use $GOROOT/lib/time/zoneinfo.zip, so it does not matter who runs the command. Also move go:generate line into zoneinfo.go, so it can be run on Unix (see #16368 for details). Fixes #15802. Change-Id: I8ae4818aaf40795364e180d7bb4326ad7c07c370 Reviewed-on: https://go-review.googlesource.com/27832Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 26 Jan, 2016 1 commit
-
-
Ian Lance Taylor authored
Fixes #14099. Change-Id: I122e918bdc55fb185f4a4a797489b160219542d2 Reviewed-on: https://go-review.googlesource.com/18943 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
- 08 Sep, 2014 1 commit
-
-
Russ Cox authored
Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg.
-
- 01 Feb, 2014 1 commit
-
-
Ian Lance Taylor authored
No functional changes, just more readable code. LGTM=r R=golang-codereviews, gobot, r CC=golang-codereviews https://golang.org/cl/59240043
-
- 31 Jan, 2014 1 commit
-
-
Ian Lance Taylor authored
LGTM=r R=golang-codereviews, r, arnehormann, bradfitz CC=golang-codereviews https://golang.org/cl/58450043
-
- 03 Aug, 2013 1 commit
-
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/12396043
-
- 04 Feb, 2013 1 commit
-
-
Russ Cox authored
* Document Parse's zone interpretation. * Add ParseInLocation (API change). * Recognize "wrong" time zone names, like daylight savings time in winter. * Disambiguate time zone names using offset (like winter EST vs summer EST in Sydney). The final two are backwards-incompatible changes, but I believe they are both buggy behavior in the Go 1.0 versions; the old results were more wrong than the new ones. Fixes #3604. Fixes #3653. Fixes #4001. R=adg CC=golang-dev https://golang.org/cl/7288052
-
- 03 Jun, 2012 1 commit
-
-
Russ Cox authored
benchmark old ns/op new ns/op delta BenchmarkFormat 2495 937 -62.44% BenchmarkFormatNow 2308 889 -61.48% Update #3679. R=r CC=golang-dev https://golang.org/cl/6278047
-
- 19 Feb, 2012 2 commits
-
-
Russ Cox authored
Removal of old zoneinfo files is a separate CL due to its size. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5676100
-
Russ Cox authored
Fixes #2964. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5656101
-
- 30 Nov, 2011 1 commit
-
-
Russ Cox authored
R=r, bradfitz, gri, dsymonds, iant CC=golang-dev https://golang.org/cl/5392041
-
- 25 Aug, 2010 1 commit
-
-
Ian Lance Taylor authored
R=r, rsc CC=brainman, golang-dev https://golang.org/cl/2020043
-
- 17 Aug, 2010 1 commit
-
-
Roger Peppe authored
R=rsc, r CC=golang-dev https://golang.org/cl/2005042
-
- 05 Aug, 2010 1 commit
-
-
Rob Pike authored
package once remains for now; will be deleted after next release. R=golang-dev, brainman CC=golang-dev https://golang.org/cl/1914046
-
- 04 Feb, 2010 1 commit
-
-
Rob Pike authored
Make sure to print a time zone when formatting even if none is defined. Add a comment introducing lookupTimezone (not lookupTimeZone). Fixes isse 577. R=rsc CC=golang-dev https://golang.org/cl/196090
-
- 15 Dec, 2009 1 commit
-
-
Robert Griesemer authored
parsing and printing to new syntax. Use -oldparser to parse the old syntax, use -oldprinter to print the old syntax. 2) Change default gofmt formatting settings to use tabs for indentation only and to use spaces for alignment. This will make the code alignment insensitive to an editor's tabwidth. Use -spaces=false to use tabs for alignment. 3) Manually changed src/exp/parser/parser_test.go so that it doesn't try to parse the parser's source files using the old syntax (they have new syntax now). 4) gofmt -w src misc test/bench 5th and last set of files. R=rsc CC=golang-dev https://golang.org/cl/180050
-
- 03 Dec, 2009 1 commit
-
-
Rob Pike authored
this breaks the dependency of package io on package bytes. R=rsc CC=golang-dev https://golang.org/cl/163085
-
- 20 Nov, 2009 1 commit
-
-
Russ Cox authored
R=r, gri CC=golang-dev https://golang.org/cl/156115
-
- 10 Nov, 2009 1 commit
-
-
Robert Griesemer authored
rsc's algorithm - applied gofmt -w misc src - partial CL (last chunk) R=rsc, r http://go/go-review/1024041
-
- 09 Nov, 2009 1 commit
-
-
Robert Griesemer authored
R=rsc, r http://go/go-review/1025029
-
- 28 Oct, 2009 1 commit
-
-
Russ Cox authored
R=gri http://go/go-review/1015011
-
- 08 Oct, 2009 1 commit
-
-
Russ Cox authored
R=gri OCL=35485 CL=35488
-
- 07 Oct, 2009 1 commit
-
-
Russ Cox authored
apply gofmt to rand reflect regexp rpc runtime sort strconv strings sync syscall testing time unicode unsafe utf8 R=gri DELTA=1409 (79 added, 24 deleted, 1306 changed) OCL=35415 CL=35437
-
- 15 Sep, 2009 2 commits
- 27 Jun, 2009 1 commit
-
-
Rob Pike authored
Getenverror is the new name for the old routine that returns an error too. R=rsc DELTA=35 (7 added, 7 deleted, 21 changed) OCL=30818 CL=30821
-