Skip to content

GitLab

"README.rst" did not exist on "a5a37e8bcb8f1161dba4a77022786b24f35e0119"
Switch branch/tag
  1. 03 Feb, 2013 1 commit
  3. 30 Nov, 2012 1 commit
  5. 06 Nov, 2012 1 commit
  7. 30 Oct, 2012 1 commit
    • Alex Brainman's avatar
      net: fix connection resets when closed on windows · fa3e4fc4
      Alex Brainman authored 
      It is common to close network connection while another goroutine is
blocked reading on another goroutine. This sequence corresponds to
windows calls to WSARecv to start io, followed by GetQueuedCompletionStatus
that blocks until io completes, and, finally, closesocket called from
another thread. We were expecting that closesocket would unblock
GetQueuedCompletionStatus, and it does, but not always
(http://code.google.com/p/go/issues/detail?id=4170#c5). Also that sequence
results in connection is being reset.

This CL inserts CancelIo between GetQueuedCompletionStatus and closesocket,
and waits for both WSARecv and GetQueuedCompletionStatus to complete before
proceeding to closesocket.  This seems to fix both connection resets and
issue 4170. It also makes windows code behave similar to unix version.

Unfortunately, CancelIo needs to be called on the same thread as WSARecv.
So we have to employ strategy we use for connections with deadlines to
every connection now. It means, there are 2 unavoidable thread switches
for every io. Some newer versions of windows have new CancelIoEx api that
doesn't have these drawbacks, and this CL uses this capability when available.
As time goes by, we should have less of CancelIo and more of CancelIoEx
systems. Computers with CancelIoEx are also not affected by issue 4195 anymore.

Fixes #3710
Fixes #3746
Fixes #4170
Partial fix for issue 4195

R=golang-dev, mikioh.mikioh, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6604072
      fa3e4fc4
  9. 17 Feb, 2012 1 commit
  11. 06 Feb, 2012 1 commit
  13. 26 Jan, 2012 2 commits
  15. 23 Dec, 2011 1 commit
  17. 20 Dec, 2011 1 commit
  19. 12 Dec, 2011 1 commit
  21. 08 Nov, 2011 1 commit
  23. 03 Nov, 2011 1 commit
    • Rob Pike's avatar
      net: renamings · de03d502
      Rob Pike authored 
      This is Go 1 package renaming CL #3.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into net.

http -> net/http
http/cgi -> net/http/cgi
http/fcgi -> net/http/fcgi
http/pprof -> net/http/pprof
http/httptest -> net/http/httptest
mail -> net/mail
rpc -> net/rpc
rpc/jsonrpc -> net/rpc/jsonrpc
smtp -> net/smtp
url -> net/url

Also remove rand (now math/rand) from NOTEST - it has a test.

The only edits are in Makefiles and deps.bash.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5335048
      de03d502
  25. 02 Nov, 2011 1 commit
  27. 01 Nov, 2011 1 commit
  29. 18 Oct, 2011 1 commit
  31. 31 Aug, 2011 1 commit
  33. 15 Aug, 2011 1 commit
  35. 28 Jul, 2011 1 commit
  37. 22 Jun, 2011 1 commit
    • Robert Griesemer's avatar
      os.Error API: don't export os.ErrorString, use os.NewError consistently · 712fb6dc
      Robert Griesemer authored 
      This is a core API change.

1) gofix misc src
2) Manual adjustments to the following files under src/pkg:
   gob/decode.go
   rpc/client.go
   os/error.go
   io/io.go
   bufio/bufio.go
   http/request.go
   websocket/client.go
as well as:
   src/cmd/gofix/testdata/*.go.in (reverted)
   test/fixedbugs/bug243.go
3) Implemented gofix patch (oserrorstring.go) and test case (oserrorstring_test.go)

Compiles and runs all tests.

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/4607052
      712fb6dc
  39. 26 Apr, 2011 2 commits
  41. 21 Mar, 2011 1 commit
  43. 16 Mar, 2011 1 commit
  45. 15 Mar, 2011 2 commits
  47. 07 Mar, 2011 1 commit
  49. 09 Feb, 2011 1 commit
  51. 01 Feb, 2011 1 commit
  53. 31 Jan, 2011 1 commit
  55. 02 Nov, 2010 1 commit
  57. 28 Oct, 2010 1 commit
  59. 12 Oct, 2010 1 commit
    • Rob Pike's avatar
      log: new interface · 12da5a90
      Rob Pike authored 
      New logging interface simplifies and generalizes.

1) Loggers now have only one output.
2) log.Stdout, Stderr, Crash and friends are gone.
	Logging is now always to standard error by default.
3) log.Panic* replaces log.Crash*.
4) Exiting and panicking are not part of the logger's state; instead
	the functions Exit* and Panic* simply call Exit or panic after
	printing.
5) There is now one 'standard logger'.  Instead of calling Stderr,
	use Print etc.  There are now triples, by analogy with fmt:
		Print, Println, Printf
	What was log.Stderr is now best represented by log.Println,
	since there are now separate Print and Println functions
	(and methods).
6) New functions SetOutput, SetFlags, and SetPrefix allow global
	editing of the standard logger's properties.   This is new
	functionality. For instance, one can call
		log.SetFlags(log.Lshortfile|log.Ltime|log.Lmicroseconds)
	to get all logging output to show file name, line number, and
	time stamp.

In short, for most purposes
	log.Stderr -> log.Println or log.Print
	log.Stderrf -> log.Printf
	log.Crash -> log.Panicln or log.Panic
	log.Crashf -> log.Panicf
	log.Exit -> log.Exitln or log.Exit
	log.Exitf -> log.Exitf (no change)

This has a slight breakage: since loggers now write only to one
output, existing calls to log.New() need to delete the second argument.
Also, custom loggers with exit or panic properties will need to be
reworked.

All package code updated to new interface.

The test has been reworked somewhat.

The old interface will be removed after the new release.
For now, its elements are marked 'deprecated' in their comments.

Fixes #1184.

R=rsc
CC=golang-dev
https://golang.org/cl/2419042
      12da5a90
  61. 05 Aug, 2010 1 commit
  63. 28 Jun, 2010 1 commit
  65. 21 Jun, 2010 1 commit
  67. 24 Mar, 2010 1 commit
  69. 15 Dec, 2009 1 commit
    • Robert Griesemer's avatar
      1) Change default gofmt default settings for · d65a5cce
      Robert Griesemer authored 
         parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

4th set of files.

R=rsc
CC=golang-dev
https://golang.org/cl/180049
      d65a5cce
  71. 02 Dec, 2009 1 commit
  73. 17 Nov, 2009 1 commit
    • Aron Nopanen's avatar
      Make non-errored RPC calls return 'nil' error to caller. · c51ee432
      Aron Nopanen authored 
      Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.

This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.

Tests updated to check error return in success cases.

R=r, rsc
https://golang.org/cl/154159
      c51ee432
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7