- 23 Jun, 2017 4 commits
-
-
Russ Cox authored
Avoids confusing errors from the GNU assembler processing Go assembly source code. Fixes #19448. Change-Id: Ic2c68b2521847cca5a3d078a092e5c60ec340840 Reviewed-on: https://go-review.googlesource.com/46423 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Russ Cox authored
The current behavior is to filter out the non-main packages silently, which is confusing if there are only non-main packages. Instead, report an error unless it's used with a single main package. To be clear, I don't really know what I'm doing. It might be that multiple main packages are allowed, or even that we do want the filtering, but all.bash passes with this change, so I am taking that as a sign that we don't need that extra flexibility. Fixes #15082. Change-Id: I984d0f444a01c0ee0c3cd6646a75527ea99a9ebe Reviewed-on: https://go-review.googlesource.com/46421 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
Fixes #18643. Change-Id: I36dca943d552a178a71094ff883b0319fe03d130 Reviewed-on: https://go-review.googlesource.com/46467 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Mikio Hara authored
Fixes #19344. Change-Id: Ic6fc7485cb50bfae99fda69d0cd9c4ae434af4c3 Reviewed-on: https://go-review.googlesource.com/44910Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 22 Jun, 2017 13 commits
-
-
Robert Griesemer authored
Fixes #20749. Change-Id: Ic6a7edc858575c4cb8b2e2ca97ee0c4b69f22c27 Reviewed-on: https://go-review.googlesource.com/46466 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
This change simplifies the documentation on methods of UnixConn. Change-Id: Ibd89f9172b28adfcf7fdd43b3bc196ae7f8302cf Reviewed-on: https://go-review.googlesource.com/44913 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change simplifies the documentation on methods of IPConn and adds a reference to golang.org/x/net/ipv{4,6} packages to the documentation on {Read,Write}MsgIP methods. Change-Id: Ie07a853288940e0fef6a417ffc8d0c3d444c21cd Reviewed-on: https://go-review.googlesource.com/44911 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change simplifies the documentation on methods of UDPConn and adds a reference to golang.org/x/net/{ipv4,ipv6} packages to the documentation on {Read,Write}MsgUDP methods. Change-Id: I425a8d81bc46b6579aa9f89faa4982bb86b40f24 Reviewed-on: https://go-review.googlesource.com/44912 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Russ Cox authored
This makes custom import path checks work even when the custom import metadata directs checking out a subtree of the subversion repository. (Git and Mercurial allow no such thing, so they are unaffected.) Fixes #20731. Change-Id: I635f3a2037d69a87c6dac7b08b0a0d8266abd250 Reviewed-on: https://go-review.googlesource.com/46417 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change adds a reference to the Dial to clarify the parameters and return values. Change-Id: I611b9a79f4033ef035acd7098aea5965905d9a4c Reviewed-on: https://go-review.googlesource.com/34880Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change clarifies the documentation on Resolve{TCP,UDP,IP,Unix}Addr to avoid unnecessary confusion about how the arguments are used to make end point addresses. Also replaces "name" or "hostname" with "host name" when the term implies the use of DNS. Updates #17613. Change-Id: Id6be87fe2e4666eecd5b92f18ad8b9a6c50a2bd6 Reviewed-on: https://go-review.googlesource.com/34879Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change clarifies the documentation on Listen{TCP,UDP,MulticastUDP,IP,Unix,Unixgram} to avoid unnecessary confusion about how the arguments for the connection setup functions are used to make connections. Change-Id: Ie269453ef49ec2db893391dc3ed2f7b641c14249 Reviewed-on: https://go-review.googlesource.com/34878Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change clarifies the documentation on Dial{TCP,UDP,IP,Unix} to avoid unnecessary confusion about how the arguments for the connection setup functions are used to make connections. Change-Id: I2e378182948fbe221f6ae786ab55e77ae90c3f3b Reviewed-on: https://go-review.googlesource.com/34877Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change clarifies the documentation on Listen and ListenPacket to avoid unnecessary confusion about how the arguments for the connection setup functions are used to make connections. Also replaces "name" or "hostname" with "host name" when the term implies the use of DNS. Updates #17613. Updates #17614. Updates #17615. Fixes #17616. Updates #17738. Updates #17956. Change-Id: I0bad2e143207666f2358d397fc076548ee6c3ae9 Reviewed-on: https://go-review.googlesource.com/34876Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change clarifies the documentation on Dial and its variants to avoid unnecessary confusion about how the arguments for the connection setup functions are used to make connections. Also replaces "name" or "hostname" with "host name" when the term implies the use of DNS. Updates #17613. Fixes #17614. Fixes #17738. Fixes #17956. Updates #18806. Change-Id: I6adb3f2ae04a3bf83b96016ed73d8e59926f3e8a Reviewed-on: https://go-review.googlesource.com/34875Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Michael Hendricks authored
On OpenBSD, Executable relies on Args[0]. Removing the forgery on that OS allows the rest of the test to run. See #19453 Change-Id: Idf99f86894de5c702893791bc3684f8665f4019d Reviewed-on: https://go-review.googlesource.com/46398Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Not a fix but useful for further debugging, and safe. For #18643. Change-Id: I5fb4f4a8662007a26e945fff3986347855f00eab Reviewed-on: https://go-review.googlesource.com/46393 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
- 21 Jun, 2017 6 commits
-
-
Robert Griesemer authored
Fixes #18593. Change-Id: Ibe33ad9b536fee909120b3654b9d831e469eb285 Reviewed-on: https://go-review.googlesource.com/46370Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
David Chase authored
Loops of the form "for i,e := range" needed to have their condition rotated to the "bottom" for the preemptible loops GOEXPERIMENT, but this caused a performance regression because it degraded bounds check removal. For now, make the loop rotation/guarding conditional on the experiment. Fixes #20711. Updates #10958. Change-Id: Icfba14cb3b13a910c349df8f84838cf4d9d20cf6 Reviewed-on: https://go-review.googlesource.com/46410 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
-
Hiroshi Ioka authored
Change-Id: I6265ac81e5c38b201e14ddba2d6b9f0e73d8445c Reviewed-on: https://go-review.googlesource.com/46310Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Alberto Donizetti authored
Change-Id: Ief076151739147378f8ca35cd09aabb59c3c9a52 Reviewed-on: https://go-review.googlesource.com/46350Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Hendricks authored
Executable on OpenBSD now uses Args[0] so procfs is no longer required. Change-Id: I4155ac76f8909499783e876e92ee4f13a35b47dd Reviewed-on: https://go-review.googlesource.com/46211Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Mikio Hara authored
Change-Id: I2d0439a9f068e726173afafe2ef1f5d62b7feb4d Reviewed-on: https://go-review.googlesource.com/46190 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 20 Jun, 2017 9 commits
-
-
John R. Lenton authored
Linux's execve has (at the time of writing, and since v2.6.30) a bug when it ran concurrently with clone, in that it would fail to set up some datastructures if the thread count before and after some steps differed. This is described better and in more detail by Colin King in Launchpad¹ and kernel² bugs. When a program written in Go runtime.Exec's a setuid binary, this issue may cause the resulting process to not have the expected uid. This patch works around the issue by using a mutex to serialize exec and clone. 1. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1672819 2. https://bugzilla.kernel.org/show_bug.cgi?id=195453 Fixes #19546 Change-Id: I126e87d1d9ce3be5ea4ec9c7ffe13f92e087903d Reviewed-on: https://go-review.googlesource.com/43713Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes #19285 Change-Id: I11e864eff9980dec8247c47e4c600f76602e7ada Reviewed-on: https://go-review.googlesource.com/46092Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
I updated my tool to deal with Github-only contributors without Gerrit accounts. The "dep" repo is the main source of these, although there are a few others. Add Alexander Kauer (individual CLA) Add Anders Pearson (individual CLA) Add Brad Whitaker (corporate CLA for Fastly, Inc.) Add Daisuke Fujita (individual CLA) Add Daniel Upton (individual CLA) Add David Volquartz Lebech (individual CLA) Add Emilien Kenler (individual CLA) Add Fazal Majid (corporate CLA for Apsalar) Add Gustav Westling (individual CLA) Add Henry Chang (individual CLA) Add Jianqiao Li (corporate CLA for Google Inc.) Add Jin-wook Jeong (individual CLA) Add Kaleb Elwert (individual CLA) Add Kashav Madan (individual CLA) Add Koki Ide (individual CLA) Add Konstantin (individual CLA) Add Kyle Jones (individual CLA) Add Leon Klingele (individual CLA) Add Martin Olsen (individual CLA) Add Máximo Cuadros Ortiz (individual CLA) Add Miguel Molina (individual CLA) Add Nathaniel Cook (individual CLA) Add Neil Lyons (individual CLA) Add Nick Robinson (individual CLA) Add Niranjan Godbole (individual CLA) Add Oleg Bulatov (individual CLA) Add Oliver Tonnhofer (individual CLA) Add Paul Querna (individual CLA) Add Peter Bourgon (individual CLA) Add Quentin Renard (individual CLA) Add Ray Tung (individual CLA) Add Rob Phoenix (individual CLA) Add Ryan Boehning (individual CLA) Add Sakeven Jiang (individual CLA) Add Stephen Searles (individual CLA) Add Steven Wilkin (individual CLA) Add Sunny (individual CLA) Add Ted Kornish (individual CLA) Add Victor Vrantchan (individual CLA) Add Wander Lairson Costa (individual CLA) Add Zakatell Kanda (individual CLA) Updates #12042 Change-Id: I2e4828cce880965c77b374c1e115d0e437d108c7 Reviewed-on: https://go-review.googlesource.com/46090Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Austin Clements authored
This certainly won't get inlined right now, but in the spirit of making this more robust, we have to disable inlining because inlining would defeat the purpose of separating forkAndExecInChild1 into a separate function. Updates #20732. Change-Id: I736c3f909cc42c5f5783740c2e19ba4827c7c2ec Reviewed-on: https://go-review.googlesource.com/46174 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Austin Clements authored
Currently, CLONE_VFORK is used without much regard to the stack. This is dangerous, because anything the child does to the stack is visible to the parent. For example, if the compiler were to reuse named stack slots (which it currently doesn't do), it would be easy for the child running in the same stack frame as the parent to corrupt local variables that the parent then depended on. We're not sure of anything specific going wrong in this code right now, but it is at best a ticking time bomb. CLONE_VFORK can only safely be used if we ensure the child does not execute in any of the active stack frames of the parent. This commit implements this by arranging for the parent to return immediately from the frame the child will operate in, and for the child to never return to the frame the parent will operate in. Fixes #20732. Change-Id: Iad5b4ddc2b994c082bd278bfd52ef53bd38c037f Reviewed-on: https://go-review.googlesource.com/46173 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Alberto Donizetti authored
This reverts commit 3d13b5e0. Reason for revert: the new TestHttpsInsecure test breaks two darwin builders, the android builders, and one plan9 builder. Change-Id: I09158e7d1bd2b3ffda57e7f2350f34eb9b62e784 Reviewed-on: https://go-review.googlesource.com/46158Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alberto Donizetti authored
Updating to commit fffc5831a499a958516664a34cb7ba2b9e228793 from github.com/google/pprof Fixes #19380 Change-Id: I7a0c64101f42b494c4a469c41628374272eccf95 Reviewed-on: https://go-review.googlesource.com/46155 Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
sam boyer authored
This adds a qualified mention of golang/dep to the FAQ. Fixes #19049 Change-Id: I42a114a008a6ca1250d849872dd98fd6523fa659 Reviewed-on: https://go-review.googlesource.com/46005Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
If you have BenchmarkX1 with sub-benchmark Y and you have BenchmarkX2 with no sub-benchmarks, then go test -bench=X/Y runs BenchmarkX1 once with b.N=1 (to find out about Y) and then not again, because it has sub-benchmarks, but arguably also because we're interested in Y. In contrast, it runs BenchmarkX2 in full, even though clearly that is not relevant to the match X/Y. We do have to run X2 once with b.N=1 to probe for having X2/Y, but we should not run it with larger b.N. Fixes #20589. Change-Id: Ib86907e844f34dcaac6cd05757f57db1019201d0 Reviewed-on: https://go-review.googlesource.com/46031 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
-
- 19 Jun, 2017 4 commits
-
-
Brad Fitzpatrick authored
Updates http2 to x/net/http2 git rev 3d7ac2a5d for: http2: fix Server race https://golang.org/cl/20704 Fixes #20704 Change-Id: I803288f94a8a462ad0960b0c29c2dfee27b9f1ae Reviewed-on: https://go-review.googlesource.com/46093 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Tom Bergan <tombergan@google.com> Reviewed-by: Tom Bergan <tombergan@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Fixes #19544. Change-Id: I5df67383e9471f030ddafabadf2bc19ce6816f0f Reviewed-on: https://go-review.googlesource.com/46002Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Ian Lance Taylor authored
This is a runtime version of sync.RWMutex that can be used by code in the runtime package. The type is not quite the same, in that the zero value is not valid. For future use by CL 43713. Updates #19546 Change-Id: I431eb3688add16ce1274dab97285f555b72735bf Reviewed-on: https://go-review.googlesource.com/45991Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Austin Clements <austin@google.com>
-
Robert Griesemer authored
This doesn't change the existing restriction with disallows spaces in import paths (as found in an import declaration). It simply permits packages to be under a directory name that may contain spaces. Verified manually that it works. This could use a test, but the change is trivial. We also can't use the existing test framework (under test/) because the way those tests are run with test/run.go, the mechanims for compiling a directory, even if it contains blanks it its name, does't produce compiler paths with blanks (the compilation is local). Fixes #20306. Change-Id: I6cbffb86c3394347897c3c94b110da0aadc5bfdf Reviewed-on: https://go-review.googlesource.com/46001Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
- 18 Jun, 2017 1 commit
-
-
konstantin8105 authored
Changed link for cover from x-tools to correct Fix #20662 Change-Id: I9b839ed952e9abb12b3d1655ac4cf5976f374a4b Reviewed-on: https://go-review.googlesource.com/46012Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 17 Jun, 2017 2 commits
-
-
Kashav Madan authored
Change-Id: Ia5c8fcff000bf3d369d42407342c470ea92e18da Reviewed-on: https://go-review.googlesource.com/46006Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
-
Ian Lance Taylor authored
OpenBSD no longer has procfs. Based on a patch by Matthieu Sarter. Fixes #19453. Change-Id: Ia09d16f8a1cbef2f8cc1c5f49e9c61ec7d026a40 Reviewed-on: https://go-review.googlesource.com/46004 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 16 Jun, 2017 1 commit
-
-
Heschi Kreinick authored
Round doesn't always round away from zero. Feel free to suggest better wording. Change-Id: I52b3815013fff4c656ae8d861521c342bc4135b7 Reviewed-on: https://go-review.googlesource.com/46032Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-