An error occurred fetching the project authors.
- 06 Oct, 2015 2 commits
-
-
Joe Tsai authored
Let C be whether c valid Let E be whether err is non-nil The old comment explicitly says that (~C → E). However, that does call into question whether (E → ~C), which causes doubts for users. Without a comment at all, it is obvious that only (E
~C) makes sense. Fixes #11308 Change-Id: I5a7d51ceb509057eccca91f57a7e48c9d1c6d112 Reviewed-on: https://go-review.googlesource.com/15256Reviewed-by:Andrew Gerrand <adg@golang.org>
-
Joe Tsai authored
The later part of the docstring simply talks about "offset" but does not disambiguate what it is relative to. For both the return value and valid offsets to seek to, it only makes sense in the context of "offset relative to origin of file". Fixes #11877 Change-Id: Ic238a407cf8e8fdd64991d98a6584cdc8a51cd6b Reviewed-on: https://go-review.googlesource.com/15257Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
- 29 Jun, 2015 1 commit
-
-
Russ Cox authored
I think this has the same meaning as before, but the text is tighter, and it makes some people happy. Fixes #10182. Change-Id: I7ee1eae4bcd6ee4a5898ea948648939e6bde5f01 Reviewed-on: https://go-review.googlesource.com/11674Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
- 29 May, 2015 1 commit
-
-
David Symonds authored
Change-Id: Iddcd0cfb8f2c2f1c4ad7a94b50a9f65b543862c4 Reviewed-on: https://go-review.googlesource.com/10473Reviewed-by:
Minux Ma <minux@golang.org>
-
- 15 Apr, 2015 1 commit
-
-
Rob Pike authored
This trivial addition to the io package makes it easy to control the buffer size and allocation properties of io.Copy. Change-Id: Ica1a6bd015e429d4e655bc0c6f66cea21c454acf Reviewed-on: https://go-review.googlesource.com/8730Reviewed-by:
Russ Cox <rsc@golang.org>
-
- 08 Apr, 2015 1 commit
-
-
Péter Surányi authored
"returns ... the first error" was misleading or at least confusing: in case a Read results in an error with non-zero bytes read, and the subsequent Write also results in an error, the error from Write is returned, which is the second one (in the temporal dimension). Fixes #9744 Change-Id: If8925a701e4fae820cd9df7446503403fc0785d4 Reviewed-on: https://go-review.googlesource.com/3686Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 16 Sep, 2014 1 commit
-
-
Russ Cox authored
Fixes #8317. LGTM=bradfitz R=bradfitz, iant, r CC=golang-codereviews https://golang.org/cl/143100043
-
- 08 Sep, 2014 1 commit
-
-
Russ Cox authored
Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg.
-
- 26 Aug, 2014 1 commit
-
-
Brad Fitzpatrick authored
There are both many callers and many implementations of these interfaces, so make the contract explicit. Callers generally assume this, and at least the standard library and other implementations obey this, but it's never stated explicitly, making it somewhat risky to assume. LGTM=gri, rsc R=golang-codereviews, gri CC=golang-codereviews, r, rsc https://golang.org/cl/132150043
-
- 16 Apr, 2014 1 commit
-
-
Brad Fitzpatrick authored
Per golang-nuts question. Writing to p breaks other writers (e.g. io.MultiWriter). Make this explicit. LGTM=gri, r, rsc R=r, rsc, gri, joshlf13 CC=golang-codereviews https://golang.org/cl/87780046
-
- 18 Jul, 2013 1 commit
-
-
Brad Fitzpatrick authored
Be consistent with os.File, strings.Reader, bytes.Reader, etc, which all allow seeks past the end. R=golang-dev, r CC=golang-dev https://golang.org/cl/11403043
-
- 23 May, 2013 1 commit
-
-
Daniel Morsing authored
This only affects calls where both ReaderFrom and WriterTo are implemented. WriterTo can issue one large write, while ReaderFrom must Read until EOF, potentially reallocating when out of memory. With one large Write, the Writer only needs to allocate once. This also helps in ioutil.Discard since we can avoid copying memory when the Reader implements WriterTo. R=golang-dev, dsymonds, remyoudompheng, bradfitz CC=golang-dev, minux.ma https://golang.org/cl/9462044
-
- 19 Apr, 2013 1 commit
-
-
Rob Pike authored
Also add a new variable ErrNoProgress that io.Readers can use to report ineffectual Read calls. Fixes #5310. R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/8845043
-
- 09 Apr, 2013 1 commit
-
-
Brad Fitzpatrick authored
R=r, golang-dev CC=golang-dev https://golang.org/cl/8575043
-
- 13 Feb, 2013 1 commit
-
-
Brad Fitzpatrick authored
Changed accidentally in 28966b7b2f0c (CopyN using Copy). Updating docs to be consistent with 29bf5ff5064e (ReadFull & ReadAtLeast) R=rsc CC=golang-dev https://golang.org/cl/7314069
-
- 08 Feb, 2013 1 commit
-
-
Jeremy Schlatter authored
R=golang-dev, dave, minux.ma, bradfitz, rsc CC=golang-dev https://golang.org/cl/7312055
-
- 31 Jan, 2013 1 commit
-
-
Russ Cox authored
This is a backwards compatible API change that fixes broken code. In Go 1.0, ReadFull(r, buf) could return either len(buf), nil or len(buf), non-nil. Most code expects only the former, so do that and document the guarantee. Code that was correct before is still correct. Code that was incorrect before, by assuming the guarantee, is now correct too. The same applies to ReadAtLeast. Fixes #4544. R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/7235074
-
- 13 Dec, 2012 1 commit
-
-
Shenghou Ma authored
Fixes #4392. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6858062
-
- 30 Oct, 2012 1 commit
-
-
Brad Fitzpatrick authored
API change. R=golang-dev, dsymonds, nigeltao, rsc, r CC=golang-dev https://golang.org/cl/6760045
-
- 08 Aug, 2012 1 commit
-
-
Andrew Gerrand authored
R=r CC=golang-dev https://golang.org/cl/6458097
-
- 07 Aug, 2012 1 commit
-
-
Brad Fitzpatrick authored
Fixes #3711 R=golang-dev, adg CC=golang-dev https://golang.org/cl/6445083
-
- 08 Mar, 2012 1 commit
-
-
Francisco Souza authored
R=adg, bradfitz CC=golang-dev https://golang.org/cl/5787048
-
- 07 Mar, 2012 1 commit
-
-
Brad Fitzpatrick authored
Updates #1599 R=golang-dev, gri, rsc CC=golang-dev https://golang.org/cl/5774043
-
- 01 Mar, 2012 1 commit
-
-
Rob Pike authored
Updates #1599. R=golang-dev, bradfitz, rsc, r CC=golang-dev https://golang.org/cl/5708056
-
- 29 Feb, 2012 1 commit
-
-
Rob Pike authored
Updates #1599. R=golang-dev, adg, dsymonds CC=golang-dev https://golang.org/cl/5704052
-
- 06 Feb, 2012 1 commit
-
-
Rob Pike authored
- eliminate local Error type (a historical artifact) - fix documentation of CopyN - fix documentation of WriteString Fixes #2859. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/5636046
-
- 02 Nov, 2011 1 commit
-
-
Russ Cox authored
R=r, r CC=golang-dev https://golang.org/cl/5311068
-
- 26 Oct, 2011 1 commit
-
-
Russ Cox authored
ReadRune, WriteRune change signature. R=golang-dev, gri, r CC=golang-dev https://golang.org/cl/5314043
-
- 30 Sep, 2011 1 commit
-
-
David Symonds authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5157045
-
- 26 Aug, 2011 1 commit
-
-
Hector Chu authored
TeeReader is a Reader that writes what it reads. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4953041
-
- 28 Jun, 2011 1 commit
-
-
Evan Shaw authored
This avoids allocation when writing to bytes.Buffers and bufio.Writers, for example. R=golang-dev, rsc, r, consalus, r CC=golang-dev https://golang.org/cl/4625068
-
- 22 Jun, 2011 2 commits
-
-
Russ Cox authored
R=golang-dev, bradfitz, iant, dsymonds, nigeltao, r CC=golang-dev https://golang.org/cl/4629062
-
Robert Griesemer authored
This is a core API change. 1) gofix misc src 2) Manual adjustments to the following files under src/pkg: gob/decode.go rpc/client.go os/error.go io/io.go bufio/bufio.go http/request.go websocket/client.go as well as: src/cmd/gofix/testdata/*.go.in (reverted) test/fixedbugs/bug243.go 3) Implemented gofix patch (oserrorstring.go) and test case (oserrorstring_test.go) Compiles and runs all tests. R=r, rsc, gri CC=golang-dev https://golang.org/cl/4607052
-
- 26 May, 2011 1 commit
-
-
Robert Griesemer authored
R=r, rsc CC=golang-dev https://golang.org/cl/4530069
-
- 25 May, 2011 1 commit
-
-
Brad Fitzpatrick authored
Speeds up static fileserver, avoiding kernel/userspace copies. Numbers: downloading 14 MB AppEngine Go SDK with ab (Apache Bench) with 5 threads: Before/after numbers: CPU: user 0m3.910s sys 0m23.650s -> user 0m0.720s sys 0m4.890s Time taken for tests: 8.906 seconds -> Time taken for tests: 8.545 seconds Percentage of the requests served within a certain time (ms) 50% 44 66% 45 75% 46 80% 46 90% 48 95% 51 98% 59 99% 71 100 74 (longest request) -> 50% 42 66% 43 75% 43 80% 44 90% 46 95% 57 98% 62 99% 63 100% 64 (longest request) R=iant, gary.burd, rsc, bradfitz CC=golang-dev https://golang.org/cl/4543071
-
- 19 Apr, 2011 1 commit
-
-
Nigel Tao authored
R=rsc CC=golang-dev https://golang.org/cl/4442064
-
- 13 Apr, 2011 1 commit
-
-
Brad Fitzpatrick authored
R=r, mkrautz, r2, rsc CC=golang-dev https://golang.org/cl/4415041
-
- 08 Apr, 2011 1 commit
-
-
Robert Hencke authored
R=rsc CC=golang-dev https://golang.org/cl/4271080
-
- 02 Feb, 2011 2 commits
-
-
Robert Griesemer authored
ReadByter -> ByteReader ReadRuner -> RuneReader R=r, r2, rsc CC=golang-dev https://golang.org/cl/4023062
-
Rob Pike authored
Put it in the same package as ReadByter. There is no implementation here for either interface. R=rsc CC=golang-dev https://golang.org/cl/4121051
-