- 15 Jul, 2017 21 commits
-
-
Iccha Sethi authored
The existing example for Decoder.Decode (Stream) had excessive indentation in the godoc interface for the const jsonStream, making it hard to read. This fixes the indentation in the example_test.go to improve the readability in godoc. Helps #21026. Change-Id: I16f56b82182da1dcc73cca44e535a7f5695e975d Reviewed-on: https://go-review.googlesource.com/48910Reviewed-by:
Dmitri Shuralyov <shurcool@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ross Light authored
Change-Id: Iec9a7bf61566ee08c4d15adb39d43c7a29c79122 Reviewed-on: https://go-review.googlesource.com/48962Reviewed-by:
-
Francisco Rojas authored
Change-Id: I9c0c601ec5957475e949dcc4a8c2116724d01215 Reviewed-on: https://go-review.googlesource.com/48961Reviewed-by:
-
Johnny Luo authored
It had been implemented. Refer to https://golang.org/pkg/archive/zip/#FileHeader.Comment Change-Id: I81572562c3111b58189baa3510b9ba688fe269c9 Reviewed-on: https://go-review.googlesource.com/48857Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Josh Roppo authored
Change-Id: I5ca5a6689f0679154c24820466f5cf0011d0aaa6 Reviewed-on: https://go-review.googlesource.com/48959Reviewed-by:
-
Daniel Morsing authored
kicking off contributing again with a classic Change-Id: Ifb0aed8f1dc854f85751ce0495967a3c4315128d Reviewed-on: https://go-review.googlesource.com/49016Reviewed-by:
-
Pat Moroney authored
Change-Id: I5c32a968303848304cbd6fe1e83bed0af11f6440 Reviewed-on: https://go-review.googlesource.com/48960Reviewed-by:
Caleb Spare <cespare@gmail.com> Reviewed-by:
-
Francisco Rojas authored
Add a example for string.Compare that return the three possible results. Change-Id: I103cf39327c1868fb249538d9e22b11865ba4b70 Reviewed-on: https://go-review.googlesource.com/49011Reviewed-by:
Heschi Kreinick <heschi@google.com>
-
Ivan Moscoso authored
Clarifying that FindString only provides left-most match Change-Id: Ic6ecec12cca759fd4b3565ef5901a110843ffd56 Reviewed-on: https://go-review.googlesource.com/48609Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Pablo Santiago Blum de Aguiar authored
Change-Id: Ib6a59735381ce744553f1ac96eeb65a194c8da10 Reviewed-on: https://go-review.googlesource.com/48860Reviewed-by:
-
Aditya Mukerjee authored
Change-Id: I52efa7aa72a23256e5ca56470ffeba975ed8f739 Reviewed-on: https://go-review.googlesource.com/48760Reviewed-by:
Bryan Mills <bcmills@google.com>
-
Evan Hicks authored
Change-Id: I69d1359d8868d4c5b173e4d831e38cea7dfeb713 Reviewed-on: https://go-review.googlesource.com/48859Reviewed-by:
-
Martynas Budriūnas authored
Change-Id: I259e25b9d0b069912053a250e9739e04fafca54d Reviewed-on: https://go-review.googlesource.com/48892 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Adam Kisala authored
Change-Id: Ibdd57489543d57a24d1e3c41210abd9fbc930b8f Reviewed-on: https://go-review.googlesource.com/48867Reviewed-by:
-
Greg Poirier authored
While there's an example for SectionReader.Seek, if someone is seeking documentation specifically about Seeker.Seek, they may not immediately find the SectionReader example. Offset and whence may not be entirely intuitive to new developers either, so include examples of both positive/negative offsets and SeekStart/SeekEnd. Change-Id: I5b7442ccf683d9706e9261c11bc0ea31a1ac21d4 Reviewed-on: https://go-review.googlesource.com/48873Reviewed-by:
Kevin Burke <kev@inburke.com> Reviewed-by:
-
Jamie Kerr authored
Change-Id: If581bd4e9d9b4421e2ae20582c596fccb73d9aed Reviewed-on: https://go-review.googlesource.com/48866Reviewed-by:
-
Kate Manson authored
Change-Id: I994f003c97a14d194df5f07dd217c0ff3b214741 Reviewed-on: https://go-review.googlesource.com/48874Reviewed-by:
Matt Layher <mdlayher@gmail.com> Run-TryBot: Matt Layher <mdlayher@gmail.com>
-
Taro Aoki authored
The existing example for FileMode using Stat to get FileInfo. But, Stat cannot get symlink info, it need to use Fstat instead. Change-Id: I5cc38cd10caaa5912946abe2a2b90995a91ee10f Reviewed-on: https://go-review.googlesource.com/47370Reviewed-by:
-
Ian Lance Taylor authored
Fails on iOS because CC_FOR_TARGET points to clangwrap.sh in the original GOROOT. We could fix that but it doesn't seem worth it. Fails on Android with "exec format error". I'm not sure why but I doubt it is interesting. Fails on Plan 9 because the original GOROOT is being preserved in some unknown way. This is issue #21016. Updates #21016 Change-Id: I4e7115d734fc7bf21e5a2ba18fb6ad0bfa31c735 Reviewed-on: https://go-review.googlesource.com/48650 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
David du Colombier <0intro@gmail.com> Reviewed-by:
Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
mapeiqi authored
I just want to experience the whole Gerrit Flow, so I make this simple commit as my first commit to golang src repo. Change-Id: Ie744573beac7a8b9361f898fac269c9d88010493 Reviewed-on: https://go-review.googlesource.com/48630Reviewed-by:
Ma Peiqi <mapeiqi2017@gmail.com> Reviewed-by:
-
Ian Lance Taylor authored
When StructOf is used with an anonymous field that has methods, and that anonymous field is not the first field, the methods we generate are incorrect because they do not offset to the field as required. If we encounter that case, panic rather than doing the wrong thing. Fixes #20824 Updates #15924 Change-Id: I3b0901ddbc6d58af5f7e84660b5e3085a431035d Reviewed-on: https://go-review.googlesource.com/47035 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 14 Jul, 2017 8 commits
-
-
Brad Fitzpatrick authored
Updates #18997 Change-Id: Ib1961a4c26b42f99b98b255beb7e2a74b632e0c1 Reviewed-on: https://go-review.googlesource.com/48551Reviewed-by:
Joe Shaw <joe@joeshaw.org> Reviewed-by:
Tom Bergan <tombergan@google.com>
-
Han-Wen Nienhuys authored
Neither the Gerrit UI nor its docs use the term CL or changelist. Change-Id: Ic19fddc660ec4f008f10fd207e4ac6349431ff5d Reviewed-on: https://go-review.googlesource.com/48595Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #17206 Change-Id: Id0ebc3a55ea1c5f52608decffee04c8398a8774b Reviewed-on: https://go-review.googlesource.com/48571 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
This is necessary to make a relocated GOROOT work correctly. Fixes #20997 Change-Id: I18624bd2e109721066cd9e4a887a12583ab79f5d Reviewed-on: https://go-review.googlesource.com/48550 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Nathaniel Caza authored
The current implementation ignores certificates that exist in the login and System keychains. This change adds the missing System and login keychain files to the `/usr/bin/security` command in `execSecurityRoots`. If the current user cannot be obtained, the login keychain is ignored. Refs #16532 Change-Id: I8594a6b8940c58df8a8015b274fa45c39e18862c Reviewed-on: https://go-review.googlesource.com/36941 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Samuel Tan authored
The escaper contains information about which templates have already been visited and escaped. This information is necessary to prevent templates that have already been escaped from being over-escaped. However, since we currently create a new escaper each time we execute a template, this information does not persist across multiple template executions. Fix this by saving an escaper in each template name space which is shared by all templates in that name space. While there, fix error message formatting for an escaping unit test. Fixes #20842 Change-Id: Ie392c3e7ce0e0a9947bdf56c99e926e7c7db76e4 Reviewed-on: https://go-review.googlesource.com/47256Reviewed-by:
Mike Samuel <mikesamuel@gmail.com> Reviewed-by:
-
David Chase authored
Previous code failed to account for particular control flow involving nested loops when updating phi function inputs. Fix involves: 1) remove incorrect shortcut 2) generate a "better" order for children in dominator tree 3) note inner-loop updates and check before applying outer-loop updates. Fixes #20675. Change-Id: I2fe21470604b5c259e777ad8b15de95f7706894d Reviewed-on: https://go-review.googlesource.com/45791 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Ian Lance Taylor authored
If we get an EAGAIN error on an unpollable file, don't try to wait for it to be ready; just return EAGAIN. It's possible that we should instead ensure that when Stdin is a pipe in non-blocking mode, we wait for data to appear. For now take the conservative approach of doing what we did in previous releases. Based on https://golang.org/cl/47555 by Totoro W. Fixes #20915 Change-Id: Icc9e97a5a877b0a3583ec056c35412d1afab62d1 Reviewed-on: https://go-review.googlesource.com/48490 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 13 Jul, 2017 4 commits
-
-
Kevin Burke authored
Change-Id: I73fdc793bbc3ffe9ace1bfa78799f84c31630d61 Reviewed-on: https://go-review.googlesource.com/48391Reviewed-by:
-
Austin Clements authored
Change-Id: If9f64fbb78009921e8773124e4e5eb8a871095a5 Reviewed-on: https://go-review.googlesource.com/48192Reviewed-by:
Michael Matloob <matloob@golang.org>
-
Ian Lance Taylor authored
CL 44352 changed the behavior of SIGINT, which can break tests that themselves use SIGINT. I think we can only implement this if the testing package has a way to know whether the code under test is using SIGINT, but os/signal does not provide an API for that. Roll back for 1.9 and think about this again for 1.10. Updates #19397 Change-Id: I021c314db2b9d0a80d0088b120a6ade685459990 Reviewed-on: https://go-review.googlesource.com/48370 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
It seems that when too much other code is running on the system, the testprogcgo code can overrun its timeouts. Updates #18598. Not marking the issue as fixed until it doesn't recur for some time. Change-Id: Ieaf106b41986fdda76b1d027bb9d5e3fb805cc3b Reviewed-on: https://go-review.googlesource.com/48233 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
- 12 Jul, 2017 4 commits
-
-
Brad Fitzpatrick authored
Usually this test is skipped (on builders and when not root), so people are unlikely to see this error. Updates #19296 Change-Id: I3acb81260034dad8776c305f83d7cbac4b718e75 Reviewed-on: https://go-review.googlesource.com/48191 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #20948 Change-Id: I222bf101a5c1bdc5cbb0970949070c4b58b9b83b Reviewed-on: https://go-review.googlesource.com/48190Reviewed-by:
-
Austin Clements authored
SysV semaphore undo lists should be shared by threads, just like several other resources listed in cloneFlags. Currently we don't do this, but it probably doesn't affect anything because 1) probably nobody uses SysV semaphores from Go and 2) Go-created threads never exit until the process does. Beyond being the right thing to do, user-level QEMU requires this flag because it depends on glibc to create new threads and glibc uses this flag. Fixes #20763. Change-Id: I1d1dafec53ed87e0f4d4d432b945e8e68bb72dcd Reviewed-on: https://go-review.googlesource.com/48170 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
To-be-released NetBSD 7.1.1 reportedly fixes the kernel panic that was affecting our builders and is being released because of Go's warning. So, soften our warning. 7.1.1 might work, but I can't get a builder up and running to verify yet as it appears that Anita either doesn't support it yet, or the NetBSD CDN doesn't have the files yet. Change-Id: Ifaafc566879a6afdf1174e545ad10e240da427e8 Reviewed-on: https://go-review.googlesource.com/47970Reviewed-by:
-
- 11 Jul, 2017 3 commits
-
-
Austin Clements authored
TestStackGrowth is currently a parallel test. However, it depends on a 20 second timeout, which is already dubious in a parallel test, and became really problematic on slow builders when runtime.GC switched to triggering concurrent GC instead of STW GC. Before that change, the test spent much of its time in STW GC, so it wasn't *really* parallel. After that change, it was competing with all of the other parallel tests and GC likely started taking ~4 times longer. On most builders the whole test runs in well under a second, but on the slow builders that was enough to push it over the 20 second timeout. Fix this by making the test serial. Updates #19381 (probably fixes it, but we'll have to wait and see). Change-Id: I21af7cf543ab07f1ec1c930bfcb355b0df75672d Reviewed-on: https://go-review.googlesource.com/48110 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Austin Clements authored
Local variables can also be relied on the be 64-bit aligned, since they will be escaped to the heap if used with any atomic operations. Also, allocated arrays are also aligned, just like structs and slices. Fixes #18955. Change-Id: I8a1897f6ff78922c8bfcf20d6eb4bcb17a70ba2d Reviewed-on: https://go-review.googlesource.com/48112Reviewed-by:
-
Costin Chirvasuta authored
The current description refers to the outermost "frame" which can be misleading. A user reading it can think it means a stack frame. Change-Id: Ie2c7cb4b4db8f41572df206478ce3b46a0245a5d Reviewed-on: https://go-review.googlesource.com/47850Reviewed-by:
Austin Clements <austin@google.com>
-
