An error occurred fetching the project authors.
  1. 23 Oct, 2018 1 commit
  2. 10 Feb, 2017 1 commit
    • Heschi Kreinick's avatar
      cmd/trace: Record mark assists in execution traces · 2a74b9e8
      Heschi Kreinick authored
      During the mark phase of garbage collection, goroutines that allocate
      may be recruited to assist. This change creates trace events for mark
      assists and displays them similarly to sweep assists in the trace
      viewer.
      
      Mark assists are different than sweeps in that they can be preempted, so
      displaying them in the trace viewer is a little tricky -- we may need to
      synthesize multiple slices for one mark assist. This could have been
      done in the parser instead, but I thought it might be preferable to keep
      the parser as true to the event stream as possible.
      
      Change-Id: I381dcb1027a187a354b1858537851fa68a620ea7
      Reviewed-on: https://go-review.googlesource.com/36015
      Run-TryBot: Heschi Kreinick <heschi@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAustin Clements <austin@google.com>
      Reviewed-by: default avatarHyang-Ah Hana Kim <hyangah@gmail.com>
      2a74b9e8
  3. 11 Oct, 2016 1 commit
    • Hyang-Ah (Hana) Kim's avatar
      cmd/trace: fix a runnable goroutine count bug · c24cc400
      Hyang-Ah (Hana) Kim authored
      When starting tracing, EvGoCreate events are added for existing
      goroutines that may have been blocking in syscall. EvGoCreate
      increments the runnable goroutine count. This change makes the
      following EvGoInSyscall event decrement the runnable goroutine count
      because we now know that goroutine is in syscall, and not runnable.
      
      Made generateTrace return an error, at any given time, the number
      of runnable/running/insyscall goroutines becomes non-negative.
      
      Added a basic test that checks the number of runnable/running
      goroutines don't include the goroutines in syscall - the test failed
      before this change.
      
      Change-Id: Ib732c382e7bd17158a437576f9d589ab89097ce6
      Reviewed-on: https://go-review.googlesource.com/25552
      Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
      c24cc400