Commits · de7ee57c7ead59899d5b412a839c995de0e813b5 · Kirill Smelkov / go

10 Apr, 2016 3 commits

Marvin Stenger authored Apr 08, 2016

Replace calls to bio.Bread with calls to io.ReadFull.

Change-Id: I2ee8739d01e04a4da9c20b6ce7d1d5b89914b8ad
Reviewed-on: https://go-review.googlesource.com/21750Reviewed-by: Dave Cheney <dave@cheney.net>

de7ee57c

runtime: make execution error panic values implement the Error interface · e4f1d9cf

Emmanuel Odeke authored Mar 27, 2016

Make execution panics implement Error as
mandated by https://golang.org/ref/spec#Run_time_panics,
instead of panics with strings.

Fixes #14965

Change-Id: I7827f898b9b9c08af541db922cc24fa0800ff18a
Reviewed-on: https://go-review.googlesource.com/21214Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e4f1d9cf

cmd/go: fix typo in findInternal documentation · 824d8c10

Wisdom Omuya authored Apr 09, 2016

Fixes #15217

Change-Id: Ib8f7af714197fd209e743f61f28a5b07c04a7f5c
Reviewed-on: https://go-review.googlesource.com/21793Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

824d8c10

09 Apr, 2016 8 commits

net/http/httputil: DumpRequest dumps Content-Length if set in header · 3598d4b8

Emmanuel Odeke authored Apr 09, 2016

Fixes #7215

Change-Id: I108171ef18cac66d0dc11ce3553c26fc49529807
Reviewed-on: https://go-review.googlesource.com/21790Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

3598d4b8

cmd/go: fix typo in comment · c31fdd4e

Brad Fitzpatrick authored Apr 09, 2016

Thanks to deafgoat.

Fixes #15215

Change-Id: I9fababc7ecd201ce86020a438e4faee95e7623a8
Reviewed-on: https://go-review.googlesource.com/21792Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

c31fdd4e

runtime: revert "do not call timeBeginPeriod on windows" · 0435e88a

Dmitry Vyukov authored Mar 18, 2016

This reverts commit ab4c9298.

Sysmon critically depends on system timer resolution for retaking
of Ps blocked in system calls. See #14790 for an example
of a program where execution time goes from 2ms to 30ms if
timeBeginPeriod(1) is not used.

We can remove timeBeginPeriod(1) when we support UMS (#7876).

Update #14790

Change-Id: I362b56154359b2c52d47f9f2468fe012b481cf6d
Reviewed-on: https://go-review.googlesource.com/20834Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

0435e88a

cmd/internal/bio: move Bgetc to link/internal/ld · 9d4efdfd

Dave Cheney authored Apr 08, 2016

Also, remove bio.Brdline.

Change-Id: I3e0caed27a373fd71737cf6892de5e8fc208b776
Reviewed-on: https://go-review.googlesource.com/21783Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dave Cheney <dave@cheney.net>

9d4efdfd

cmd: remove unused code · bce9747e

Dave Cheney authored Apr 09, 2016

Generated with honnef.co/go/unused

There is a large amount of unused code in cmd/internal/obj/s390x but
that can wait til the s390x port is merged.

There is some unused code in
cmd/internal/unvendor/golang.org/x/arch/arm/armasm but that should be
addressed upstream and a new revision imported.

Change-Id: I252c0f9ea8c5bb1a0b530a374ef13a0a20ea56aa
Reviewed-on: https://go-review.googlesource.com/21782Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dave Cheney <dave@cheney.net>

bce9747e

cmd/internal/bio: embed bufio.{Reader,Writer} in bio.{Reader,Writer} · 93368be6

Dave Cheney authored Apr 08, 2016

Change-Id: Ie95b0b0d4f724f4769cf2d4f8063cb5019fa9bc9
Reviewed-on: https://go-review.googlesource.com/21781Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

93368be6

cmd: remove bio.BufReader and bio.BufWriter · ca397bb6

Dave Cheney authored Apr 08, 2016

bio.BufReader was never used.

bio.BufWriter was used to wrap an existing io.Writer, but the
bio.Writer returned would not be seekable, so replace all occurences
with bufio.Reader instead.

Change-Id: I9c6779e35c63178aa4e104c17bb5bb8b52de0359
Reviewed-on: https://go-review.googlesource.com/21722Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

ca397bb6

cmd/link/internal: make ld.Bso a *bio.Writer · 6fee4aa5

Dave Cheney authored Apr 09, 2016

This is a pre requesite of CL 21722 and removes a lot of unidiomatic
boilerplate in the linker.

Change-Id: If7491b88212b2be7b0c8c588e9c196839131f8ad
Reviewed-on: https://go-review.googlesource.com/21780
Run-TryBot: Dave Cheney <dave@cheney.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

6fee4aa5

08 Apr, 2016 15 commits

cmd/cgo: fix cgo with gccgo · 092ef8a2

Michael Hudson-Doyle authored Apr 08, 2016

Change-Id: I1780899255e22c16d7f8e9947609a1c284d7c42e
Reviewed-on: https://go-review.googlesource.com/21690Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

092ef8a2

cmd/compile: insert instrumentation more carefully in racewalk · c3b3e7b4

David Chase authored Apr 08, 2016

Be more careful about inserting instrumentation in racewalk.
If the node being instrumented is an OAS, and it has a non-
empty Ninit, then append instrumentation to the Ninit list
rather than letting it be inserted before the OAS (and the
compilation of its init list).  This deals with the case that
the Ninit list defines a variable used in the RHS of the OAS.

Fixes #15091.

Change-Id: Iac91696d9104d07f0bf1bd3499bbf56b2e1ef073
Reviewed-on: https://go-review.googlesource.com/21771Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: David Chase <drchase@google.com>

c3b3e7b4

runtime: emit file:line info into traces · 0fb7b4cc

Dmitry Vyukov authored Apr 08, 2016

This makes traces self-contained and simplifies trace workflow
in modern cloud environments where it is simpler to reach
a service via HTTP than to obtain the binary.

Change-Id: I6ff3ca694dc698270f1e29da37d5efaf4e843a0d
Reviewed-on: https://go-review.googlesource.com/21732
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

0fb7b4cc

cmd/cgo: increase s390x int type size to 8 bytes · 9ada88ae

Michael Munday authored Apr 08, 2016

The size of the int type in Go on s390x is 8 bytes, not 4.

Change-Id: I1a71ce8c9925f3499abb61c1aa4f6fa2d2ec0d7e
Reviewed-on: https://go-review.googlesource.com/21760Reviewed-by: Bill O'Farrell <billotosyr@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

9ada88ae

bytes: add ContainsRune · 59af53d6

Emmanuel Odeke authored Apr 07, 2016

Make package bytes consistent with strings
by adding missing function ContainsRune.

Fixes #15189

Change-Id: Ie09080b389e55bbe070c57aa3bd134053a805423
Reviewed-on: https://go-review.googlesource.com/21710
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

59af53d6

syscall: add assembly for Linux on s390x · 6c5352f1

Michael Munday authored Apr 08, 2016

Change-Id: I42ade65a91f3effc03dd663ee449410baa9f8ca8
Reviewed-on: https://go-review.googlesource.com/21740Reviewed-by: Bill O'Farrell <billotosyr@gmail.com>
Reviewed-by: Minux Ma <minux@golang.org>
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

6c5352f1

context: disable more flaky tests on openbsd · 59d18683

Brad Fitzpatrick authored Apr 08, 2016

Updates #15158

Change-Id: Icb3788152a7a5a9b0d56ea38da46d770ffdce413
Reviewed-on: https://go-review.googlesource.com/21763
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>

59d18683

test: skip nilptr3 test on s390x · dae98d5c

Michael Munday authored Mar 20, 2016

Fails for the same reason as ppc64 and mips64 (incomplete
optimization).

Change-Id: Ieb4d997fc27d4f2b756e63dd7f588abe10c0213a
Reviewed-on: https://go-review.googlesource.com/20963Reviewed-by: Bill O'Farrell <billotosyr@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

dae98d5c

cmd/link: add s390x to link tool main function · 78715ceb

Michael Munday authored Apr 08, 2016

Change-Id: I83bc2b4a00216b069f133113e4ae9ad76c98a708
Reviewed-on: https://go-review.googlesource.com/21741
Run-TryBot: Michael Munday <munday@ca.ibm.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

78715ceb

io: change the name of ReadAtSizer to SizedReaderAt · 01360a64

Rob Pike authored Apr 06, 2016

This is a proposal. The old name is pretty poor. The new one describes
it better and may be easier to remember. It does not start with Read,
though I think that inconsistency is worthwhile.

Reworded the comment a bit for clarity.

Change-Id: Icb4f9c663cc68958e0363d7ff78a0b29cc521f98
Reviewed-on: https://go-review.googlesource.com/21629Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

01360a64

cmd: replace bio.Buf with bio.Reader and bio.Writer · 8f2edf11

Dave Cheney authored Apr 08, 2016

Replace the bidirectional bio.Buf type with a pair of unidirectional
buffered seekable Reader and Writers.

Change-Id: I86664a06f93c94595dc67c2cbd21356feb6680ef
Reviewed-on: https://go-review.googlesource.com/21720Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

8f2edf11

cmd/compile: cleanup -dynlink/-shared support check · d22357ce

Michael Munday authored Apr 07, 2016

Moves the list of architectures that support shared libraries into
a function. Also adds s390x to that list.

Change-Id: I99c8a9f6cd4816ce3d53abaabaf8d002e25e6b28
Reviewed-on: https://go-review.googlesource.com/21661Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
Run-TryBot: Michael Munday <munday@ca.ibm.com>

d22357ce

cmd/compile/internal/gc: unexport Export · 49e07f2b

Dave Cheney authored Apr 08, 2016

Export does not need to be exported.

Change-Id: I252f0c024732f1d056817cab13e8e3c589b54d13
Reviewed-on: https://go-review.googlesource.com/21721
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

49e07f2b

cmd/go: fix failing tests since vet was moved from x/tools · 4dae828f

Andrew Gerrand authored Apr 08, 2016

Change-Id: I3276a118ced78f3efd8f1bc5fb8b8fa2fde52496
Reviewed-on: https://go-review.googlesource.com/21704Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

4dae828f

net/http: fixed trivial go vet warnings · 853f1a1a

Emmanuel Odeke authored Apr 07, 2016

Updates #15177

Change-Id: I748f025461f313b5b426821ead695f90d3011a6b
Reviewed-on: https://go-review.googlesource.com/21677Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

853f1a1a

07 Apr, 2016 14 commits

cmd/compile: Fix constant-folding of unsigned shifts · 68ac1f77

Keith Randall authored Apr 07, 2016

Make sure the results of unsigned constant-folded
shifts are sign-extended into the AuxInt field.

Fixes #15175

Change-Id: I3490d1bc3d9b2e1578ed30964645508577894f58
Reviewed-on: https://go-review.googlesource.com/21586Reviewed-by: Alexandru Moșoi <alexandru@mosoi.ro>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

68ac1f77

cmd/go: revise importPath when ImportPath is 'command-line-arguments' · dfded578

Cheng-Lung Sung authored Apr 06, 2016

Fixes #14613

Change-Id: I40d9696db3879549e78373ef17f6c92bd4b3470b
Reviewed-on: https://go-review.googlesource.com/21596Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

dfded578

bytes, string: add Reset method to Reader · e88f8902

Joe Tsai authored Mar 31, 2016

Currently, there is no easy allocation-free way to turn a
[]byte or string into an io.Reader. Thus, we add a Reset method
to bytes.Reader and strings.Reader to allow the reuse of these
Readers with another []byte or string.

This is consistent with the fact that many standard library io.Readers
already support a Reset method of some type:
	bufio.Reader
	flate.Reader
	gzip.Reader
	zlib.Reader
	debug/dwarf.LineReader
	bytes.Buffer
	crypto/rc4.Cipher

Fixes #15033

Change-Id: I456fd1af77af6ef0b4ac6228b058ac1458ff3d19
Reviewed-on: https://go-review.googlesource.com/21386Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e88f8902

runtime: add s390x support (new files and lfstack_64bit.go modifications) · e6f36f0c

Michael Munday authored Mar 18, 2016

Change-Id: I51c0a332e3cbdab348564e5dcd27583e75e4b881
Reviewed-on: https://go-review.googlesource.com/20946Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e6f36f0c

cmd/link: hide go.dwarf symbols · 9658b7ef

David Crawshaw authored Apr 07, 2016

Fixes #15179

Change-Id: I0f70b7ae1682eafaece7f22d8e76f0aa806f3ec9
Reviewed-on: https://go-review.googlesource.com/21589
Run-TryBot: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

9658b7ef

cmd/link: disable DWARF when not generating symtab · e6181eb9

David Crawshaw authored Apr 07, 2016

Fixes #15166

Change-Id: I30284e3c0fb2c80b26a2572e2fb249b8018e85f9
Reviewed-on: https://go-review.googlesource.com/21587
Run-TryBot: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e6181eb9

C: fix jbd's identity · 39f1ecd1

Burcu Dogan authored Apr 07, 2016

Change-Id: Ib4353710a742b1067723c7c6186e8639559668a3
Reviewed-on: https://go-review.googlesource.com/21655Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

39f1ecd1

context: mark more tests as flaky on OpenBSD · e2c09749

Brad Fitzpatrick authored Apr 07, 2016

Updates #15158

Change-Id: I53e9e68d36efbf52736822e6caa047cfff501283
Reviewed-on: https://go-review.googlesource.com/21653Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e2c09749

math/big: re-use memory in Int.GCD · 187afdeb

Aliaksandr Valialkin authored Apr 04, 2016

This improves TLS handshake performance.

benchmark old ns/op new ns/op delta
BenchmarkGCD10x10/WithoutXY-4 965 968 +0.31%
BenchmarkGCD10x10/WithXY-4 1813 1391 -23.28%
BenchmarkGCD10x100/WithoutXY-4 1093 1075 -1.65%
BenchmarkGCD10x100/WithXY-4 2348 1676 -28.62%
BenchmarkGCD10x1000/WithoutXY-4 1569 1565 -0.25%
BenchmarkGCD10x1000/WithXY-4 4262 3242 -23.93%
BenchmarkGCD10x10000/WithoutXY-4 6069 6066 -0.05%
BenchmarkGCD10x10000/WithXY-4 12123 11331 -6.53%
BenchmarkGCD10x100000/WithoutXY-4 52664 52610 -0.10%
BenchmarkGCD10x100000/WithXY-4 97494 95649 -1.89%
BenchmarkGCD100x100/WithoutXY-4 5244 5228 -0.31%
BenchmarkGCD100x100/WithXY-4 22572 18630 -17.46%
BenchmarkGCD100x1000/WithoutXY-4 6143 6233 +1.47%
BenchmarkGCD100x1000/WithXY-4 24652 19357 -21.48%
BenchmarkGCD100x10000/WithoutXY-4 15725 15804 +0.50%
BenchmarkGCD100x10000/WithXY-4 60552 55973 -7.56%
BenchmarkGCD100x100000/WithoutXY-4 107008 107853 +0.79%
BenchmarkGCD100x100000/WithXY-4 349597 340994 -2.46%
BenchmarkGCD1000x1000/WithoutXY-4 63785 64434 +1.02%
BenchmarkGCD1000x1000/WithXY-4 373186 334035 -10.49%
BenchmarkGCD1000x10000/WithoutXY-4 78038 78241 +0.26%
BenchmarkGCD1000x10000/WithXY-4 543692 507034 -6.74%
BenchmarkGCD1000x100000/WithoutXY-4 205607 207727 +1.03%
BenchmarkGCD1000x100000/WithXY-4 2488113 2415323 -2.93%
BenchmarkGCD10000x10000/WithoutXY-4 1731340 1714992 -0.94%
BenchmarkGCD10000x10000/WithXY-4 10601046 7111329 -32.92%
BenchmarkGCD10000x100000/WithoutXY-4 2239155 2212173 -1.21%
BenchmarkGCD10000x100000/WithXY-4 30097040 26538887 -11.82%
BenchmarkGCD100000x100000/WithoutXY-4 119845326 119863916 +0.02%
BenchmarkGCD100000x100000/WithXY-4 768006543 426795966 -44.43%

benchmark old allocs new allocs delta
BenchmarkGCD10x10/WithoutXY-4 5 5 +0.00%
BenchmarkGCD10x10/WithXY-4 17 9 -47.06%
BenchmarkGCD10x100/WithoutXY-4 6 6 +0.00%
BenchmarkGCD10x100/WithXY-4 21 9 -57.14%
BenchmarkGCD10x1000/WithoutXY-4 6 6 +0.00%
BenchmarkGCD10x1000/WithXY-4 30 12 -60.00%
BenchmarkGCD10x10000/WithoutXY-4 6 6 +0.00%
BenchmarkGCD10x10000/WithXY-4 26 12 -53.85%
BenchmarkGCD10x100000/WithoutXY-4 6 6 +0.00%
BenchmarkGCD10x100000/WithXY-4 28 12 -57.14%
BenchmarkGCD100x100/WithoutXY-4 5 5 +0.00%
BenchmarkGCD100x100/WithXY-4 183 61 -66.67%
BenchmarkGCD100x1000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD100x1000/WithXY-4 170 47 -72.35%
BenchmarkGCD100x10000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD100x10000/WithXY-4 200 67 -66.50%
BenchmarkGCD100x100000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD100x100000/WithXY-4 188 65 -65.43%
BenchmarkGCD1000x1000/WithoutXY-4 5 5 +0.00%
BenchmarkGCD1000x1000/WithXY-4 2435 1193 -51.01%
BenchmarkGCD1000x10000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD1000x10000/WithXY-4 2211 1076 -51.33%
BenchmarkGCD1000x100000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD1000x100000/WithXY-4 2271 1108 -51.21%
BenchmarkGCD10000x10000/WithoutXY-4 5 5 +0.00%
BenchmarkGCD10000x10000/WithXY-4 23183 11605 -49.94%
BenchmarkGCD10000x100000/WithoutXY-4 8 8 +0.00%
BenchmarkGCD10000x100000/WithXY-4 23421 11717 -49.97%
BenchmarkGCD100000x100000/WithoutXY-4 5 5 +0.00%
BenchmarkGCD100000x100000/WithXY-4 232976 116815 -49.86%

benchmark old bytes new bytes delta
BenchmarkGCD10x10/WithoutXY-4 208 208 +0.00%
BenchmarkGCD10x10/WithXY-4 736 432 -41.30%
BenchmarkGCD10x100/WithoutXY-4 256 256 +0.00%
BenchmarkGCD10x100/WithXY-4 896 432 -51.79%
BenchmarkGCD10x1000/WithoutXY-4 368 368 +0.00%
BenchmarkGCD10x1000/WithXY-4 1856 1152 -37.93%
BenchmarkGCD10x10000/WithoutXY-4 1616 1616 +0.00%
BenchmarkGCD10x10000/WithXY-4 7920 7376 -6.87%
BenchmarkGCD10x100000/WithoutXY-4 13776 13776 +0.00%
BenchmarkGCD10x100000/WithXY-4 68800 68176 -0.91%
BenchmarkGCD100x100/WithoutXY-4 208 208 +0.00%
BenchmarkGCD100x100/WithXY-4 6960 2112 -69.66%
BenchmarkGCD100x1000/WithoutXY-4 544 560 +2.94%
BenchmarkGCD100x1000/WithXY-4 7280 2400 -67.03%
BenchmarkGCD100x10000/WithoutXY-4 2896 2912 +0.55%
BenchmarkGCD100x10000/WithXY-4 15280 10002 -34.54%
BenchmarkGCD100x100000/WithoutXY-4 27344 27365 +0.08%
BenchmarkGCD100x100000/WithXY-4 88288 83427 -5.51%
BenchmarkGCD1000x1000/WithoutXY-4 544 544 +0.00%
BenchmarkGCD1000x1000/WithXY-4 178288 40043 -77.54%
BenchmarkGCD1000x10000/WithoutXY-4 3344 3136 -6.22%
BenchmarkGCD1000x10000/WithXY-4 188720 54432 -71.16%
BenchmarkGCD1000x100000/WithoutXY-4 27792 27592 -0.72%
BenchmarkGCD1000x100000/WithXY-4 373872 239447 -35.95%
BenchmarkGCD10000x10000/WithoutXY-4 4288 4288 +0.00%
BenchmarkGCD10000x10000/WithXY-4 11935584 481875 -95.96%
BenchmarkGCD10000x100000/WithoutXY-4 31296 28834 -7.87%
BenchmarkGCD10000x100000/WithXY-4 13237088 1662620 -87.44%
BenchmarkGCD100000x100000/WithoutXY-4 40768 40768 +0.00%
BenchmarkGCD100000x100000/WithXY-4 1165518864 14256010 -98.78%

Change-Id: I652b3244bd074a03f3bc9a87c282330f9e5f1507
Reviewed-on: https://go-review.googlesource.com/21506Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

187afdeb

math/big: add s390x function implementations · 1e7c61d8

Michael Munday authored Mar 20, 2016

Change-Id: I2aadc885d6330460e494c687757f07c5e006f3b0
Reviewed-on: https://go-review.googlesource.com/20937Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1e7c61d8

sync/atomic: add s390x implementations of atomic functions · 7da42d75

Michael Munday authored Mar 20, 2016

Load and store instructions are atomic on s390x.

Change-Id: I33c641a75954f4fbd301b11a467cb57872038880
Reviewed-on: https://go-review.googlesource.com/20947Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

7da42d75

go/types: make Identical(nil, T) == Identical(T, nil) · 95a895df

Alan Donovan authored Apr 07, 2016

Fixes #15173

Change-Id: I353756f7bc36db0d2b24d40c80771481b7b18f6b
Reviewed-on: https://go-review.googlesource.com/21585Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

95a895df

Revert "runtime: merge lfstack{Pack,Unpack} into one file" · 9cc9e95b

Dave Cheney authored Apr 07, 2016

This broke solaris, which apparently does use the upper 17 bits of the address space.

This reverts commit 3b02c5b1.

Change-Id: Iedfe54abd0384960845468205f20191a97751c0b
Reviewed-on: https://go-review.googlesource.com/21652Reviewed-by: Dave Cheney <dave@cheney.net>

9cc9e95b

cmd/compile: fold CMPconst and SHR · 8448d3aa

Alexandru Moșoi authored Apr 05, 2016

Fold the comparison when the SHR result is small.

Useful for:
- murmur mix like hashing where higher bits are desirable, i.e. hash = uint32(i * C) >> 18
- integer log2 via DeBruijn sequence: http://graphics.stanford.edu/~seander/bithacks.html#IntegerLogDeBruijn

Change-Id: If70ae18cb86f4cc83ab6213f88ced03cc4986156
Reviewed-on: https://go-review.googlesource.com/21514
Run-TryBot: Alexandru Moșoi <alexandru@mosoi.ro>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>

8448d3aa