1. 22 Feb, 2017 5 commits
    • Lynn Boger's avatar
      runtime: more detail for crash_test.go · ea48c9d2
      Lynn Boger authored
      This updates the testcase to display the timestamps for the
      runtime.a, it dependent packages atomic.a and sys.a, and
      source files.
      
      Change-Id: Id2901b4e8aa8eb9775c4f404ac01cc07b394ba91
      Reviewed-on: https://go-review.googlesource.com/37332
      Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      ea48c9d2
    • Michael Munday's avatar
      cmd/compile: zero extend when replacing load-hit-store on s390x · 094992e2
      Michael Munday authored
      Keith pointed out that these rules should zero extend during the review
      of CL 36845. In practice the generic rules are responsible for eliminating
      most load-hit-stores and they do not have this problem. When the s390x
      rules are triggered any cast following the elided load-hit-store is
      kept because of the sequence the rules are applied in (i.e. the load is
      removed before the zero extension gets a chance to be merged into the load).
      It is therefore not clear that this issue results in any functional bugs.
      
      This CL includes a test, but it only tests the generic rules currently.
      
      Change-Id: Idbc43c782097a3fb159be293ec3138c5b36858ad
      Reviewed-on: https://go-review.googlesource.com/37154
      Run-TryBot: Michael Munday <munday@ca.ibm.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarKeith Randall <khr@golang.org>
      094992e2
    • David Chase's avatar
      cmd/compile: add opcode flag hasSideEffects for do-not-remove · 11b28309
      David Chase authored
      Added a flag to generic and various architectures' atomic
      operations that are judged to have observable side effects
      and thus cannot be dead-code-eliminated.
      
      Test requires GOMAXPROCS > 1 without preemption in loop.
      
      Fixes #19182.
      
      Change-Id: Id2230031abd2cca0bbb32fd68fc8a58fb912070f
      Reviewed-on: https://go-review.googlesource.com/37333
      Run-TryBot: David Chase <drchase@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      11b28309
    • Ian Lance Taylor's avatar
      reflect: fix bucketOf to only look at ptrdata entries in gcdata · b5e51943
      Ian Lance Taylor authored
      The gcdata field only records ptrdata entries, not size entries.
      
      Also fix an obsolete comment: the enforced limit on pointer maps is
      now 2048 bytes, not 16 bytes.
      
      I wasn't able to contruct a test case for this. It would require
      building a type whose size is greater than 64 bytes but less than 128
      bytes, with at least one pointer in first 64 bytes but no pointers
      after the first 64 bytes, such that the linker arranges for the one
      byte gcbits value to be immediately followed by a non-zero byte.
      
      Change-Id: I9118d3e4ec6f07fd18b72f621c1e5f4fdfe5f80b
      Reviewed-on: https://go-review.googlesource.com/37142
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAustin Clements <austin@google.com>
      b5e51943
    • Ian Lance Taylor's avatar
      cmd/compile: update builtin writeBarrier to match runtime · db6e27c3
      Ian Lance Taylor authored
      The definition of writeBarrier in the runtime was changed in CL 22855
      to include padding. Update the definition built in to the compiler to match.
      This doesn't affect the generated code, as the compiler sets the type
      to use anyhow, but having them be different seems clearly wrong.
      
      Change-Id: I8eac05bf70a424a0b2338ba5e9e41af231316de0
      Reviewed-on: https://go-review.googlesource.com/37377
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      db6e27c3
  2. 21 Feb, 2017 22 commits
  3. 20 Feb, 2017 1 commit
  4. 19 Feb, 2017 7 commits
  5. 18 Feb, 2017 4 commits
  6. 17 Feb, 2017 1 commit
    • Robert Griesemer's avatar
      math/bits: added benchmarks for Leading/TrailingZeros · a4a3d63d
      Robert Griesemer authored
      BenchmarkLeadingZeros-8      	200000000	         8.80 ns/op
      BenchmarkLeadingZeros8-8     	200000000	         8.21 ns/op
      BenchmarkLeadingZeros16-8    	200000000	         7.49 ns/op
      BenchmarkLeadingZeros32-8    	200000000	         7.80 ns/op
      BenchmarkLeadingZeros64-8    	200000000	         8.67 ns/op
      
      BenchmarkTrailingZeros-8     	1000000000	         2.05 ns/op
      BenchmarkTrailingZeros8-8    	2000000000	         1.94 ns/op
      BenchmarkTrailingZeros16-8   	2000000000	         1.94 ns/op
      BenchmarkTrailingZeros32-8   	2000000000	         1.92 ns/op
      BenchmarkTrailingZeros64-8   	2000000000	         2.03 ns/op
      
      Change-Id: I45497bf2d6369ba6cfc88ded05aa735908af8908
      Reviewed-on: https://go-review.googlesource.com/37220
      Run-TryBot: Robert Griesemer <gri@golang.org>
      Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
      a4a3d63d