An error occurred fetching the project authors.
  1. 04 Jan, 2017 1 commit
  2. 31 Dec, 2016 1 commit
  3. 30 Dec, 2016 1 commit
  4. 15 Dec, 2016 1 commit
    • Brad Fitzpatrick's avatar
      net/http: deflake TestServerTimeouts maybe · c1d449c4
      Brad Fitzpatrick authored
      I haven't been able to reproduce this one, but change a few suspect
      things in this test. Notably, using the global "Get" function and thus
      using the DefaultTransport was buggy in a parallel test. Then add some error
      checks and close a TCP connection.
      
      Hopefully the failure wasn't timing-related.
      
      Fixes #18036 (I hope)
      
      Change-Id: I4904e42e40b26d488cf82111424a1d4d46f42dae
      Reviewed-on: https://go-review.googlesource.com/34490
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      c1d449c4
  5. 30 Nov, 2016 1 commit
  6. 22 Nov, 2016 1 commit
  7. 15 Nov, 2016 2 commits
  8. 14 Nov, 2016 1 commit
  9. 13 Nov, 2016 2 commits
  10. 11 Nov, 2016 2 commits
  11. 10 Nov, 2016 1 commit
  12. 04 Nov, 2016 1 commit
  13. 03 Nov, 2016 1 commit
  14. 01 Nov, 2016 1 commit
  15. 26 Oct, 2016 1 commit
  16. 21 Oct, 2016 1 commit
  17. 18 Oct, 2016 1 commit
    • Brad Fitzpatrick's avatar
      net/http: make Server Handler's Request.Context be done on conn errors · faf882d1
      Brad Fitzpatrick authored
      This CL changes how the http1 Server reads from the client.
      
      The goal of this change is to make the Request.Context given to Server
      Handlers become done when the TCP connection dies (has seen any read
      or write error). I didn't finish that for Go 1.7 when Context was
      added to http package.
      
      We can't notice the peer disconnect unless we're blocked in a Read
      call, though, and previously we were only doing read calls as needed,
      when reading the body or the next request. One exception to that was
      the old pre-context CloseNotifier mechanism.
      
      The implementation of CloseNotifier has always been tricky. The past
      few releases have contained the complexity and moved the
      reading-from-TCP-conn logic into the "connReader" type. This CL
      extends connReader to make sure that it's always blocked in a Read
      call, at least once the request body has been fully consumed.
      
      In the process, this deletes all the old CloseNotify code and unifies
      it with the context cancelation code. The two notification mechanisms
      are nearly identical, except the CloseNotify path always notifies on
      the arrival of pipelined HTTP/1 requests. We might want to change that
      in a subsequent commit. I left a TODO for that. For now there's no
      change in behavior except that the context now cancels as it was
      supposed to.
      
      As a bonus that fell out for free, a Handler can now use CloseNotifier
      and Hijack together in the same request now.
      
      Fixes #15224 (make http1 Server always in a Read, like http2)
      Fixes #15927 (cancel context when underlying connection closes)
      Updates #9763 (CloseNotifier + Hijack)
      
      Change-Id: I972cf6ecbab7f1230efe8cc971e89f8e6e56196b
      Reviewed-on: https://go-review.googlesource.com/31173
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      faf882d1
  18. 13 Oct, 2016 1 commit
  19. 30 Aug, 2016 1 commit
  20. 16 Aug, 2016 1 commit
  21. 27 Jul, 2016 1 commit
  22. 28 Jun, 2016 1 commit
  23. 27 Jun, 2016 1 commit
  24. 15 Jun, 2016 1 commit
  25. 06 Jun, 2016 2 commits
  26. 18 May, 2016 2 commits
  27. 11 May, 2016 1 commit
  28. 06 May, 2016 1 commit
  29. 01 May, 2016 1 commit
  30. 11 Apr, 2016 3 commits
  31. 31 Mar, 2016 1 commit
    • Brad Fitzpatrick's avatar
      net/http: allow Handlers to handle http2 upgrade PRI requests · a6557a05
      Brad Fitzpatrick authored
      The http2 spec defines a magic string which initates an http2 session:
      
          "PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n"
      
      It was intentionally chosen to kinda look like an HTTP request, but
      just different enough to break things not ready for it. This change
      makes Go ready for it.
      
      Notably: Go now accepts the request header (the prefix "PRI *
      HTTP/2.0\r\n\r\n") as a valid request, even though it doesn't have a
      Host header. But we now mark it as "Connection: close" and teach the
      Server to never read a second request from the connection once that's
      seen. If the http.Handler wants to deal with the upgrade, it has to
      hijack the request, read out the "body", compare it against
      "SM\r\n\r\n", and then speak http2. One of the new tests demonstrates
      that hijacking.
      
      Fixes #14451
      Updates #14141 (h2c)
      
      Change-Id: Ib46142f31c55be7d00c56fa2624ec8a232e00c43
      Reviewed-on: https://go-review.googlesource.com/21327Reviewed-by: default avatarAndrew Gerrand <adg@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      a6557a05
  32. 07 Mar, 2016 1 commit
    • Caio Marcelo de Oliveira Filho's avatar
      net/http: TimeoutHandler should start timer when serving request · bd68b8ab
      Caio Marcelo de Oliveira Filho authored
      TimeoutHandler was starting the Timer when the handler was created,
      instead of when serving a request. It also was sharing it between
      multiple requests, which is incorrect, as the requests might start
      at different times.
      
      Store the timeout duration and create the Timer when ServeHTTP is
      called. Different requests will have different timers.
      
      The testing plumbing was simplified to store the channel used to
      control when timeout happens. It overrides the regular timer.
      
      Fixes #14568.
      
      Change-Id: I4bd51a83f412396f208682d3ae5e382db5f8dc81
      Reviewed-on: https://go-review.googlesource.com/20046Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      bd68b8ab
  33. 02 Mar, 2016 1 commit
    • Brad Fitzpatrick's avatar
      all: single space after period. · 5fea2ccc
      Brad Fitzpatrick authored
      The tree's pretty inconsistent about single space vs double space
      after a period in documentation. Make it consistently a single space,
      per earlier decisions. This means contributors won't be confused by
      misleading precedence.
      
      This CL doesn't use go/doc to parse. It only addresses // comments.
      It was generated with:
      
      $ perl -i -npe 's,^(\s*// .+[a-z]\.)  +([A-Z]),$1 $2,' $(git grep -l -E '^\s*//(.+\.)  +([A-Z])')
      $ go test go/doc -update
      
      Change-Id: Iccdb99c37c797ef1f804a94b22ba5ee4b500c4f7
      Reviewed-on: https://go-review.googlesource.com/20022Reviewed-by: default avatarRob Pike <r@golang.org>
      Reviewed-by: default avatarDave Day <djd@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      5fea2ccc