Commit 119f9a18 authored by Aaron Jacobs's avatar Aaron Jacobs

Changed the guidance for dealing with lookup counts at unmount time.

parent c1d30a38
...@@ -237,7 +237,7 @@ func (o *SetInodeAttributesOp) toBazilfuseResponse() (bfResp interface{}) { ...@@ -237,7 +237,7 @@ func (o *SetInodeAttributesOp) toBazilfuseResponse() (bfResp interface{}) {
// revalidating. // revalidating.
// //
// In contrast to all other inodes, RootInodeID begins with an implicit // In contrast to all other inodes, RootInodeID begins with an implicit
// reference count of one, without a corresponding op to increase it. (There // lookup count of one, without a corresponding op to increase it. (There
// could be no such op, because the root cannot be referred to by name.) Code // could be no such op, because the root cannot be referred to by name.) Code
// walk: // walk:
// //
...@@ -248,10 +248,10 @@ func (o *SetInodeAttributesOp) toBazilfuseResponse() (bfResp interface{}) { ...@@ -248,10 +248,10 @@ func (o *SetInodeAttributesOp) toBazilfuseResponse() (bfResp interface{}) {
// //
// * (http://goo.gl/vPD9Oh) fuse_iget increments nlookup. // * (http://goo.gl/vPD9Oh) fuse_iget increments nlookup.
// //
// File systems should not make assumptions about whether they will or will not // File systems should tolerate but not rely on receiving forget ops for
// receive a ForgetInodeOp for the root inode. Experimentally, OS X seems to // remaining inodes when the file system unmounts, including the root inode.
// never send one, while Linux appears to send one only sometimes. (Cf. // Rather they should take fuse.Connection.ReadOp returning io.EOF as
// http://goo.gl/EUbxEg, fuse-devel thread "Root inode lookup count"). // implicitly decrementing all lookup counts to zero.
type ForgetInodeOp struct { type ForgetInodeOp struct {
commonOp commonOp
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment