• Gang He's avatar
    ocfs2: ensure that dlm lockspace is created by kernel module · 01a36b67
    Gang He authored
    We encountered a bug from the customer, the user did a fsck.ocfs2 on the
    file system and exited unusually, the lockspace (with LVB size = 32) was
    left in the kernel space, next, the user mounted this file system, the
    kernel module did not create a new lockspace (LVB size = 64) via calling
    dlm_new_lockspace() function in mounting stage, just used the existing
    lockspace, created by the user space tool, this would lead the user was
    not able to mount this file system from the other nodes, with the error
    message like:
    
      dlm: 032F5......: config mismatch: 64,0 nodeid 177127961: 32,0
      (mount.ocfs2,26981,46):ocfs2_dlm_init:2995 ERROR: status = -71
      ocfs2_mount_volume:1881 ERROR: status = -71
      ocfs2_fill_super:1236 ERROR: status = -71
    
    The user found it very difficult to find the root cause, then, we
    brought out this patch to relieve such problem.
    
    First, we add one more flag in calling dlm_new_lockspace() function, to
    make sure the lockspace is created by kernel module itself, and this
    change will not affect the backward compatibility.
    
    Second, the obvious error message is reported in the kernel log, let the
    user be more easy to find the root cause.
    
    This patch will be used to insure the dlm lockspace is created by kernel
    module when mounting a ocfs2 file system.  There are two ways to create
    a lockspace, from user space and kernel space, but the same name
    lockspaces probably have different lvblen lengths/flags.
    
    To avoid this mix using, we add one more flag DLM_LSFL_NEWEXCL, it will
    make sure the dlm lockspace is created by kernel module when mounting.
    Secondly, if a user space program (ocfs2-tools) is running on a file
    system, the user tries to mount this file system in the cluster, DLM
    module will return a -EEXIST or -EPROTO errno, we should give the user a
    obvious error message, then, the user can let that user space tool exit
    before mounting the file system again.
    
    Link: http://lkml.kernel.org/r/1463731940-13044-2-git-send-email-ghe@suse.comSigned-off-by: default avatarGang He <ghe@suse.com>
    Reviewed-by: default avatarGoldwyn Rodrigues <rgoldwyn@suse.com>
    Reviewed-by: default avatarMark Fasheh <mfasheh@suse.de>
    Cc: Joel Becker <jlbec@evilplan.org>
    Cc: Junxiao Bi <junxiao.bi@oracle.com>
    Cc: Joseph Qi <joseph.qi@huawei.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    01a36b67
stack_user.c 29.3 KB