• Like Xu's avatar
    KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter() · 02791a5c
    Like Xu authored
    The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
    fixed counter using the PERF_TYPE_HARDWAR type and the gp being
    able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
    depending on the pmc->eventsel value.
    
    After 'commit 76187563 ("KVM: x86/pmu: Setup pmc->eventsel
    for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
    been setup with the same semantic value and will not be changed during
    the guest runtime.
    
    The original story of using the PERF_TYPE_HARDWARE type is to emulate
    guest architecture PMU on a host without architecture PMU (the Pentium 4),
    for which the guest vPMC needs to be reprogrammed using the kernel
    generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
    wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
    to use the PERF_TYPE_RAW type only in practice to program both gp and
    fixed counters naturally in the reprogram_counter().
    
    To make the gp and fixed counters more semantically symmetrical,
    the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
    via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
    
    Cc: Peter Zijlstra <peterz@infradead.org>
    Suggested-by: default avatarJim Mattson <jmattson@google.com>
    Signed-off-by: default avatarLike Xu <likexu@tencent.com>
    Message-Id: <20220518132512.37864-9-likexu@tencent.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    02791a5c
pmu.c 17 KB