• Chris Wilson's avatar
    drm/i915: Fix write-read race with multiple rings · 02978ff5
    Chris Wilson authored
    Daniel noticed a problem where is we wrote to an object with ring A in
    the middle of a very long running batch, then executed a quick batch on
    ring B before a batch that reads from the same object, its obj->ring would
    now point to ring B, but its last_write_seqno would be still relative to
    ring A. This would allow for the user to read from the object before the
    GPU had completed the write, as set_domain would only check that ring B
    had passed the last_write_seqno.
    
    To fix this simply (and inelegantly), we bump the last_write_seqno when
    switching rings so that the last_write_seqno is always relative to the
    current obj->ring.
    
    This fixes igt/tests/gem_write_read_ring_switch.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: stable@vger.kernel.org
    [danvet: Add note about the newly created igt which exercises this
    bug.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    02978ff5
i915_gem.c 116 KB