• Lee Jones's avatar
    regulator: tps65218-regulator: Remove pointless 'is unsigned int <0' check · 02d88863
    Lee Jones authored
    'rid' is declared as unsigned int, so there is little point checking for <0.
    
    Removing these checks fixes the following W=1 warnings:
    
     drivers/regulator/tps65218-regulator.c: In function ‘tps65218_pmic_set_suspend_enable’:
     drivers/regulator/tps65218-regulator.c:131:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
     131 | if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
     | ^
     drivers/regulator/tps65218-regulator.c: In function ‘tps65218_pmic_set_suspend_disable’:
     drivers/regulator/tps65218-regulator.c:144:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
     144 | if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
     | ^
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    Cc: Keerthy <j-keerthy@ti.com>
    Cc: Tero Kristo <t-kristo@ti.com>
    Cc: Dave Gerlach <d-gerlach@ti.com>
    Cc: linux-omap@vger.kernel.org
    Link: https://lore.kernel.org/r/20200626065738.93412-8-lee.jones@linaro.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    02d88863
tps65218-regulator.c 11.9 KB