• Hangbin Liu's avatar
    sched: add new attr TCA_EXT_WARN_MSG to report tc extact message · 0349b877
    Hangbin Liu authored
    We will report extack message if there is an error via netlink_ack(). But
    if the rule is not to be exclusively executed by the hardware, extack is not
    passed along and offloading failures don't get logged.
    
    In commit 81c7288b ("sched: cls: enable verbose logging") Marcelo
    made cls could log verbose info for offloading failures, which helps
    improving Open vSwitch debuggability when using flower offloading.
    
    It would also be helpful if userspace monitor tools, like "tc monitor",
    could log this kind of message, as it doesn't require vswitchd log level
    adjusment. Let's add a new tc attributes to report the extack message so
    the monitor program could receive the failures. e.g.
    
      # tc monitor
      added chain dev enp3s0f1np1 parent ffff: chain 0
      added filter dev enp3s0f1np1 ingress protocol all pref 49152 flower chain 0 handle 0x1
        ct_state +trk+new
        not_in_hw
              action order 1: gact action drop
               random type none pass val 0
               index 1 ref 1 bind 1
    
      Warning: mlx5_core: matching on ct_state +new isn't supported.
    
    In this patch I only report the extack message on add/del operations.
    It doesn't look like we need to report the extack message on get/dump
    operations.
    
    Note this message not only reporte to multicast groups, it could also
    be reported unicast, which may affect the current usersapce tool's behaivor.
    Suggested-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
    Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
    Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
    Link: https://lore.kernel.org/r/20230113034353.2766735-1-liuhangbin@gmail.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    0349b877
sch_api.c 55.5 KB