• Petr Machata's avatar
    selftests: forwarding: ethtool_extended_state: Convert to busywait · 04cfbc1d
    Petr Machata authored
    Currently, this script sets up the test scenario, which is supposed to end
    in an inability of the system to negotiate a link. It then waits for a bit,
    and verifies that the system can diagnose why the link was not established.
    
    The wait time for the scenario where different link speeds are forced on
    the two ends of a loopback cable, was set to 4 seconds, which exactly
    covered it. As of a recent mlxsw firmware update, this time gets longer,
    and this test starts failing.
    
    The time that selftests currently wait for links to be established is
    currently $WAIT_TIMEOUT, or 20 seconds. It seems reasonable that if this is
    the time necessary to establish and bring up a link, it should also be
    enough to determine that a link cannot be established and why.
    
    Therefore in this patch, convert the sleeps to busywaits, so that if a
    failure is established sooner (as is expected), the test runs quicker. And
    use $WAIT_TIMEOUT as the time to wait.
    Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
    Reviewed-by: default avatarAmit Cohen <amcohen@nvidia.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    04cfbc1d
ethtool_extended_state.sh 2.08 KB