• Canjiang Lu's avatar
    mm/slub: remove obsolete comment · 05088e5d
    Canjiang Lu authored
    The obsolete comment removed in this patch was introduced by
    51df1142 ("slub: Dynamically size kmalloc cache allocations").
    
    I paste related modification from that commit:
    
    +#ifdef CONFIG_NUMA
    +       /*
    +        * Allocate kmem_cache_node properly from the kmem_cache slab.
    +        * kmem_cache_node is separately allocated so no need to
    +        * update any list pointers.
    +        */
    +       temp_kmem_cache_node = kmem_cache_node;
    
    +       kmem_cache_node = kmem_cache_alloc(kmem_cache, GFP_NOWAIT);
    +       memcpy(kmem_cache_node, temp_kmem_cache_node, kmem_size);
    +
    +       kmem_cache_bootstrap_fixup(kmem_cache_node);
    +
    +       caches++;
    +#else
    +       /*
    +        * kmem_cache has kmem_cache_node embedded and we moved it!
    +        * Update the list heads
    +        */
    +       INIT_LIST_HEAD(&kmem_cache->local_node.partial);
    +       list_splice(&temp_kmem_cache->local_node.partial, &kmem_cache->local_node.partial);
    +#ifdef CONFIG_SLUB_DEBUG
    +       INIT_LIST_HEAD(&kmem_cache->local_node.full);
    +       list_splice(&temp_kmem_cache->local_node.full, &kmem_cache->local_node.full);
    +#endif
    
    As we can see there're used to distinguish the difference handling
    between NUMA/non-NUMA configuration in the original commit.  I think it
    doesn't make any sense in current implementation which is placed above
    kmem_cache_node = bootstrap(&boot_kmem_cache_node); So maybe it's better
    to remove them now?
    
    Link: http://lkml.kernel.org/r/5af26f58.1c69fb81.1be0e.c520SMTPIN_ADDED_BROKEN@mx.google.comSigned-off-by: default avatarCanjiang Lu <canjiang.lu@samsung.com>
    Acked-by: default avatarChristoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    05088e5d
slub.c 143 KB