• Niklas Cassel's avatar
    nvme: prevent double free in nvme_alloc_ns() error handling · 132be623
    Niklas Cassel authored
    When jumping to the out_put_disk label, we will call put_disk(), which will
    trigger a call to disk_release(), which calls blk_put_queue().
    
    Later in the cleanup code, we do blk_cleanup_queue(), which will also call
    blk_put_queue().
    
    Putting the queue twice is incorrect, and will generate a KASAN splat.
    
    Set the disk->queue pointer to NULL, before calling put_disk(), so that the
    first call to blk_put_queue() will not free the queue.
    
    The second call to blk_put_queue() uses another pointer to the same queue,
    so this call will still free the queue.
    
    Fixes: 85136c01 ("lightnvm: simplify geometry enumeration")
    Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    132be623
core.c 111 KB