• John Stultz's avatar
    time: Fix accumulation bug triggered by long delay. · 830ec045
    John Stultz authored
    The logarithmic accumulation done in the timekeeping has some overflow
    protection that limits the max shift value. That means it will take
    more then shift loops to accumulate all of the cycles. This causes
    the shift decrement to underflow, which causes the loop to never exit.
    
    The simplest fix would be simply to do a:
    	if (shift)
    		shift--;
    
    However that is not optimal, as we know the cycle offset is larger
    then the interval << shift, the above would make shift drop to zero,
    then we would be spinning for quite awhile accumulating at interval
    chunks at a time.
    
    Instead, this patch only decreases shift if the offset is smaller
    then cycle_interval << shift.  This makes sure we accumulate using
    the largest chunks possible without overflowing tick_length, and limits
    the number of iterations through the loop.
    
    This issue was found and reported by Sonic Zhang, who also tested the fix.
    Many thanks your explanation and testing!
    Reported-by: default avatarSonic Zhang <sonic.adi@gmail.com>
    Signed-off-by: default avatarJohn Stultz <johnstul@us.ibm.com>
    Tested-by: default avatarSonic Zhang <sonic.adi@gmail.com>
    LKML-Reference: <1268948850-5225-1-git-send-email-johnstul@us.ibm.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    830ec045
timekeeping.c 23.8 KB