• yangerkun's avatar
    ext4: dax: keep orphan list before truncate overflow allocated blocks · 59efe53e
    yangerkun authored
    Any extending write for ext4 requires the inode to be placed on the
    orphan list before the actual write. In addition, the inode can be
    actually removed from the orphan list only after all writes are
    completed. Otherwise we'd leave allocated blocks beyond i_disksize if we
    could not copy all the data into allocated block and e2fsck would
    complain.
    
    Currently, direct IO and buffered IO comply with this logic(buffered
    IO will truncate all overflow allocated blocks that has not been
    written successfully, and direct IO will truncate all allocated blocks
    when error occurs). However, dax write break this since dax write will
    remove the inode from the orphan list by calling
    ext4_handle_inode_extension unconditionally during extending write.
    
    We add a argument to help determine does we do a fully write, and for
    the case not fully write, we leave the inode on the orphan list, and the
    latter ext4_inode_extension_cleanup will help us truncate the overflow
    allocated blocks, and then remove the inode from the orphan list.
    Signed-off-by: default avataryangerkun <yangerkun@huawei.com>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Link: https://patch.msgid.link/20240829110222.126685-1-yangerkun@huaweicloud.comSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    59efe53e
file.c 25.4 KB