• Mark Brown's avatar
    arm64/sme: Set new vector length before reallocating · 05d881b8
    Mark Brown authored
    As part of fixing the allocation of the buffer for SVE state when changing
    SME vector length we introduced an immediate reallocation of the SVE state,
    this is also done when changing the SVE vector length for consistency.
    Unfortunately this reallocation is done prior to writing the new vector
    length to the task struct, meaning the allocation is done with the old
    vector length and can lead to memory corruption due to an undersized buffer
    being used.
    
    Move the update of the vector length before the allocation to ensure that
    the new vector length is taken into account.
    
    For some reason this isn't triggering any problems when running tests on
    the arm64 fixes branch (even after repeated tries) but is triggering
    issues very often after merge into mainline.
    
    Fixes: d4d5be94 ("arm64/fpsimd: Ensure SME storage is allocated after SVE VL changes")
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20230726-arm64-fix-sme-fix-v1-1-7752ec58af27@kernel.orgSigned-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    05d881b8
fpsimd.c 57.2 KB