• Johannes Berg's avatar
    iwlagn: fix TID use bug · 9a215e40
    Johannes Berg authored
    The driver everywhere uses max TID count as 9,
    which is wrong, it should be 8.
    
    I think the reason it uses 9 here is off-by-one
    confusion by whoever wrote this. We do use the
    value IWL_MAX_TID_COUNT for "not QoS/no TID"
    but that is completely correct even if it is 8
    and not 9 since 0-7 are only valid.
    
    As a side effect, this fixes the following bug:
    
     Open BA session requested for 00:23:cd:16:8a:7e tid 8
     ------------[ cut here ]------------
     kernel BUG at drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h:350!
     ...
    
    when you do
    echo "tx start 8" > /sys/kernel/debug/ieee80211/*/*/*/*/agg_status
    
    Cc: stable@vger.kernel.org
    Reported-by: default avatarNikolay Martynov <mar.kolya@gmail.com>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
    9a215e40
iwl-commands.h 132 KB