• Eran Ben Elisha's avatar
    net/mlx5e: Do not use non-EXT link modes in EXT mode · 24960574
    Eran Ben Elisha authored
    On some old Firmwares, connector type value was not supported, and value
    read from FW was 0. For those, driver used link mode in order to set
    connector type in link_ksetting.
    
    After FW exposed the connector type, driver translated the value to ethtool
    definitions. However, as 0 is a valid value, before returning PORT_OTHER,
    driver run the check of link mode in order to maintain backward
    compatibility.
    
    Cited patch added support to EXT mode.  With both features (connector type
    and EXT link modes) ,if connector_type read from FW is 0 and EXT mode is
    set, driver mistakenly compare EXT link modes to non-EXT link mode.
    Fixed that by skipping this comparison if we are in EXT mode, as connector
    type value is valid in this scenario.
    
    Fixes: 6a897372 ("net/mlx5: ethtool, Add ethtool support for 50Gbps per lane link modes")
    Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
    Reviewed-by: default avatarAya Levin <ayal@mellanox.com>
    Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
    24960574
en_ethtool.c 56.8 KB