• Kajol Jain's avatar
    powerpc/hv-gpci: Add return value check in affinity_domain_via_partition_show function · 070b71f4
    Kajol Jain authored
    To access hv-gpci kernel interface files data, the
    "Enable Performance Information Collection" option has to be set
    in hmc. Incase that option is not set and user try to read
    the interface files, it should give error message as
    operation not permitted.
    
    Result of accessing added interface files with disabled
    performance collection option:
    
    [command]# cat processor_bus_topology
    cat: processor_bus_topology: Operation not permitted
    
    [command]# cat processor_config
    cat: processor_config: Operation not permitted
    
    [command]# cat affinity_domain_via_domain
    cat: affinity_domain_via_domain: Operation not permitted
    
    [command]# cat affinity_domain_via_virtual_processor
    cat: affinity_domain_via_virtual_processor: Operation not permitted
    
    [command]# cat affinity_domain_via_partition
    
    Based on above result there is no error message when reading
    affinity_domain_via_partition file because of missing
    check for failed hcall. Fix this issue by adding
    a check in the start of affinity_domain_via_partition_show
    function, to return error incase hcall fails, with error type
    other then H_PARAMETER.
    
    Fixes: a15e0d6a
    
     ("powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show affinity domain via partition information")
    Reported-by: default avatarDisha Goel <disgoel@linux.vnet.ibm.com>
    Signed-off-by: default avatarKajol Jain <kjain@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://msgid.link/20231116122033.160964-1-kjain@linux.ibm.com
    070b71f4
hv-gpci.c 28.6 KB