• Herbert Xu's avatar
    [PF_KEY]: spirange should be in host byte order. · 0797db20
    Herbert Xu authored
    I'm looking through the xfrm_alloc_spi stuff and noticed that the
    netlink alloc_spi function takes the range in host order while the
    PFKEY alloc_spi function takes them in network order.
    
    First I thought that I stuffed up since I was the one who changed
    the code in the netlink interface to take them in host order :)
    
    But reading RFC 2367 seems to indicate otherwise.  It says that all
    fields are host order unless specified otherwise.  And the spirange
    fields are not specified to be network order at all.
    
    Looking at the existing PFKEY users:
    
    User Space
    ----------
    Openswan - Doesn't use PFKEY for this.
    Racoon - Puts zeros in there so it doesn't care.  However its test-pfkey
    	 program stores things in host order.
    ISAKMPD - Stores things in host order.
    
    So the conclusion is that we can and should change our PFKEY
    implementation to use host order for these fields.
    
    This patch does exactly that.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarDavid S. Miller <davem@redhat.com>
    0797db20
af_key.c 77.8 KB