• Paul Jackson's avatar
    [PATCH] memory page alloc minor cleanups · 0798e519
    Paul Jackson authored
    - s/freeliest/freelist/ spelling fix
    
    - Check for NULL *z zone seems useless - even if it could happen, so
      what?  Perhaps we should have a check later on if we are faced with an
      allocation request that is not allowed to fail - shouldn't that be a
      serious kernel error, passing an empty zonelist with a mandate to not
      fail?
    
    - Initializing 'z' to zonelist->zones can wait until after the first
      get_page_from_freelist() fails; we only use 'z' in the wakeup_kswapd()
      loop, so let's initialize 'z' there, in a 'for' loop.  Seems clearer.
    
    - Remove superfluous braces around a break
    
    - Fix a couple errant spaces
    
    - Adjust indentation on the cpuset_zone_allowed() check, to match the
      lines just before it -- seems easier to read in this case.
    
    - Add another set of braces to the zone_watermark_ok logic
    
    From: Paul Jackson <pj@sgi.com>
    
      Backout one item from a previous "memory page_alloc minor cleanups" patch.
       Until and unless we are certain that no one can ever pass an empty zonelist
      to __alloc_pages(), this check for an empty zonelist (or some BUG
      equivalent) is essential.  The code in get_page_from_freelist() blow ups if
      passed an empty zonelist.
    Signed-off-by: default avatarPaul Jackson <pj@sgi.com>
    Acked-by: default avatarChristoph Lameter <clameter@sgi.com>
    Cc: Nick Piggin <nickpiggin@yahoo.com.au>
    Signed-off-by: default avatarPaul Jackson <pj@sgi.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    0798e519
page_alloc.c 83.5 KB