• Nathan Chancellor's avatar
    KVM: x86: Fix clang -Wimplicit-fallthrough in do_host_cpuid() · 07ea4ab1
    Nathan Chancellor authored
    Clang warns:
    
      arch/x86/kvm/cpuid.c:739:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
              default:
              ^
      arch/x86/kvm/cpuid.c:739:2: note: insert 'break;' to avoid fall-through
              default:
              ^
              break;
      1 error generated.
    
    Clang is a little more pedantic than GCC, which does not warn when
    falling through to a case that is just break or return. Clang's version
    is more in line with the kernel's own stance in deprecated.rst, which
    states that all switch/case blocks must end in either break,
    fallthrough, continue, goto, or return. Add the missing break to silence
    the warning.
    
    Fixes: f144c49e ("KVM: x86: synthesize CPUID leaf 0x80000021h if useful")
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
    Message-Id: <20220322152906.112164-1-nathan@kernel.org>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    07ea4ab1
cpuid.c 39.6 KB