• Okash Khawaja's avatar
    staging: speakup: fix speakup-r empty line lockup · e5f5d0e2
    Okash Khawaja authored
    When cursor is at beginning of an empty or whitespace-only line and
    speakup-r typed, kernel locks up. This happens because deadlock of in
    input_event function over dev->event_lock, as demonstrated by lockdep
    logs. The reason for that is speakup simulates a down arrow - because
    cursor is at an empty line - while inside key press notifier handler
    which is ultimately triggered from input_event function. The simulated
    key press leads to input_event being called again, this time under its
    own context. So the spinlock is dev->event_lock is acquired while still
    being held.
    
    This patch ensures that key press is not simulated from inside key press
    notifier handler. Instead it delegates to cursor_timer. It starts the
    timer and passes RA_DOWN_ARROW as argument. When timer handler runs and
    sees RA_DOWN_ARROW, it will then call kbd_fakekey2(RA_DOWN_ARROW) which
    will correctly simulate the keypress inside timer context.
    
    When not inside key press notifier callback, the behaviour will remain
    the same as before this patch.
    Signed-off-by: default avatarOkash Khawaja <okash.khawaja@gmail.com>
    Reviewed-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    e5f5d0e2
main.c 58.6 KB