• Herve Codina's avatar
    net: stmmac: fix get_hw_feature() on old hardware · 075da584
    Herve Codina authored
    Some old IPs do not provide the hardware feature register.
    On these IPs, this register is read 0x00000000.
    
    In old driver version, this feature was handled but a regression came
    with the commit f10a6a35 ("stmmac: rework get_hw_feature function").
    Indeed, this commit removes the return value in dma->get_hw_feature().
    This return value was used to indicate the validity of retrieved
    information and used later on in stmmac_hw_init() to override
    priv->plat data if this hardware feature were valid.
    
    This patch restores the return code in ->get_hw_feature() in order
    to indicate the hardware feature validity and override priv->plat
    data only if this hardware feature is valid.
    
    Fixes: f10a6a35 ("stmmac: rework get_hw_feature function")
    Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    075da584
dwxgmac2_dma.c 15.4 KB