• Darrick J. Wong's avatar
    powerpc/therm_adt746x: Record pwm invert bit at module load time] · 1496e89a
    Darrick J. Wong authored
    In commit 0512a9a8, we unilaterally zero the
    "pwm invert" bit in the fan behavior configuration register.  On my PowerBook
    G4, this results in the fans going to full speed at low temperature and
    shutting off at high temperature because the pwm invert bit is supposed to be
    set.
    
    Therefore, record the pwm invert bit at driver load time, and write the bit
    into the fan behavior control register.  This restores correct behavior on my
    PBG4 and should work around the bit being set to the wrong value after
    suspend/resume (which is what the original patch was trying to fix).  It also
    fixes a minor omission where the pwm invert bit correction is NOT performed
    when switching into automatic mode.
    Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
    CC: <stable@kernel.org>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    1496e89a
therm_adt746x.c 17.7 KB