• Herton Ronaldo Krzesinski's avatar
    Revert "V4L/DVB (11906): saa7134: Use v4l bounding/alignment function" · 0a062033
    Herton Ronaldo Krzesinski authored
    This reverts commit bc52d6eb.
    
    On newer kernels, a saa7134 board stopped to display TV video output
    properly. After a bisect, I found it as the commit causing the issue.
    Turns out that v4l_bound_align_image isn't doing the same bounding
    calculation as manually done previously in saa7134_try_fmt_vid_cap.
    
    What isn't equal is the calculation done in clamp align, while
    previously it did "f->fmt.pix.width &= ~0x03", clamp_align function
    does "Round to nearest aligned value" as stated in the comment, which
    yields a different result. If I comment the round calculation in
    clamp_align like this: "x = (x /*+ (1 << (align - 1))*/) & mask",
    I get it fixed too, because this way the calculation is the same then.
    Signed-off-by: default avatarHerton Ronaldo Krzesinski <herton@mandriva.com.br>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    0a062033
saa7134-video.c 67.5 KB