• Thomas Richter's avatar
    perf annotate: Fix s390 target function disassembly · 0b58a77c
    Thomas Richter authored
    'perf annotate' displays function call assembler instructions with a
    right arrow. Hitting enter on this line/instruction causes the browser
    to disassemble this target function and show it on the screen.  On s390
    this results in an error message 'The called function was not found.'
    
    The function call assembly line parsing does not handle the s390 bras
    and brasl instructions. Function call__parse expects the target as first
    operand:
    
    	callq	e9140 <__fxstat>
    
    S390 has a register number as first operand:
    
    	brasl	%r14,41d60 <abort>
    
    Therefore the target addresses on s390 are always zero which is an
    invalid address.
    
    Introduce a s390 specific call parsing function which skips the first
    operand on s390.
    Signed-off-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
    Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Link: http://lkml.kernel.org/r/20180307134325.96106-1-tmricht@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    0b58a77c
instructions.c 2.35 KB