• AngeloGioacchino Del Regno's avatar
    regulator: core: Enlarge max OF property name length to 64 chars · e9bb4a06
    AngeloGioacchino Del Regno authored
    Some regulator drivers may be defining very long names: this is the
    case with the qcom_smd and qcom_spmi regulators, where we need to
    parse the regulator parents from DT.
    
    For clarity, this is an example:
    { "l13a", QCOM_SMD_RPM_LDOA, 13, &pm660_ht_lvpldo,
      "vdd_l8_l9_l10_l11_l12_l13_l14" },
    pm660-regulators {
    	...
    	vdd_l8_l9_l10_l11_l12_l13_l14-supply = <&vreg_s4a_2p04>
    	...
    };
    Now, with a 32 characters limit, the function is trying to parse,
    exactly, "vdd_l8_l9_l10_l11_l12_l13_l14-s" (32 chars) instead of
    the right one, which is 37 chars long in this specific case.
    
    ... And this is not only the case with PM660/PM660L, but also with
    PMA8084, PM8916, PM8950 and others that are not implemented yet.
    
    The length of 64 chars was chosen based on the longest parsed property
    name that I could find, which is in PM8916, and would be 53 characters
    long.
    At that point, rounding that to 64 looked like being the best idea.
    Signed-off-by: default avatarAngeloGioacchino Del Regno <kholk11@gmail.com>
    Link: https://lore.kernel.org/r/20200926125549.13191-2-kholk11@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    e9bb4a06
core.c 151 KB