• Matt Johnston's avatar
    mctp: Avoid leak of mctp_sk_key · 0b93aed2
    Matt Johnston authored
    mctp_key_alloc() returns a key already referenced.
    
    The mctp_route_input() path receives a packet for a bind socket and
    allocates a key. It passes the key to mctp_key_add() which takes a
    refcount and adds the key to lists. mctp_route_input() should then
    release its own refcount when setting the key pointer to NULL.
    
    In the mctp_alloc_local_tag() path (for mctp_local_output()) we
    similarly need to unref the key before returning (mctp_reserve_tag()
    takes a refcount and adds the key to lists).
    
    Fixes: 73c61845 ("mctp: locking, lifetime and validity changes for sk_keys")
    Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
    Reviewed-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0b93aed2
route.c 27.1 KB