• Ming Lei's avatar
    blk-mq: order getting budget and driver tag · 0bca799b
    Ming Lei authored
    This patch orders getting budget and driver tag by making sure to acquire
    driver tag after budget is got, this way can help to avoid the following
    race:
    
    1) before dispatch request from scheduler queue, get one budget first, then
    dequeue a request, call it request A.
    
    2) in another IO path for dispatching request B which is from hctx->dispatch,
    driver tag is got, then try to get budget in blk_mq_dispatch_rq_list(),
    unfortunately the budget is held by request A.
    
    3) meantime blk_mq_dispatch_rq_list() is called for dispatching request
    A, and try to get driver tag first, unfortunately no driver tag is
    available because the driver tag is held by request B
    
    4) both two IO pathes can't move on, and IO stall is caused.
    
    This issue can be observed when running dbench on USB storage.
    
    This patch fixes this issue by always getting budget before getting
    driver tag.
    
    Cc: stable@vger.kernel.org
    Fixes: de148297 ("blk-mq: introduce .get_budget and .put_budget in blk_mq_ops")
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Bart Van Assche <bart.vanassche@wdc.com>
    Cc: Omar Sandoval <osandov@fb.com>
    Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    0bca799b
blk-mq.c 77.9 KB